Commit Graph

3318 Commits

Author SHA1 Message Date
Andrey 9a19eaa320 tear down Engine god object #4511
just trying different things
2022-09-05 03:18:32 -04:00
Andrey 99d8801dc6 tear down Engine god object #4511
just trying different things
2022-09-05 02:59:38 -04:00
Andrey 268a5c7964 tear down Engine god object #4511
just trying different things
2022-09-05 02:44:06 -04:00
Andrey 6d72805a56 tear down Engine god object #4511
just trying different things
2022-09-05 02:28:46 -04:00
Andrey c1b218b772 refactoring: let's use different names for different things 2022-09-05 01:16:24 -04:00
Andrey d51511a15e refactoring: moving field 2022-09-05 00:53:05 -04:00
Andrey ccfe2a5d58 refactoring: splitting header where cpp was already split 2022-09-05 00:48:38 -04:00
Andrey a0b52eeb2f different file names for different entities 2022-09-04 23:11:19 -04:00
GitHub gen-configs Action aed7b77535 Auto-generated configs and docs 2022-09-05 02:44:56 +00:00
Andrey 71e5fbcb55 refactoring: reducing outputChannels copy 2022-09-04 22:38:05 -04:00
GitHub gen-configs Action bc332bf879 Auto-generated configs and docs 2022-09-04 13:57:19 +00:00
Matthew Kennedy b0cbe01673
use defs instead of magic numbers (#4523)
* use defs instead of magic numbers

* consecutive
2022-09-04 09:52:14 -04:00
Matthew Kennedy 9407150544
more granular trigger error messages (#4526)
* granular trigger error messages

* adjust test expectations

* explicitly test behavior
2022-09-04 09:15:24 -04:00
GitHub gen-configs Action fa3b2fe009 Auto-generated configs and docs 2022-09-03 21:35:26 +00:00
rusefi 2a08cd5c2b refactoring: reducing outputChannels copy 2022-09-03 17:29:35 -04:00
Andrey 632bf967bb refactoring: reducing outputChannels copy 2022-09-03 17:12:47 -04:00
Andrey 6b4e6c8169 tear down Engine god object #4511
just trying different things
2022-09-03 11:07:26 -04:00
Andrey bd7b6e6736 tear down Engine god object #4511
just trying different things
2022-09-03 11:05:27 -04:00
Andrey d329f8ae10 tear down Engine god object #4511
just trying different things
2022-09-03 07:44:24 -04:00
rusefillc aef1f19af9 typo 2022-09-03 07:26:49 -04:00
Andrey 759a15c763 dead 2022-09-03 06:59:00 -04:00
GitHub gen-configs Action 244ef7630d Auto-generated configs and docs 2022-09-02 18:42:52 +00:00
rusefillc 25f4ebbc01
moving state into specific class (#4520)
* moving state into specific class

* moving state into specific class
2022-09-02 14:38:03 -04:00
rusefillc f6ae78e72c
another huh (#4517)
* another huh

* why does this not compile
2022-09-02 13:10:21 -04:00
rusefillc 8e46e9e61f
I am sure that's not magic (#4516)
* I am sure that's not magic

* forward declaration acts funny
2022-09-01 22:33:45 -04:00
Andrey f84f69a4d4 another dead line 2022-09-01 21:13:03 -04:00
Andrey 93d28555f6 Revert "tear down Engine god object #4511"
This reverts commit 8d6a87ae21.
2022-09-01 20:44:51 -04:00
Andrey 48f960b581 Revert "tear down Engine god object #4511"
This reverts commit dc60837e4c.
2022-09-01 20:44:51 -04:00
Andrey 532f6dd202 what a mess :( 2022-09-01 20:16:57 -04:00
Andrey dc60837e4c tear down Engine god object #4511
just trying different things
2022-09-01 20:16:41 -04:00
Andrey 8d6a87ae21 tear down Engine god object #4511
just trying different things
2022-09-01 20:15:46 -04:00
Andrey e6ae70dee6 tear down Engine god object #4511
just trying different things
2022-09-01 19:24:19 -04:00
GitHub gen-configs Action 059b06292b Auto-generated configs and docs 2022-09-01 23:18:26 +00:00
Andrey db9d4c8201 tear down Engine god object #4511
just trying different things
2022-09-01 19:05:40 -04:00
Andrey fcd0636a01 tear down Engine god object #4511
just trying different things
2022-09-01 19:00:16 -04:00
Matthew Kennedy c4080e7c80
extract updateInjectionAngle (#4512) 2022-09-01 18:48:03 -04:00
Andrey e617722fb1 tear down Engine god object #4511
smallest step maybe forward
2022-09-01 13:55:03 -04:00
Andrey 9d8afea152 a bit of dead code 2022-09-01 11:47:56 -04:00
GitHub gen-configs Action 3d6d710379 Auto-generated configs and docs 2022-09-01 15:03:34 +00:00
Andrey 7e340cceb3 refactoring: reducing outputChannels copy 2022-09-01 10:58:16 -04:00
GitHub gen-configs Action ea1d2b848f Auto-generated configs and docs 2022-09-01 14:39:52 +00:00
Andrey 56f6c10042 refactoring: reducing outputChannels copy 2022-09-01 10:30:07 -04:00
Andrey e240ac84d3 refactoring: reducing outputChannels copy 2022-09-01 01:06:49 -04:00
Andrey 705dda095e dead code 2022-09-01 00:23:33 -04:00
Andrey da66fa055c refactoring: enum name clean-up 2022-09-01 00:23:33 -04:00
Andrey 4cbaddcc60 less code is better 2022-08-31 23:14:20 -04:00
Andrey fef406a5a6 english do you speak it 2022-08-31 22:56:38 -04:00
GitHub gen-configs Action d848d3e1be Auto-generated configs and docs 2022-09-01 02:17:58 +00:00
Matthew Kennedy ca4936d3fe
rename and fix skyactiv cam mode (#4505) 2022-08-31 22:12:45 -04:00
Matthew Kennedy b6bb5f148d
set a default, detect error (#4504) 2022-08-31 20:32:37 -04:00
Matthew Kennedy cbe70f8dec
idle always uses instant rpm (#4499)
* idle always uses instant rpm

* configs

* fully inject rpm
2022-08-29 22:18:06 -04:00
Matthew Kennedy 553b549b95
idle coasting table is RPM, not clt (#4487)
* idle coasting table is RPM, not clt

* default

* autoscale

* changelog
2022-08-29 08:15:04 -04:00
GitHub gen-configs Action 6e5a2f61da Auto-generated configs and docs 2022-08-29 03:13:09 +00:00
rusefillc deba48e13a TT_VVT_MAZDA_MYSTERY 2022-08-28 22:57:44 -04:00
GitHub gen-configs Action 9484b751b9 Auto-generated configs and docs 2022-08-29 02:18:23 +00:00
rusefillc 4b0c8c9ff2 TT_VVT_MAZDA_MYSTERY 2022-08-28 21:54:24 -04:00
rusefillc 0613b2627e more proper fix for part of https://github.com/rusefi/rusefi/pull/4493 2022-08-27 22:28:29 -04:00
rusefillc 172f054d25
separate atomic change (#4494)
Co-authored-by: rusefillc <sdfsdfqsf2334234234>
2022-08-27 22:09:54 -04:00
rusefillc 60cf2cdbcf Default GPPWM note 2022-08-27 15:19:35 -04:00
rusefillc 84ff4e98c0 docs 2022-08-25 23:50:00 -04:00
rusefillc 50a1794851 saving 4 bytes of RAM? 2022-08-25 22:34:16 -04:00
rusefillc 67055c69bf progress or maybe even a fix of logging? 2022-08-25 22:24:35 -04:00
rusefillc 733f9b4659 this code is too dead 2022-08-25 22:09:22 -04:00
Matthew Kennedy 4d66dff87c
dfco delay (#4482)
* dfco delay

* config

* using a function that doesn't exist? who does that

* test new behavior

* clearer test
2022-08-25 21:26:17 -04:00
Andrey cecc5a9d6e https://github.com/rusefi/hellen154hyundai/issues/60
extra logging
2022-08-25 19:58:10 -04:00
GitHub gen-configs Action d048d6522e Auto-generated configs and docs 2022-08-25 22:51:12 +00:00
rusefi ee61bb3c1c https://github.com/rusefi/hellen154hyundai/issues/60 2022-08-25 18:44:23 -04:00
GitHub gen-configs Action cf8d43f412 Auto-generated configs and docs 2022-08-24 22:15:50 +00:00
Matthew Kennedy 73abcb044d
log the state of hasSynchronizedPhase() (#4478)
* s

* log whether we've synced phase

* trigger_state_primary

* need that file

* engine state is not the right spot
2022-08-24 18:11:05 -04:00
GitHub gen-configs Action 37d1073336 Auto-generated configs and docs 2022-08-24 16:16:12 +00:00
rusefi 349e07d554 refactoring 2022-08-24 12:11:11 -04:00
rusefi 35120e07da refactoring 2022-08-24 12:02:39 -04:00
rusefillc 27ce2d569b docs 2022-08-23 22:54:48 -04:00
GitHub gen-configs Action b167dab9cd Auto-generated configs and docs 2022-08-24 02:19:34 +00:00
rusefillc 9fd1b251ec log the state of hasSynchronizedPhase() for future diagnostic help. 2022-08-23 22:14:32 -04:00
GitHub gen-configs Action 237bf1d611 Auto-generated configs and docs 2022-08-22 22:32:47 +00:00
rusefillc fa34b8ab46 // todo: migrate to engineState->desiredRpmLimit to get this variable logged 2022-08-22 18:23:48 -04:00
GitHub gen-configs Action dc86c76c9a Auto-generated configs and docs 2022-08-22 15:19:58 +00:00
rusefillc 299162e413 Pavel Xenon is asking for EGT limping mode #3172 2022-08-22 11:12:34 -04:00
rusefillc 09ec99f192 Idle air add via Lua fix #4465
AddressSanitizer being useful?
2022-08-21 00:58:59 -04:00
rusefillc 6d634e3c6a Idle air add via Lua fix #4465 2022-08-21 00:32:34 -04:00
Matthew Kennedy 423f69a842
allow logging multiple warnings at once (#4414)
* allow logging multiple warnings at once

* comment

* .Code

* Revert ".Code"

This reverts commit 2b986bd50035aeec051d11aafd83fdbc1694351c.

* add a better comparison operator instead of conversion

* dot code

* Revert "dot code"

This reverts commit 35f6ae1007c41e3b30ea129a324f33ab4205036d.

* force gcc-10 maybe?

* Revert "force gcc-10 maybe?"

This reverts commit 4ddf8bcefddd354ccdc1da682c5fff1e68d44273.

* vq

* dot code

* dead

* dot code

* return may be null

* static_vector; maybe cyclic_buffer is broken or wrong tool for the job?

* move static vector

* put cyclic buffer back how it was since we don't use it now
2022-08-17 01:12:25 -04:00
GitHub gen-configs Action 8449099f72 Auto-generated configs and docs 2022-08-17 05:08:02 +00:00
rusefillc db8a965288 unconditional VVT PID logging 2022-08-17 00:47:31 -04:00
rusefillc 5105bc57e3 ISO-TP does not work on real car #4427 2022-08-09 13:12:51 -04:00
Matthew Kennedy 165e5bb869
misc fixes (#4411)
* fix warnings

* break to debugger in case of panic

* move the check

* s
2022-08-02 12:19:50 -04:00
Matthew Kennedy 2096a22319
report injector, ignition faults (#4408)
* report injector, ignition faults

* guard
2022-08-01 15:41:47 -04:00
Matthew Kennedy b6f1779781
implement sensor checker (#4395)
* implement sensor checker

* use default

* s

* fix

* properly report non-timeout errors

* it's not safe to read Value when invalid

* it's not safe to read Value when invalid
2022-07-30 17:08:48 -04:00
rusefillc c81ede01de [SECURITY] Cheap password protection against tune modification fix #4243
helping build
2022-07-30 14:33:11 -04:00
rusefillc 26ae6f7490 [SECURITY] Cheap password protection against tune modification fix #4243 2022-07-30 12:23:53 -04:00
Matthew Kennedy 923d2c2e44
unexpected contains information about why it failed (#4393)
* unexpected can contain information

* info printing

* sensors return appropriate error codes

* remove reliance on undefined behavior

* s
2022-07-28 10:04:28 +03:00
GitHub build-firmware Action 04462839f5 Auto-generated configs and docs 2022-07-27 09:38:56 +00:00
Matthew Kennedy d4b8a036af
Log gppwm output values (#4385)
* remove debug option

* purpose built output channels

* name

* embiggen sd log buffer

* Revert "embiggen sd log buffer"

This reverts commit 37432a56535b24c221ae92e9aaded23de4d4a579.

* embiggen SD log buffer
2022-07-27 12:10:00 +03:00
rusefillc 9b83ee7d6e cherry pick https://github.com/rusefi/rusefi/pull/4365 2022-07-21 15:26:41 -04:00
rusefillc 4987a0b93c Launch control bug? "range" thing is confusing #4348
a typo and configurable behaviour without UI
2022-07-20 18:48:55 -04:00
rusefillc 991ec1c8ef Launch control bug? "range" thing is confusing #4348 2022-07-20 18:39:17 -04:00
rusefillc a03d927638 Launch control bug? "range" thing is confusing #4348
bug or dead code? at least making it a bit more obvious
2022-07-20 18:30:20 -04:00
rusefillc 99ad5045df Launch control bug? "range" thing is confusing #4348
refactoring: reducing confusion
2022-07-20 18:24:36 -04:00
rusefillc 0e2907328b code formatting #4348 2022-07-20 18:16:54 -04:00
Matthew Kennedy a0d8ae3f4f
use libfirmware for a few things (#4351)
* use libfirmware

* unit tests

* crc

* missed one

* bootloader
2022-07-16 02:22:51 -04:00
rusefillc 975329fcc7 Detail on how to set up iDrive or equivalent CAN button control #226
boost lua
2022-07-14 14:04:21 -04:00
rusefillc 39df02fe35 Detail on how to set up iDrive or equivalent CAN button control #226
boost lua
2022-07-14 13:03:08 -04:00
rusefillc cad14d6541 #4308 progress 2022-07-14 12:36:55 -04:00
rusefillc 67ec949eb6 Lua A/C Input #4333 2022-07-08 00:51:53 -04:00
GitHub build-firmware Action e45990462c Auto-generated configs and docs 2022-07-08 04:45:52 +00:00
rusefillc 71b118e858 Lua A/C Input #4333 2022-07-08 00:25:29 -04:00
Matthew Kennedy 5d844b1ebe
Error handling cleanup (#4332)
* dead code in stm32

* rusefi.cpp can have some noreturn

* handle lua panic

* unused error codes

* simplifications of error_handling.cpp

* comment

* put that back

* guard
2022-07-07 23:49:02 -04:00
GitHub build-firmware Action 0de824883f Auto-generated configs and docs 2022-07-08 03:21:52 +00:00
Matthew Kennedy 3c062e02bc
Lua hooks for gear detection (#4328)
* implement

* sim has vss

* write a test

* guard
2022-07-07 23:16:56 -04:00
rusefillc 9e26fe007e debug is set to idle mode, but none of the debug fields show anything #4335
reducing confusion
2022-07-07 23:04:19 -04:00
Matthew Kennedy e9d092f975
big delete ICU (#4270)
* big delete

* icu vestiges

* changelog
2022-07-07 15:27:59 -04:00
Matthew Kennedy 0b10f7dca8
hellen board ID detect improvements (#4307)
* move call

* board detections work correctly

* improve detector

* s

* break instead of return

* tests

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2022-07-02 05:19:02 -04:00
rusefillc 82131e5572 Uniform reset pattern for all Lua adjustments #4308
no progress only preparation
2022-06-30 20:07:27 -04:00
GitHub build-firmware Action 3a3dbc9023 Auto-generated configs and docs 2022-06-30 17:53:57 +00:00
rusefillc 924e25fe96 https://github.com/rusefi/rusefi_documentation/issues/226 2022-06-30 13:38:15 -04:00
rusefillc 483395fa2e
https://github.com/rusefi/rusefi_documentation/issues/226 (#4306)
* https://github.com/rusefi/rusefi_documentation/issues/226

* https://github.com/rusefi/rusefi_documentation/issues/226

* https://github.com/rusefi/rusefi_documentation/issues/226

* https://github.com/rusefi/rusefi_documentation/issues/226

* https://github.com/rusefi/rusefi_documentation/issues/226

Co-authored-by: rusefillc <sdfsdfqsf2334234234>
2022-06-29 23:34:00 -04:00
Matthew Kennedy 3284282be7
rescale RPM values (#4300)
* rpm configs

* fix

* s

* s

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2022-06-29 18:48:30 -04:00
GitHub build-firmware Action b33f32d20c Auto-generated configs and docs 2022-06-29 22:16:13 +00:00
Matthew Kennedy 29e5a0babb
use detected hellen board type on h72 (#4305)
* use detected hellen board type

* s

* s

* name
2022-06-29 18:10:29 -04:00
Andrey 5cf0265968 logging of live data structs was: data points #3614 2022-06-29 03:27:51 -04:00
rusefillc c0960270a8 logging of live data structs was: data points #3614 2022-06-29 03:03:02 -04:00
rusefillc aab466094c logging of live data structs was: data points #3614 2022-06-29 03:01:13 -04:00
rusefillc f7ecebaa64 logging of live data structs was: data points #3614 2022-06-29 02:37:24 -04:00
GitHub build-firmware Action a8c3769906 Auto-generated configs and docs 2022-06-29 06:21:31 +00:00
rusefillc aec1900278 logging of live data structs was: data points #3614 2022-06-29 02:16:15 -04:00
rusefillc a6e7d35461 logging of live data structs was: data points #3614 2022-06-29 02:09:37 -04:00
GitHub build-firmware Action 171bc28d38 Auto-generated configs and docs 2022-06-29 06:06:27 +00:00
rusefillc 241f2765e9 logging of live data structs was: data points #3614 2022-06-29 01:49:59 -04:00
rusefillc ef6bef1b82 logging of live data structs was: data points #3614 2022-06-29 01:38:43 -04:00
rusefillc bdb9eaa2f5 logging of live data structs was: data points #3614 2022-06-29 01:27:42 -04:00
GitHub build-firmware Action 9798e6e22a Auto-generated configs and docs 2022-06-29 05:23:15 +00:00
rusefillc e26a4085a0 https://github.com/rusefi/hellen-NB2-issues/issues/36 2022-06-29 01:15:11 -04:00
GitHub build-firmware Action df70173ad1 Auto-generated configs and docs 2022-06-27 00:12:14 +00:00
rusefillc eabffc9ef8 stealing from David 2022-06-26 19:40:54 -04:00
Matthew Kennedy c0f290b922
Injector scheduled by angle, not tooth index (#4208)
* trigger decoder returns a result

* TriggerFormDetails

* s

* don't reach out and touch the engine

* injection doesn't care about teeth

* fix up existing tests

* oh look, we can actually test this logic now without trying to depend on trigger shape!!!

* fix a real bug

* simplify
2022-06-24 17:43:23 -04:00
GitHub build-firmware Action 55b9e384cf Auto-generated configs and docs 2022-06-24 00:20:41 +00:00
Matthew Kennedy 29420c76aa
wideband live data (#4276)
* wideband live data magic

* test build happy

* test even happier
2022-06-23 20:04:26 -04:00
Matthew Kennedy b92c0149d6
get rid of setSerialConfigurationOverrides (#4274)
* get rid of setSerialConfigurationOverrides

* missed a few

* kinetis
2022-06-23 19:42:09 -04:00
Matthew Kennedy 9d62aeb81f
force o2 heating (#4275) 2022-06-23 14:32:34 -04:00
rusefi 983682d11f miata 96 defaults 2022-06-23 14:30:41 -04:00
Matthew Kennedy 4d7fe35c5c
clean up sd overrides (#4272) 2022-06-23 09:15:51 -04:00
GitHub build-firmware Action eab2328dea Auto-generated configs and docs 2022-06-20 15:49:50 +00:00
rusefillc a4347668c5 https://rusefi.com/forum/viewtopic.php?f=5&t=2353 2022-06-20 11:41:33 -04:00
GitHub build-firmware Action 7d8bf4be8b Auto-generated configs and docs 2022-06-20 11:50:51 +00:00
rusefillc d639a42621 https://rusefi.com/forum/viewtopic.php?f=5&t=2353 2022-06-20 07:43:23 -04:00
Matthew Kennedy 7e8ae7c8a3
Write output channels with new parser (#4219)
* let the new parser run

* s

* support for output channels

* usages reader uses new parser for output channels

* better debugging configuration

* bad merge

* test it a bit too

* more tests

* copy/paste the same content from other file

* s

* fix bugs where even the existing logic tries to write as an enum (?)

* jar

* print stream always unix

* print stream always unix

* use typedefs correctly

* jar

* stub support for multiple of each type

* s

* s

* name some more datas
2022-06-19 09:52:23 -04:00
rusefi a552d58d42 verbose trigger sync should reuse engineSnifferRpmThreshold #4259
reducing complexity
2022-06-18 14:17:36 -04:00
Matthew Kennedy 172479e2af
fix (#4254) 2022-06-17 21:20:47 -04:00
Matthew Kennedy 932f5e1f30
cam/crank sync improvements (#4152)
* clarify getOperationMode

* wait for phase synchronize to transition to sequential mode

* one test

* encapsulate vvtSyncCounter

* test

* Add option to stop VVT sync above some RPM

* getOrZero

* Revert "synchronized Phase handling improvements fix #4099"

This reverts commit 32d46d1f09.

* Revert "m_hasSynchronizedSymmetrical handling improvements #4099"

This reverts commit d5e131b1d0.

* remove synchronizedPhase

* only crank needs this

* changelog

* needsDisambiguation()

* test

* s

* bad merge

* put the timer back

* s

* s

* changelog

* test for new behavior

* correct parameter order

* spelling

* s

* s

* s

* tests merge happy

* bad merge

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2022-06-09 17:21:22 -04:00
GitHub build-firmware Action 0c17b9c781 Auto-generated configs and docs 2022-06-02 01:31:50 +00:00