Commit Graph

2373 Commits

Author SHA1 Message Date
Matthew Kennedy 7a90692187
Idle timing uses phase logic, remove falloff (#2169)
* use phase computation

* move & simplify implementation

* test

* bad merge

* initialize

* wonderful changelog

* now unused parameter

* put back deadzone

* ui

* test deadzone

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-01-07 08:06:36 -05:00
Andrey G f96ae7525f
Gpio cleanup #2 (#1530)
* pin repository: PIN_USED size in now equal to brain_pin_e enum size

expect special values...

* smart gpios: register gpio chip to given base (no auto-allocation)

* drivers: gpio: core: add gpiochip_unregister()

* drivers: gpio: MC33810 intergation

* smart_gpio.cpp: cleanup ifdef mess, minor cleanups

* gpio: core: additional check for gpio ranges overlaps

* unit test: gpio chip: fixed and extended
2021-01-06 18:29:47 -05:00
Matthew Kennedy eabb5c7366
flex fuel AFR interpolation (#2190)
* config

* implement flex

* secondary fuel default

* test

* test works

* rename

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-01-05 16:27:23 -05:00
Andrey G b92e3086d0
Adc isAdcChannelValid helper (#2188)
* Guard define argument

* ADC: isAdcChannelValid

Check for both <= EFI_ADC_NONE and >= EFI_ADC_LAST_CHANNEL
Also check for value out of enum range (corrupted settings)

* Fix unit tests
2021-01-05 16:02:20 -05:00
rusefillc 15665484e5 Audi OEM 5-cyl trigger pattern aka "Tri-Tach" https://rusefi.com/forum/viewtopic.php?f=5&t=1912 2021-01-03 13:52:53 -05:00
Matthew Kennedy 92ea09b0a6
switch more map to read from sensor model (#2162)
* hook up map

* check for init

* switch some consumers

* that's the rest of them

* test

* tests

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-01-02 19:13:10 -05:00
rusefillc d213c01ca5 questionable progress 2021-01-02 16:51:14 -05:00
GitHub build-firmware Action 8a0fa161ac Auto-generated configs and docs 2021-01-01 06:12:01 +00:00
rusefillc 9587b7bb54 hellen 2021-01-01 01:10:28 -05:00
GitHub build-firmware Action 10c0553038 Auto-generated configs and docs 2020-12-31 17:41:53 +00:00
rusefillc 46583b2a19 Revert "Idle timing PID uses phase logic (#2156)"
This reverts commit 9634a803
2020-12-31 12:22:54 -05:00
shadowm60 d49fc7fc71
Haltech as dash option (#2165)
* Haltech as dash option

* Update build-firmware.yaml

added generate enums for build-primary-bundle
2020-12-31 12:22:01 -05:00
Matthew Kennedy acdf6fdc85
Put map in the sensor model (#2161)
* hook up map

* check for init

* switch some consumers

* don't do limp for now

* oops

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-12-30 08:43:49 -05:00
Matthew Kennedy 9634a803f1
Idle timing PID uses phase logic (#2156)
* use phase computation

* move & simplify implementation

* test

* bad merge

* initialize

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-12-29 23:50:56 -05:00
rusefillc f28f1e0f90 fine-grained check modes 2020-12-27 17:41:28 -05:00
Matthew Kennedy 898b7a82e0
move swtiches out of idle (#2148) 2020-12-26 21:31:41 -05:00
Matthew Kennedy ff4ce2fb1f
create limp manager (#2142)
* move rev limit to limp manager

* call fatal error

* include order

* fix bug

* tests

* comment

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-12-26 17:30:46 -05:00
rusefillc 1ebce57721 proteusBoardTest 2020-12-26 10:41:33 -05:00
Matthew Kennedy 3d13d03424
Purge e34 config (#2127)
* remove

* enums

* s

* func test

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-12-24 07:31:25 -05:00
Matthew Kennedy 55ebe223a7
Partition configs by board type (#2106)
* remove old flag

* flags

* reorder switch

* oops
2020-12-22 21:54:40 -05:00
Matthew Kennedy ba9de3a604
Purge fiesta config (#2117)
* config

* this had a feature flag?

* enums

* goodbye, fiesta
2020-12-22 17:22:05 -05:00
rusefillc 2d2225bfdb PROTEUS_QC_TEST_BOARD 2020-12-22 10:13:27 -05:00
Matthew Kennedy 8737ba62c2
Purge rover v8 config (#2116)
* bye

* goodbye, rover v8

* that snuck in

* use a different config for that test
2020-12-22 10:05:54 -05:00
Matthew Kennedy f29ca22b99
fix (#2109) 2020-12-20 19:31:14 -05:00
Matthew Kennedy 6168bcea80
Fix gpio reinit race condition (#2098)
* fix unregister api for gpio

* consumers

* guard with a critical section

* index

* guard less

* unregister under lock

* fix reinit

* dead flag

* fix most tests

* initialize properly

* initialize properly

* assertions in tests

* fix message

* we must lock earlier to be truly safe

* this was using huge memory

* devirtualize
2020-12-18 17:18:12 -05:00
rusefillc 50e9dd6da7 generate java enum from C enum #2102
one step back
2020-12-18 14:21:08 -05:00
rusefillc 71ba1c529c generate java enum from C enum #2102 2020-12-18 13:33:01 -05:00
rusefillc 55b4e82615 naming consistency 2020-12-18 09:01:18 -05:00
Matthew Kennedy aeea50ada2
move target computation (#2091) 2020-12-17 17:46:51 -05:00
Matthew Kennedy 1838beadfa
only build in config for the correct board (#2088)
* only build in config for the correct board

* undo

* undo

* undo

* only touch proteus config

* include configs in tests
2020-12-17 17:12:24 -05:00
rusefillc 26fbf0527a trigger and start button pins not displayed by "pins" command fix #2084 2020-12-16 22:53:26 -05:00
rusefillc a47129693a trigger and start button pins not displayed by "pins" command #2084
progress but not complete fix yet
2020-12-16 22:00:42 -05:00
Matthew Kennedy 6151f8c334
extra data for rusEfi wideband controller (#2082)
* add config

* logic

* remove old

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-12-16 18:25:11 -05:00
rusefillc 0899102b05 returning AT validation into QC 2020-12-15 15:43:36 -05:00
rusefillc bd279edd8e pnp progress 2020-12-15 00:09:35 -05:00
shadowm60 9d36bab793
Debug channel updates (#2078)
* Debug channel updates

Renamed DBG_44 to Dyno_View
added DBG_LOGIC_ANALYZER
DBG_46..48 are  buffers for new features
corrected ini error: [mainController.ini]:[Line:2593]:    entry = wastegatePosition, "Wastegate position sensor",       float,  "%.3f"

* enum_regeneration

fix build issue?
2020-12-14 08:29:43 -05:00
rusefillc 951676e111 Merge remote-tracking branch 'origin/master' into master 2020-12-13 17:49:36 -05:00
rusefillc 49ee4ad78e trigger decode should pay to attention to what wheel signal is coming from #2073 2020-12-13 17:49:24 -05:00
GitHub build-firmware Action 4ef5bf3d34 Auto-generated configs and docs 2020-12-13 22:48:42 +00:00
rusefillc 314e9ef580 TT_SUBARU_7_WITHOUT_6 2020-12-13 17:46:48 -05:00
GitHub build-firmware Action 48e26ec0a3 Auto-generated configs and docs 2020-12-13 21:23:35 +00:00
rusefi 38bcd63e13 maybe this would just work? 2020-12-13 16:22:02 -05:00
rusefi 7f65e95a65 subi 2020-12-13 11:39:10 -05:00
rusefillc f2bb2ce0c6 MRE issue with tle8888 - GP3 does not work? #2065 2020-12-13 11:29:19 -05:00
rusefillc b41ca74386 clang warnings again #2055 2020-12-11 12:50:10 -05:00
rusefillc 9b4a1fff7b clang warnings again #2055 2020-12-11 10:33:00 -05:00
Matthew Kennedy f2426677db
start fuel pump as soon as trigger events happen (#2038)
* switch pump fsio logic

* value collision

* fuel pump in tests

* mock time since trigger

* test fp

* init pin in test

* fix gpio outputs in tests

* comment

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-12-10 01:23:24 -05:00
rusefillc ea8e09ba13 fix warnings found by clang #2014 2020-12-08 13:59:40 -05:00
Matthew Kennedy 67269aa637
maybe fix sensor init checks (#2034)
* enums

* don't collide

* auto_generated_enums

* check based on new enum val

* maybe this will make generate tool happy

* add a test

* fix test

* fix and add another test

* make clang happier

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-12-06 23:19:57 -05:00
rusefillc debec1107e subi 2020-12-06 18:08:55 -05:00
rusefillc 9f13d39003 MRE_SUBARU_EJ18 2020-12-06 14:16:40 -05:00
rusefillc 166f4fc381 MRE_SUBARU_EJ18 2020-12-06 13:08:09 -05:00
rusefillc 75ffe1f38e making console happier 2020-12-05 21:56:39 -05:00
rusefillc e5ef8de2ae unit tests in clang #2012 2020-12-04 23:59:21 -05:00
shadowm60 864bd7fa73
Dyno view proposal (#1999)
* DynoView creation

module implementation and unit_tests

* update acc algo

we only calcualte new acceleration value if speed has changed, not on every callback.

* added acceleration ts_channel

* fixed broken unit tests

* fixed accel sign

* review updates

* Update test_dynoview.cpp

fix unit_tests

* Update engine_controller.cpp

Fix .ram4 unused size

* Update test_dynoview.cpp
2020-12-04 20:28:48 -05:00
rusefillc db5e30edf5 all triggers should be documented way nicer #2001 2020-12-04 11:44:27 -05:00
rusefillc 0a23e82baf 6.1 Hemi V8 decoder #2010 2020-12-04 00:30:22 -05:00
rusefillc 4c3eae5676 FORD ST170 CAM TRIGGER PATTERN fix #2009 2020-12-03 23:54:08 -05:00
GitHub build-firmware Action 0b2e8755ee Auto-generated configs and docs 2020-12-04 02:59:40 +00:00
rusefillc c413f03359 DAIHATSU 3CYLINDER TRIGGER WHEEL SUPPORT #2008 2020-12-03 21:58:03 -05:00
GitHub build-firmware Action 77914fb702 Auto-generated configs and docs 2020-12-04 02:33:46 +00:00
rusefillc c55120372b DAIHATSU 3CYLINDER TRIGGER WHEEL SUPPORT #2008 2020-12-03 21:31:58 -05:00
rusefillc 662eaea384 avoid float -> int64 conversion #1977
both cases have to be relatively small durations of time cherry picking...
2020-12-03 13:32:01 -05:00
GitHub build-firmware Action 82c30dadf8 Auto-generated configs and docs 2020-12-03 15:51:02 +00:00
rusefillc 745038c4a7 more dead code 2020-12-03 10:49:20 -05:00
GitHub build-firmware Action b2e26a2e2b Auto-generated configs and docs 2020-12-03 06:38:53 +00:00
rusefillc dd9e431782 dead code matches Mazda SOHC 2020-12-03 01:36:43 -05:00
GitHub build-firmware Action b5b9554903 Auto-generated configs and docs 2020-12-03 06:25:01 +00:00
rusefillc a2036ebc70 dead trigger, this would now be vvt+60/2 2020-12-03 01:22:57 -05:00
rusefillc 7855847a3f all triggers should be documented way nicer #2001 2020-12-03 01:02:17 -05:00
rusefillc 479fcf0174 all triggers should be documented way nicer #2001 2020-12-03 00:19:18 -05:00
rusefillc c36f76b68e Fuel pump should turn on at the first sign of engine rotation #1961 2020-12-02 23:09:39 -05:00
rusefillc b662b977fa all triggers should be documented way nicer #2001 2020-12-02 20:51:33 -05:00
shadowm60 6fb745d29c
Launch Control refactoring (#1992)
* refactor

- called from periodicFastCallback
- removed defines

* Update rusefi.input

removed unused configurations.
added clutch inversion option

* Added new tests

fixed limiting only in case we have launch condition and rpm outside of window

* Update launch_control.cpp

Unintialized config update, now it is working fine with VSS and with clutch as well.

* small fixes

updated after review findings

* Fix breaking engine rev limiter

applyLaunchControlLimiting should not overwrite booleans to false!

* Delay timer in seconds

timer uses ms, so convert seconds to ms
2020-12-01 13:03:42 -05:00
Matthew Kennedy d48367d565
timer (#1994) 2020-11-30 19:35:06 -05:00
GitHub build-firmware Action 8e1674956d Auto-generated configs and docs 2020-11-29 03:51:15 +00:00
rusefillc b982d02298 miata 94 2020-11-28 22:49:28 -05:00
rusefi 89eaae8234 LM_ALPHA_N_2 rename 2020-11-27 15:44:31 -05:00
rusefillc 0840b91f7f dead engine config
one step back
2020-11-26 21:21:25 -05:00
rusefillc 334f0a5a8a dead engine config 2020-11-26 21:07:34 -05:00
rusefillc 55b763f62e dead engine config 2020-11-26 20:26:12 -05:00
rusefillc 641959b9a3 Starter is engaged on start-up in pull-up configuration #1969 2020-11-26 17:48:09 -05:00
rusefi 0d441be869 better default value 2020-11-25 17:02:28 -05:00
Andrey G a285ba6743
ADC: fixes: (#1979)
* ADC: fixes:

-use enums
-internalAdcIndexByHardwareIndex array should be adc_channel_e size
-add sanity checks
-save few bytes of RAM

* ADC: use logical OR instead of math add
2020-11-22 12:23:27 -05:00
shadowm60 7c793834ef
Launch control unit tests update (#1972)
* testable launch start

* extract base class

* add a test

* fix ts debug

* Launch control unit_tests

updated launch control for a better split
VSS mock for unit tests

Co-authored-by: Matthew Kennedy <matthewkennedy@outlook.com>
2020-11-19 21:14:38 -05:00
Matthew Kennedy ee51da64ad
Launch control testable (#1967)
* testable launch start

* extract base class

* add a test

* fix ts debug
2020-11-19 08:15:56 -05:00
Matthew Kennedy f3b7a1d9da
Remove lockAnyContext, replace with CriticalSectionLocker (#1938)
* switch to CriticalSectionLocker

* that's just about all

* clean up last usage

* include hpp for sim

* need the cpp wrappers in the makefile too

* include dir

* include
2020-11-19 06:56:02 -05:00
rusefillc 47fbb92bff Starter seems to be engaged forever fix #1965 2020-11-18 23:54:30 -05:00
rusefillc c70c546d46 better error handling 2020-11-17 22:45:43 -05:00
rusefillc 07e25ccf3c https://rusefi.com/forum/viewtopic.php?p=38367#p38367
idle position/waste gate position sensor usability
2020-11-14 18:05:27 -05:00
Matthew Kennedy 0e3673e78c
remove idle thread; just call from periodicSlowCallback (#1924)
* remove thread

* remove ui
2020-11-11 21:47:19 -05:00
GitHub build-firmware Action d6687a68e9 Auto-generated configs and docs 2020-11-11 04:13:06 +00:00
Matthew Kennedy 02c4d630f6
compensate injector flow based on fuel pressure (#1931)
* injector compensation

* fix

* ui

* testability & comments

* hella testing

* debug channels

* enum value

* auto generated enums

* update comment

* oops too much

* update config fields

* handle failed pressure sensor

* build

* fix

* add some todos for the future

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-11-10 23:11:22 -05:00
rusefi 59a000e7d5 miata TCU 2020-11-04 12:48:07 -05:00
Matthew Kennedy 3241a43a2d
extract idle hardware to its own file (#1923)
* extract idle hardware

* should fix the build
2020-11-03 18:06:32 -05:00
Matthew Kennedy cf3dc9c2c3
convert cranking defaults to mg (#1921)
* convert cranking defaults to mg

* fix tests
2020-11-03 14:12:26 -05:00
Andrey G 63c25ab8a7
Tle8888 small update (#1908)
* TLE8888: add support MR switching from SW

Main Relay has limitation - it is always active while KEY=1. When
KEY=0 MR can be switched on from SW.

* TLE8888: support reading of KEY and WAKE inputs

* Rusefi enums: add new TLE8888 pins
2020-11-01 22:19:55 -05:00
rusefi 2b7e33404f wall wetting default 2020-10-31 19:28:27 -04:00
Matthew Kennedy 15d5c872c2
log afr in addition to lambda (#1920)
* log afr

* log it

* weird double commas
2020-10-31 17:52:07 -04:00
Matthew Kennedy 3e30865e6c
unused tach field (#1918) 2020-10-29 15:26:01 -04:00