rusEFI LLC
aed124bae2
Usability: critical error in case of unneeded second channel #6419
...
only: unit tests
2024-04-26 22:18:01 -04:00
Matthew Kennedy
9fdb962ec6
more tests that are less chaos now
2024-04-12 16:55:49 -04:00
rusefillc
a05c0ef730
engine type clean-up
2024-03-06 00:13:11 -05:00
Andrey
247a0a91b5
spelling is important
2023-09-09 19:54:57 -04:00
rusefillc
d77fb3bf24
"Single Tooth" renamed to "Half Moon", more proper "Single Tooth" crank trigger as a new trigger fix #5488
2023-08-06 00:46:33 -04:00
rusefillc
77ef4db8ab
Simplified VVT single tooth cam modes. ( #5483 )
...
* Simplified VVT single tooth cam modes.
* Simplified VVT single tooth cam modes.
* Simplified VVT single tooth cam modes.
* Simplified VVT single tooth cam modes.
* Simplified VVT single tooth cam modes.
---------
Co-authored-by: rusefillc <sdfsdfqsf2334234234>
2023-08-03 20:24:22 -04:00
rusefi
633274055b
Technical debt: ENUM_32_BITS #3874
...
poking the bear
2023-06-01 10:29:05 -04:00
rusefi
415b3d55df
Technical debt: ENUM_32_BITS #3874
...
poking the bear
2023-06-01 01:45:53 -04:00
Matthew Kennedy
9ae8e18757
only: cherry picking: it's going to be painful
2023-04-29 15:14:58 -04:00
Andrey
e748e65638
only: cherry picking: it's going to be painful
2023-04-29 15:07:43 -04:00
Matthew Kennedy
61e5b4b1ad
change ObdCode to enum class builds firmware
2023-04-29 00:44:00 -04:00
Matthew Kennedy
5c50ad2db4
infer useOnlyRisingEdge by trigger type ( #4621 )
...
* most of the plumbing
* easy tests
* trigger types that are rise only
* configs
* change mode of various triggers
* vvt
* 898 test is now impossible 🥳
* s
* instant rpm test
* actually remove useOnlyRisingEdgeForTrigger
* remove vvtCamSensorUseRise
* s
* print
* one happy test
* another test
* happy testSomethingWeird
* happy testCamInput
* maybe fix it a different way
* better
* quad cam
* nb2 happy
* bad merge
* vvt test
* trigger.test1995FordInline6TriggerDecoder
* hellen gm e67
* changelog
2022-11-08 21:48:39 -05:00
Matthew Kennedy
7bd9dbf89e
fix vvt logging logic ( #4747 )
...
* fix vvt logging logic
* put that back
* flip condition to avoid branch on uninitialized value
2022-11-07 10:52:17 -05:00
rusefillc
851e8e48d3
refactoring: type safety
2022-09-11 02:57:35 -04:00
Andrey
8e49542600
trigger: in corner cases like NB2 and VQ35 those are not revolutions
2022-09-07 22:24:28 -04:00
Matthew Kennedy
9407150544
more granular trigger error messages ( #4526 )
...
* granular trigger error messages
* adjust test expectations
* explicitly test behavior
2022-09-04 09:15:24 -04:00
Matthew Kennedy
423f69a842
allow logging multiple warnings at once ( #4414 )
...
* allow logging multiple warnings at once
* comment
* .Code
* Revert ".Code"
This reverts commit 2b986bd50035aeec051d11aafd83fdbc1694351c.
* add a better comparison operator instead of conversion
* dot code
* Revert "dot code"
This reverts commit 35f6ae1007c41e3b30ea129a324f33ab4205036d.
* force gcc-10 maybe?
* Revert "force gcc-10 maybe?"
This reverts commit 4ddf8bcefddd354ccdc1da682c5fff1e68d44273.
* vq
* dot code
* dead
* dot code
* return may be null
* static_vector; maybe cyclic_buffer is broken or wrong tool for the job?
* move static vector
* put cyclic buffer back how it was since we don't use it now
2022-08-17 01:12:25 -04:00
Matthew Kennedy
76f5832db9
resolve VVT phase using every tooth, not just sync point ( #4434 )
...
* resolve VVT phase using every tooth, not just sync point
* fix tests
* comment
* changelog
2022-08-12 08:08:23 -04:00
Matthew Kennedy
70c2689f1e
remove trigger duty cycle calculation ( #4213 )
...
* This field was ignored.
* move pad out
* gone
* make trigger configuration a little clearer
* even simpler!
* format
* test fix
* remove duty cycle thing
2022-05-30 22:39:57 -04:00
Matthew Kennedy
ae91b2aea8
don't rely on triggerStateListener to detect trigger errors ( #4164 )
...
* Write proper TriggerDecoder tests
* Improve logic around sync loss
* these tests I understand
* these I sort of understand....
* the one error in the noiseless decoder is gone!
2022-05-13 18:48:26 -04:00
Matthew Kennedy
e4a0979dc2
Brain pin is enum class ( #4108 )
...
* change most usages to Gpio::
* board configs
* engine configs etc
* isBrainPinValid, smart gpio
* generator
* generator
* generator
* connector yamls
* kinetis enums
* cypress txt
* kinetis config
* frankenso
* config generator
* actually do it for the others
* disable skips for pr ci
* fix tle8888
* misc
* weird cast from int
* needs this operator too
* this can be an unsigned subtract
* happy tests
* s
* kinetis isConfigurationChanged weirdness
* missed J/K
* cypress efifeatures
* build script mistake (!)
* mistake in smart gpio
* debounce
* eg33
* kinetis, so needy
* it's pretty green, we can skip these again
2022-04-28 17:32:39 -04:00
Andrey
cc9a1136c4
Trigger setup in TS is highly confusing: hide operation mode from users? #4031
2022-04-03 02:21:37 -04:00
Andrey
b0be8c4b66
Trigger setup in TS is highly confusing: hide operation mode from users? #4031
...
progress: this way test is less fake!
2022-04-03 02:13:56 -04:00
Andrey
95d36b37e3
Trigger setup in TS is highly confusing: hide operation mode from users? #4031
2022-04-03 00:34:18 -04:00
Andrey
33df88d3f7
fixing NOISY_RPM handling via Sensor framework
2022-01-21 00:21:45 -05:00
Andrey
9313bcca92
migrating to SensorType::Rpm API
2022-01-20 23:19:48 -05:00
Andrey
19a8685644
refactoring
2021-12-24 16:51:31 -05:00
Matthew Kennedy
9a28e8d938
correctly compute engine revolution number ( #3586 )
...
* add param
* first revolution is revolution 0, not revolution 1
* would you look at that, we sync one rev quicker!
* changelog
* rpm value
2021-11-21 09:01:27 +03:00
Scott Smith
cc95bd6c8e
Programmatically remove EnginePtr/inject, EXPAND_Engine, and WITH_ENGINE_TEST_HELPER* ( #3560 )
...
* Programmatically remove EnginePtr/inject, EXPAND_Engine, and WITH_ENGINE_TEST_HELPER*
for i in ": public EnginePtr " ", public EnginePtr" "EXPAND_Engine;" "EXPAND_Engine"; do
git grep -l "$i" | xargs sed -i "s/$i//g"
done
git grep -l "inject" | xargs sed -i "/inject[(][)]/d"
for i in WITH_ENGINE_TEST_HELPER_SENS WITH_ENGINE_TEST_HELPER_BOARD_CALLBACK WITH_ENGINE_TEST_HELPER; do
git grep -l "$i" | xargs sed -i "s/$i/EngineTestHelper eth/g"
done
git checkout firmware/controllers/core/engine_ptr.h
git checkout unit_tests/global.h
* Review fixups.
2021-11-16 16:52:11 -05:00
Matthew Kennedy
8cdac4cac0
remove engine pointer passing ( #3556 )
...
* some
* more
* more
* the last?!
2021-11-16 04:15:29 -05:00
rusefillc
b7601e063f
generate java enum from C enum? generate both C and java from yaml? #2102
2021-10-24 11:40:47 -04:00
Matthew Kennedy
25414ebdad
yet more pch ( #3068 )
...
* big pch energy
* put back ramdisk stub
* tests are happy
* h743 nucleo
* kinetis
* I love deleting code!
* make stepper happy
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-08-03 22:05:01 -04:00
Matthew Kennedy
0d983855b9
instant rpm uses full engine cycle ( #3077 )
...
* instant rpm uses full engine cycle
* turn off fast spinup for this test
2021-07-30 08:18:24 -04:00
Andrey
6fc693aea2
VVT position of first cam is off on first cycle fix #2987
2021-07-22 01:02:37 -04:00
Matthew Kennedy
d520d12490
adjust nb2 vvt sync ( #3019 )
...
* test existing implementation
* nb2 vvt pattern sync
* update test
2021-07-21 20:07:28 -04:00
Matthew Kennedy
aef0732509
fix vvt indication ( #2926 )
...
* wrap logic
* rename gauges
* names and ranges
* binary log
* we actually don't need that warning
* values auto wrap
* values auto wrap
* bye warnings
* comparison
2021-07-12 16:29:07 -04:00
Andrey
0cf095a943
Nissan VVT trigger decoder #2887
2021-07-03 12:02:00 -04:00
rusefillc
462e24354d
CUSTOM_ERR_VVT_OUT_OF_RANGE warning false-positive fix #2534
2021-04-08 15:01:12 -04:00
rusefillc
e02f09495b
trigger and VVT duty cycle integration into limp manager #2523
2021-04-07 01:21:28 -04:00
rusefillc
9753b6e020
'displayLogicLevelsInEngineSniffer' on VVT input reports too much into engine sniffer fix #2528
2021-04-04 23:12:07 -04:00
rusefillc
f877d32be4
engine sniffer into unit tests
2021-04-04 22:48:48 -04:00
Matthew Kennedy
1c473934b9
plumbing for multiple vvt ( #2488 )
...
* plumb multiple vvt
* fix test
* s
* fix barra while we're at it
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-03-25 07:39:23 -04:00
rusefillc
2d99e77c95
M62T vanos support #2243
2021-02-08 21:50:31 -05:00
rusefi
f68ede76bf
M62T vanos support #2243
2021-02-08 21:07:43 -05:00
rusefi
a349bf1ca8
M62T vanos support #2243
2021-02-08 16:16:26 -05:00
rusefillc
869e4cfc49
vvt/cam events to pass index
2021-01-31 22:24:45 -05:00
rusefi
adf899e338
Allow negative VVT position feedback #1713
2020-08-23 11:49:46 -04:00
rusefi
afc763f068
better VVT progress
2020-05-15 21:33:25 -04:00
rusefi
da4c7e1a2a
VVT_INACTIVE
2020-05-14 23:31:01 -04:00
rusefi
3f7ca92241
removing some unneeded flexibility
2020-05-10 02:06:15 -04:00