851e8e48d3
refactoring: type safety
2022-09-11 02:57:35 -04:00
6e71b72acc
refactoring - reducing API between FW and Java
2022-09-11 02:16:47 -04:00
9e9c0217b8
huh? dead code? how can we get NAN from eventAngles table? ( #4549 )
2022-09-07 23:45:33 -04:00
8e49542600
trigger: in corner cases like NB2 and VQ35 those are not revolutions
2022-09-07 22:24:28 -04:00
00fea2cbe5
trigger: in corner cases like NB2 and VQ35 those are not revolutions
2022-09-07 21:45:59 -04:00
ab4b451195
os_access.h dead?
2022-09-07 15:56:45 -04:00
aeeef3dbd0
reset instant RPM in case of cam resync ( #4544 )
2022-09-06 21:38:35 -04:00
9407150544
more granular trigger error messages ( #4526 )
...
* granular trigger error messages
* adjust test expectations
* explicitly test behavior
2022-09-04 09:15:24 -04:00
85490a497d
separate atomic picked from https://github.com/rusefi/rusefi/pull/4493 ( #4495 )
...
Co-authored-by: rusefillc <sdfsdfqsf2334234234>
2022-08-27 22:26:56 -04:00
859a66bb3b
poke 3
2022-08-23 09:02:38 -04:00
7e690b0899
poke 2
2022-08-22 23:43:06 -04:00
c0923f6efe
poke 1
2022-08-22 23:42:48 -04:00
841b40d8ac
RE: reasons for verbose messages
2022-08-22 22:52:48 -04:00
25778f0890
trigger gap logging: it's a mess :(
2022-08-21 12:38:29 -04:00
f61cfcfd95
todo: huh? dead code? how can we get NAN from eventAngles table?
2022-08-11 20:05:29 -04:00
b5c2b70e23
refactoring: better field name
2022-08-09 20:32:39 -04:00
fcd3d991ee
trigger tweaks cleanup ( #4278 )
...
* simplify some math
* we say yes to the todo
* and put back that test
* test
2022-06-23 23:11:29 -04:00
271dddf61e
verbose trigger sync should reuse engineSnifferRpmThreshold fix #4259
2022-06-18 15:18:45 -04:00
9a9047c3f9
more info verbose trigger/vvt
2022-06-17 22:11:09 -04:00
932f5e1f30
cam/crank sync improvements ( #4152 )
...
* clarify getOperationMode
* wait for phase synchronize to transition to sequential mode
* one test
* encapsulate vvtSyncCounter
* test
* Add option to stop VVT sync above some RPM
* getOrZero
* Revert "synchronized Phase handling improvements fix #4099"
This reverts commit 32d46d1f09d5e131b1d0
2022-06-09 17:21:22 -04:00
4ada633206
Remove third trigger channel ( #4226 )
...
* remove third trigger
* clean up the honda mess
* there was nothing novel about this engine config
* include
* missed a few
* s
* x
* changelog
* don't set the third trigger input
* don't redefine the same thing 3 times
* only two inputs!
* test
2022-06-01 21:24:20 -04:00
c0d8cbfef4
Trigger cleanup init ( #4222 )
...
* extra parameter
* name decoders in constructor
* s
2022-06-01 00:55:34 -04:00
70c2689f1e
remove trigger duty cycle calculation ( #4213 )
...
* This field was ignored.
* move pad out
* gone
* make trigger configuration a little clearer
* even simpler!
* format
* test fix
* remove duty cycle thing
2022-05-30 22:39:57 -04:00
f945e6efc9
trigger configuration refactoring for clarity ( #4212 )
...
* This field was ignored.
* move pad out
* gone
* make trigger configuration a little clearer
* even simpler!
* format
* test fix
2022-05-30 19:36:47 -04:00
66fffee321
More trigger encapsulation ( #4207 )
...
* trigger decoder returns a result
* TriggerFormDetails
* s
* don't reach out and touch the engine
2022-05-29 13:49:00 -04:00
720c463ffb
trigger decoder returns a result ( #4206 )
2022-05-28 09:01:45 -04:00
ae91b2aea8
don't rely on triggerStateListener to detect trigger errors ( #4164 )
...
* Write proper TriggerDecoder tests
* Improve logic around sync loss
* these tests I understand
* these I sort of understand....
* the one error in the noiseless decoder is gone!
2022-05-13 18:48:26 -04:00
170d574a5d
move logic in to trigger decoder ( #4162 )
...
* move logic in to trigger decoder
* status loop
* minor cleanup
* s
2022-05-10 23:55:28 +03:00
d4509cab8a
TriggerState -> TriggerDecoder ( #4157 )
2022-05-10 11:41:39 +03:00
7e0f2d8337
switch back to flag ( #4155 )
2022-05-10 07:52:29 +03:00
7f5672aaec
encapsulate stuff properly ( #4154 )
2022-05-09 15:46:36 -04:00
32d46d1f09
synchronized Phase handling improvements fix #4099
2022-05-09 04:36:03 -04:00
d5e131b1d0
m_hasSynchronizedSymmetrical handling improvements #4099
...
API progress
2022-05-09 04:04:38 -04:00
88a6b34577
helping build
2022-05-08 09:14:50 -04:00
bd8459875d
refactoring: bringing method names up to date
2022-05-08 09:04:27 -04:00
bd9639b91d
Remove value copy from controller into outputChannels #4095
2022-05-08 08:50:27 -04:00
1ceabed6a5
humans need humane warning messages
2022-04-18 11:35:19 -04:00
06e899e1bb
very random progress
2022-04-16 17:07:57 -04:00
7d657106d7
warning cleanup ( #4020 )
2022-03-22 16:53:24 -04:00
b1de262520
toothed previous time #4019
2022-03-21 20:41:09 -04:00
26c2d76f6c
migrating to SensorType::Rpm API
2022-01-20 23:36:09 -05:00
cda2b711cf
migrating to SensorType::Rpm API
2022-01-20 23:32:59 -05:00
d5c4b79b1a
Nb2 crank sync special case ( #3727 )
...
* extract isSyncPoint
* test because why not
* check vvt resync nb2
* custom nb decoder
* test only resyncs once!
* good job valgrind, you found a bug!
2021-12-31 15:47:25 -05:00
b3de217c1b
adjustment to #3722 ( #3723 )
...
* s
* behold, another bug a test caught
* test
* test generates usable trigger pattern so it works correctly
* comment
* don't need that
2021-12-31 01:21:21 -05:00
4981eb43d0
extract isSyncPoint function ( #3726 )
...
* extract isSyncPoint
* test because why not
* check vvt resync nb2
* clean up noise from test case
* clarify and comment
2021-12-30 11:39:04 -05:00
95ad75318d
improved noFiringUntilVvtSync logic ( #3696 )
...
* s
* poke
* poke again for science
* kick for science
* kick
* kick
* comment kick
* s
* don't try to compare the array decay pointer to 0 (!)
* collateral damage
* adjust miata sync
* reset trigger states correctly on engine stop
* s
* nissan MR too
2021-12-27 12:09:38 -05:00
f826fe13aa
MAP phase sensing #3544
...
trigger sync better gauges/logging
2021-12-06 17:04:05 -05:00
934b005acb
trigger sync better gauges/logging
2021-12-06 13:08:41 -05:00
5c0795f034
random note
2021-11-26 15:48:42 -05:00
c2fa1cea78
minor progress
2021-11-24 22:35:56 -05:00
rusefillc
rusefillc
Andrey
Matthew Kennedy