5cae9663c7
only: assert eventQueue in simulator
2023-11-17 17:46:46 -06:00
d4c21e514c
only: refactoring: reduce guard duplication
2023-11-17 16:53:57 -05:00
78391f04ee
PWM shadowing
2023-11-01 19:37:56 -04:00
35e57475a4
only:variable shadowing should be avoided #5676
2023-11-01 12:12:50 -04:00
198c9e8f57
only:shall we be just a little less Toyota
2023-11-01 10:09:04 -04:00
850d79d89d
shall we be just a little less Toyota
2023-11-01 09:48:33 -04:00
bbab25a378
only: docs
2023-10-26 22:42:21 -04:00
a90f8d4c9f
only:simulator guards
2023-10-19 13:25:19 -04:00
115a0bfef0
consolidate pwm logic
2023-10-06 19:56:14 -04:00
22a10cc0eb
minor pwm logic cleanup
2023-10-06 19:41:40 -04:00
f4da504968
tooth-event angle cannot be negative
2023-10-06 12:21:55 -04:00
a6103dca56
tooth-event angle cannot be negative
2023-10-06 12:21:55 -04:00
e4a3fb260d
only: readability?
2023-10-05 22:42:00 -04:00
696a83d04a
only: documenting the current naming mess
2023-10-05 22:32:20 -04:00
fd69d25866
only: reducing confusion?
2023-10-05 22:03:41 -04:00
f0479fdc17
preparing method for reuse
2023-09-06 08:16:14 -04:00
e81f9f953a
some of these error codes are quite pointless now in 2023
2023-09-05 21:32:50 -04:00
ba66fdcf82
reducing code duplication around assert
2023-09-05 21:28:39 -04:00
464ce6ae50
default arguments are cool even while I might not even need it now
2023-09-05 16:17:13 -04:00
70945665e9
default arguments are cool even while I might not even need it now
2023-09-05 16:01:34 -04:00
05a8a93028
technical debt? our way to have unit tests working is to have this field instead of proper 'this'
2023-09-05 15:38:51 -04:00
c8302be4ae
type clean-up to avoid nasty cast
2023-09-05 15:33:05 -04:00
1067e27a50
this field can use a type
2023-09-05 15:20:57 -04:00
e8c45a2e7d
refactoring: reducing code duplication. Also, do we even care for critical error codes?!
2023-08-20 22:23:44 -04:00
9febfc7070
startPwm should not FATAL fix #5497
2023-08-07 23:32:52 -04:00
bc2a2b9ab9
only:better method name
2023-06-25 02:08:53 -04:00
f77f356e6d
reducing code duplication
2023-06-11 23:17:13 -04:00
8c9b17485e
Revert "Allow scheduling_s to come from a pool ( #4841 )"
...
This reverts commit 5250b177
2023-05-25 10:10:17 -04:00
8f6f7819a4
one step back: sleep implementation not to use heap
2023-05-25 10:10:17 -04:00
9ec713c162
dead doc
2023-05-25 09:49:30 -04:00
cdd7bfe535
code style
2023-05-24 00:09:06 -04:00
61e5b4b1ad
change ObdCode to enum class builds firmware
2023-04-29 00:44:00 -04:00
dc6f53bda5
extract newton's method implementation ( #5157 )
...
* move expected, update libfirmware
* hellen ID solver uses shared Newton's method
* comment shouldn't have been moved
2023-03-07 08:45:17 -05:00
5250b177c2
Allow scheduling_s to come from a pool ( #4841 )
...
* injection events use scheduling pool
* knock and prime
* bench test
* dropped this: *
* extract action before execute
* comment
* init allocated timers
* metrics
* dropped this: ,
* guard
* injection events use scheduling pool
* knock and prime
* bench test
* dropped this: *
* extract action before execute
* comment
* init allocated timers
* metrics
* dropped this: ,
* guard
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2022-12-10 17:55:51 -05:00
994ee2f22f
Combine angle based event ( #4884 )
...
* Remove AngleBasedEventOld/New, only AngleBasedEvent now
* this 7 year old comment of old test code can go away
2022-12-10 17:07:02 -05:00
769cdd32ca
TriggerScheduler cleanup ( #4844 )
...
* TriggerScheduler cleanup
* remove TRIGGER_EVENT_UNDEFINED
* remove dead overload of scheduleOrQueue
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2022-11-28 08:55:38 -05:00
e7b06cbfca
compile warnings: signed vs unsigned and unused ( #4713 )
2022-10-30 09:47:53 -04:00
b089825a4a
schedule ignition charge by angle instead of tooth ( #4513 )
...
* schedule ignition charge by angle
* same mistake as #4536
* s
* wrap sparkAngle too
* AngleBasedEventNew
* function moved
* implement scheduleOrQueue
* prints
2022-09-25 11:00:55 -04:00
af7e4f6fe5
two modes trigger scheduler ( #4598 )
...
* two modes trigger scheduler
* asOld
* hpfp
2022-09-20 05:28:23 -04:00
35997c6318
pwm iteration limit to avoid float math accuracy loss ( #4578 )
2022-09-13 21:16:35 -04:00
55c1f53c75
dead code, reduce typedefs ( #4566 )
...
* Do lightweight checks first
* Dead getTimeIgnitionSeconds()
Dead since 81fffe87b7
2022-09-11 16:08:11 -04:00
851e8e48d3
refactoring: type safety
2022-09-11 02:57:35 -04:00
5962cbd5c2
brutal encapsulation
2022-09-07 20:31:04 -04:00
52869d63bb
tear down Engine god object #4511
...
just trying different things
2022-09-07 20:25:49 -04:00
ab4b451195
os_access.h dead?
2022-09-07 15:56:45 -04:00
769f7ec558
get correct stamp ( #4174 )
2022-05-14 23:01:02 -04:00
500c443a15
Timestamp Error scheduleByTimestampNt too far #3395
...
improving error message
2022-05-14 21:24:19 -04:00
9b820cf1dc
remove suspicious cast that could maybe cause an overflow ( #4169 )
...
* suspicious cast
* don't print 64b
* explicit type
2022-05-13 06:40:37 +03:00
bc6a87cadc
allow enum_class in rusefi_hw_enums.h ( #4104 )
...
* make things c++ friendly
* install various canaries in coal mines
* using is much clearer than typedef
* fixing builds
* lps25
* trigger includes were a mess
* c -> c++ cleanup
* os util
* why did so many include os_util.h?
* fwd declare
* cypress/kinetis
* s
* eg33 happy
* happy sim
* cypress usb
* pch
* cypress
* doesn't need to include all that
* h7
2022-04-25 20:38:16 -04:00
08c1c5d969
Remove legacy check fix #3808
2022-01-18 16:01:27 -05:00
rusefillc
Matthew Kennedy
Andrey
Andrey G