Matthew Kennedy
12cad99136
lambda monitor wiring
2023-06-29 12:00:09 -04:00
David Holdeman
ddc003cc04
add generic gear controller with range sensor inputs
2023-06-16 22:59:25 -04:00
rusefi
7b2985c1c3
Too many bench test buttons are broken #5327
2023-06-15 22:28:15 -04:00
rusefillc
ed7e956d1f
start button logic does not crank started for first X seconds since ECU boot #5324
2023-06-15 00:06:25 -04:00
Andrey
4390320b6c
setSparkSkipRatio limitation #5231
2023-05-25 12:41:11 -04:00
rusefillc
e9fd6e9fa7
better code guard?
2023-05-24 11:46:07 -04:00
rusefillc
8c732cbe51
better code guard?
2023-05-24 10:31:43 -04:00
Matthew Kennedy
73ed1afd06
mockable throttle model
...
(cherry picked from commit 57263be2fe2886d7a3d4116764396b4b5c24dc49)
2023-05-12 16:16:00 -04:00
Matthew Kennedy
a0264f4740
stub throttle model generated
...
(cherry picked from commit 4e619c54947c76e4438a7cc950401ce06af94c35)
2023-04-29 20:15:49 -04:00
Andrey
6b4c4a5833
refactoring: vvt is not aux
...
only:hellen-honda-k
2023-03-05 02:07:47 -05:00
Andrey
800d46eb3b
docs
2023-02-28 22:11:38 -05:00
rusefillc
e385537102
we have two methods of very similar purpose?
2023-02-20 19:05:31 -05:00
rusefi
4fc1f5ad24
Native SENT TPS input #5079
2023-02-14 20:39:25 -05:00
Andrey
102e984efa
Nick wonders if DC wastegate is still FUBAR #5075
2023-02-13 17:59:45 -05:00
Andrey
6588e813ae
totalFuel and totalIgnition correction gauges in Tunerstudio #4955
2023-01-15 08:26:38 -05:00
Andrey
9abdab795d
totalFuel and totalIgnition correction gauges in Tunerstudio #4955
2023-01-14 23:21:23 -05:00
rusefillc
6146b01a36
antilag and anti-lag #2403
...
TurboMarian is the ALS boss
2022-12-21 20:12:00 -05:00
rusefillc
37c35e08bb
TurboMarian is the ALS boss
2022-12-16 23:31:51 -05:00
rusefillc
55062b1ef6
refactoring: constexpr fuel computer ( #4830 )
...
* refactoring: constexpr fuel computer
* refactoring: constexpr fuel computer
* refactoring: constexpr fuel computer
Co-authored-by: rusefillc <sdfsdfqsf2334234234>
2022-11-26 12:25:04 -05:00
rusefi
7cc6d9c07c
removing dead code
2022-11-06 20:39:40 -05:00
rusefillc
ba73aff1fa
startStopStateToggleCounter to live data
2022-10-06 22:21:02 -04:00
Matthew Kennedy
940e0dc369
require ignition on for firing ( #4628 )
...
* require ignition on for firing
* too much havoc for a unit test
* patch up references
* last one
* fix changelog mangling
* fix the changelog template too
* bad merge
* fix the template again
* s
* fake battery voltage on hw ci
* ugh merge
* ugh merge
2022-10-04 20:36:03 -04:00
rusefi
529fb35c66
need Proteus QC
2022-10-01 22:00:25 -04:00
Andrey
baaec6a603
refactoring: encapsulation
2022-09-28 22:42:08 -04:00
Matthew Kennedy
dfe1b47b4d
remove ignitionPin ( #4608 )
...
* remove ignitionPin
* now that's gone
* BMW test
2022-09-23 17:30:10 -04:00
rusefillc
ec0e567989
tear down Engine god object #4511
2022-09-15 21:46:01 -04:00
Andrey
0e91914266
deep rabbit holes are the best ones!
...
refactoring: encapsulation
2022-09-14 02:35:55 -04:00
Andrey
663c39afdc
deep rabbit holes are the best ones!
...
refactoring: encapsulation
2022-09-14 02:24:41 -04:00
Andrey
2c0ce0ec7d
deep rabbit holes are the best ones!
...
refactoring: encapsulation
2022-09-14 02:17:04 -04:00
Andrey
12d857b99c
deep rabbit holes are the best ones!
...
refactoring: encapsulation
2022-09-14 02:06:52 -04:00
Andrey
6cdb0dc0af
deep rabbit holes are the best ones!
...
refactoring: encapsulation
2022-09-14 01:53:17 -04:00
Andrey
82cda62bac
inline method to reduce confusion
2022-09-14 01:34:52 -04:00
Andrey
6b0941b8ed
inline method to reduce confusion
2022-09-14 01:24:19 -04:00
rusefillc
e733782920
i suspect that no one cares about these
2022-09-14 00:34:04 -04:00
Andrey G
55c1f53c75
dead code, reduce typedefs ( #4566 )
...
* Do lightweight checks first
* Dead getTimeIgnitionSeconds()
Dead since 81fffe87b7
* Get rid of efitime_t.
Purpose are not clear. Use efitick_t where ticks are used,
use efitimeus_t for uS, use efitimems_t or efitimems64_t for mS.
* Fix unit tests
* Fix misc: stm32f1_test_project
2022-09-11 16:08:11 -04:00
rusefillc
a3d86c61f2
"Blip" with trigger error on several boards #4552
...
exploratory watchdog
2022-09-09 18:27:16 -04:00
rusefillc
45eaa0546c
refactoring: better method name
2022-09-09 18:02:38 -04:00
Andrey
2d9dbbd6b8
extracting prime_injection
2022-09-07 16:25:50 -04:00
Andrey
4934d76d88
tear down Engine god object #4511
...
just trying different things
2022-09-05 04:24:17 -04:00
Andrey
99d8801dc6
tear down Engine god object #4511
...
just trying different things
2022-09-05 02:59:38 -04:00
Andrey
268a5c7964
tear down Engine god object #4511
...
just trying different things
2022-09-05 02:44:06 -04:00
Andrey
d51511a15e
refactoring: moving field
2022-09-05 00:53:05 -04:00
Andrey
ccfe2a5d58
refactoring: splitting header where cpp was already split
2022-09-05 00:48:38 -04:00
Matthew Kennedy
9407150544
more granular trigger error messages ( #4526 )
...
* granular trigger error messages
* adjust test expectations
* explicitly test behavior
2022-09-04 09:15:24 -04:00
Andrey
6b4e6c8169
tear down Engine god object #4511
...
just trying different things
2022-09-03 11:07:26 -04:00
rusefillc
8e46e9e61f
I am sure that's not magic ( #4516 )
...
* I am sure that's not magic
* forward declaration acts funny
2022-09-01 22:33:45 -04:00
Andrey
f84f69a4d4
another dead line
2022-09-01 21:13:03 -04:00
Andrey
532f6dd202
what a mess :(
2022-09-01 20:16:57 -04:00
Andrey
9d8afea152
a bit of dead code
2022-09-01 11:47:56 -04:00
Andrey
e240ac84d3
refactoring: reducing outputChannels copy
2022-09-01 01:06:49 -04:00
Andrey
4cbaddcc60
less code is better
2022-08-31 23:14:20 -04:00
rusefillc
0613b2627e
more proper fix for part of https://github.com/rusefi/rusefi/pull/4493
2022-08-27 22:28:29 -04:00
rusefillc
84ff4e98c0
docs
2022-08-25 23:50:00 -04:00
rusefillc
50a1794851
saving 4 bytes of RAM?
2022-08-25 22:34:16 -04:00
rusefillc
67055c69bf
progress or maybe even a fix of logging?
2022-08-25 22:24:35 -04:00
rusefillc
733f9b4659
this code is too dead
2022-08-25 22:09:22 -04:00
Andrey
cecc5a9d6e
https://github.com/rusefi/hellen154hyundai/issues/60
...
extra logging
2022-08-25 19:58:10 -04:00
Matthew Kennedy
b6f1779781
implement sensor checker ( #4395 )
...
* implement sensor checker
* use default
* s
* fix
* properly report non-timeout errors
* it's not safe to read Value when invalid
* it's not safe to read Value when invalid
2022-07-30 17:08:48 -04:00
rusefillc
26ae6f7490
[SECURITY] Cheap password protection against tune modification fix #4243
2022-07-30 12:23:53 -04:00
rusefillc
cad14d6541
#4308 progress
2022-07-14 12:36:55 -04:00
rusefillc
f7ecebaa64
logging of live data structs was: data points #3614
2022-06-29 02:37:24 -04:00
rusefi
a552d58d42
verbose trigger sync should reuse engineSnifferRpmThreshold #4259
...
reducing complexity
2022-06-18 14:17:36 -04:00
Matthew Kennedy
f945e6efc9
trigger configuration refactoring for clarity ( #4212 )
...
* This field was ignored.
* move pad out
* gone
* make trigger configuration a little clearer
* even simpler!
* format
* test fix
2022-05-30 19:36:47 -04:00
Matthew Kennedy
170d574a5d
move logic in to trigger decoder ( #4162 )
...
* move logic in to trigger decoder
* status loop
* minor cleanup
* s
2022-05-10 23:55:28 +03:00
rusefillc
2132cec3fc
Remove value copy from controller into outputChannels #4095
2022-05-09 06:12:17 -04:00
David Holdeman
49f8daae14
More untested transmission features ( #4093 )
...
* use ISS for gearbox ratio, add gauge for TC ratio
* measure shift time
* add shift time gauge, todo notes for pc
* do conversion in the right direction
* switch to Timer and seconds
* try fixing build
* try fixing build again
* try defines, remove include
* use shift pcs
* add 3-2 pct curve
* control 3-2 solenoid
* move 3-2 to persistent config
* fix param
2022-04-23 07:34:39 -04:00
Matthew Kennedy
16de438ab8
knock threshold table fix ( #4077 )
...
* fix knock threshold table
* defaults
* knock controller is engine module
* testable
* test builds
* knock tests work
* s
* format
* everyone loves changelogs
2022-04-18 08:03:16 -04:00
rusefillc
82f608d558
one step sideways to fix build
2022-04-16 21:24:02 -04:00
rusefillc
08c50cc1dd
logging of live data structs was: data points #3614
...
progress
2022-04-16 21:04:02 -04:00
rusefillc
06e899e1bb
very random progress
2022-04-16 17:07:57 -04:00
rusefillc
413e636d4c
typo/grammar
2022-04-13 17:55:31 -04:00
rusefillc
3c7eb93fe1
steps towards ignition live data
2022-04-13 16:48:25 -04:00
rusefillc
e1235c4f2e
Air Conditioning Improvements #4054
2022-04-09 00:26:52 -04:00
Matthew Kennedy
ad368b2031
Gear detection improvements ( #4047 )
...
* gear detect improvements
* ui
* ui for gear ratios
* ui
2022-04-06 16:15:58 -04:00
rusefillc
6b5747d4c8
refactoring: method rename
2022-04-02 21:01:29 -04:00
Matthew Kennedy
f742ae8b7e
limp mangaer handles more stuff ( #3983 )
2022-03-20 09:28:17 -04:00
rusefi
998cba5521
EFI_LAUNCH_CONTROL clean-up
2022-02-06 18:46:09 -05:00
Matthew Kennedy
40d16291b0
Remove fsio part 2 ( #3876 )
...
* dead config stuff
* fsio state
* remove tests
* getEngineValue
* put part back
2022-02-02 00:49:44 -05:00
rusefillc
751355a04b
Limp shutdown rebase ( #3879 )
...
* limp manager handles engine stop
* use timer
* dead relevant fsio
* this stuff needs its own ticket
* if we can comment out 'business logic' and tests do not fail it's not a great sign :(
Co-authored-by: Matthew Kennedy <matthewkennedy@outlook.com>
Co-authored-by: rusefillc <sdfsdfqsf2334234234>
2022-02-01 20:47:17 -05:00
Matthew Kennedy
eb14d74846
extract logic from wall wetting AE ( #3848 )
...
* extract logic
* extract interface
* explicitly test wall fuel
2022-01-27 07:45:50 -05:00
Matthew Kennedy
717d931e78
refactor decel fuel cut ( #3830 )
...
* refactor dfco
* s
* output channel logs dfco
* slightly cheeky comment
2022-01-23 19:44:41 -05:00
Matthew Kennedy
76fdb4063e
XY Idle VE Table ( #3781 )
...
* config & ui
* implement
* test idle VE switching behavior
* use the interface where we can
* s
* re-bump flash version
2022-01-20 14:08:54 -05:00
rusefillc
6ee0a55eaf
RE usability: live data for idle controller
2022-01-10 19:48:58 -05:00
Matthew Kennedy
ab3e3ac83f
hook up fuel trims ( #3715 )
...
* hook up fuel trims
* pass all the params
* store per-cylinder fuel mass directly
* main trigger callback only touches per-cylinder, no banks!
* test test test test
* move UI to happy land
* changelog
2022-01-01 02:19:59 -05:00
Matthew Kennedy
d5c4b79b1a
Nb2 crank sync special case ( #3727 )
...
* extract isSyncPoint
* test because why not
* check vvt resync nb2
* custom nb decoder
* test only resyncs once!
* good job valgrind, you found a bug!
2021-12-31 15:47:25 -05:00
rusefillc
f685bab9eb
live data for wastegate and launch control #3588
2021-12-16 16:19:33 -05:00
Matthew Kennedy
4148ee76bf
smarter priming logic ( #3674 )
...
* ignition controller detects rising edge on voltage
* update test
* comment
* ignore negative transients
* tweak
* test
* priming happens on ignition-on
* priming has its own scheduling
* config & UI
* dead config
* implementation
* look, the test caught a bug
* keep the watchdog happy
* bad merge
* changelog
* easier to read the test
* test naming
2021-12-08 16:20:19 -05:00
Matthew Kennedy
2050580a16
prime upon ignition voltage, not on power on ( #3662 )
...
* ignition controller detects rising edge on voltage
* update test
* comment
* ignore negative transients
* tweak
* test
* priming happens on ignition-on
* priming has its own scheduling
* test
* dead adjacent line of code
2021-12-08 07:26:49 -05:00
Matthew Kennedy
91ec135cf8
ignition controller detects rising edge on voltage ( #3636 )
...
* ignition controller detects rising edge on voltage
* update test
* comment
* ignore negative transients
* tweak
* test
2021-12-07 21:28:04 -05:00
Andrey
940b04ab24
Let's always have TS structure so that unit tests can check values in outputChannels, kind of making outputChannels a god dump for state but whatever since Live View is coming
2021-12-07 20:18:47 -05:00
rusefillc
b778aa7173
Pause CAN broadcast on engine stop #3665
2021-12-07 10:35:52 -05:00
rusefillc
dbb3de3618
tune via CAN #3361
...
pauseCANdueToSerial
2021-12-05 21:21:36 -05:00
Matthew Kennedy
7dc20b368a
Alternator controller is engine module ( #3663 )
...
* alternator is engine module
* user can't set pid period
2021-12-05 18:33:50 -05:00
Matthew Kennedy
555a8d5f43
simplify cylinder phasing ( #3650 )
2021-12-05 10:46:35 -05:00
Matthew Kennedy
0badb6b2ff
AC is EngineModule ( #3604 )
...
* AC is engine module
* missed a spot with main relay while we're at it
* TS
2021-11-25 07:59:31 -05:00
rusefillc
3077f795c4
live data for wastegate #3588
2021-11-24 12:59:57 -05:00
Matthew Kennedy
81fffe87b7
main relay doesn't use fsio ( #3580 )
...
* fuel pump
* s
* call correct callback
* more dead
* test adjustment
* don't overflow
* don't need separate function
* java
* give it a name
* generated
* generated
* add to generate script
* import *
* this is so cheap we don't need a flag
* main relay
* plumbing
* dead fsio stuff
* test it
* by 100%, we mean 99.98%
2021-11-24 07:47:51 -05:00
Scott Smith
5bc1949aef
Basic framework for high pressure fuel pump control ( #3476 )
...
* Basic framework for high pressure fuel pump control
* Many changes
Move calculations to fast callback
Move main object into Engine
Respond to pin changes without requiring a reboot
* Use EngineModule for HpfpController
Schedule pin off after executing pin on so we are sure it ends, even if the motor stops.
Test scheduling.
Less RAM use by only having one event and reordering fields.
* Make scheduling test actually useful - need non-0 activation angle.
Co-authored-by: rusefillc <48498823+rusefillc@users.noreply.github.com>
2021-11-19 23:06:51 -05:00
Matthew Kennedy
d40ca0f581
fuel pump doesn't use fsio ( #3576 )
...
* fuel pump
* s
* call correct callback
* more dead
* test adjustment
* don't overflow
* don't need separate function
* java
* give it a name
* generated
* generated
* add to generate script
* import *
* this is so cheap we don't need a flag
2021-11-19 22:23:12 -05:00
Scott Smith
18c27a6e9c
Separate out scheduleOrQueue into it's own standalone scheduler. ( #3573 )
...
It's a large enough entity that it shouldn't be buried in ignition logic.
2021-11-18 14:27:21 -05:00