Commit Graph

874 Commits

Author SHA1 Message Date
Matthew Kennedy a4871c703c
Autoscale all the things! (#3713)
* Map3D accepts any scaled_channel type

* consistency

* reinstate test

* fix ratio

* throttle, boost, gppwm

* scale ignition and VE

* tests
2021-12-22 08:09:41 -05:00
rusefillc f27b4dbd95 dead code? 2021-12-16 21:06:23 -05:00
Matthew Kennedy 4148ee76bf
smarter priming logic (#3674)
* ignition controller detects rising edge on voltage

* update test

* comment

* ignore negative transients

* tweak

* test

* priming happens on ignition-on

* priming has its own scheduling

* config & UI

* dead config

* implementation

* look, the test caught a bug

* keep the watchdog happy

* bad merge

* changelog

* easier to read the test

* test naming
2021-12-08 16:20:19 -05:00
Andrey 50038167d8 MAP phase sensing #3544
new implementation seems complete?
2021-12-07 21:08:25 -05:00
Matthew Kennedy a37c9bca9e
Remove the EFI_NO_CONFIG_WORKING_COPY option (#3630)
* no working copy

* oops
2021-11-29 16:44:45 -05:00
rusefillc 818d12f68e why so many channels are hidden in debug ? #3614 2021-11-29 10:16:45 -05:00
Matthew Kennedy d5363b814a
better VSS configuration (#3542)
* vss uses real values

* some defaults

* test and correct math

* km, not miles!

* comment

* tooltip

* that macro went away

* 100hz and default settings gives 9kph

* changelog

* order of operations safety

* make the test like the pwm test

* housekeeping

* this is why we need sensor automation

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-11-27 08:49:07 -05:00
Andrey 12d5106614 isCylinderCleanupEnabled would be nice by default 2021-11-24 23:32:55 -05:00
rusefillc 794ec5e2b8 well Lua wants to be BIG 2021-11-23 16:40:04 -05:00
Matthew Kennedy 3334a6963c
oh my god we've had no asserts (#3595) 2021-11-22 17:52:03 -05:00
rusefillc a369e7e3d3 unusedLogFormat 2021-11-22 13:37:06 -05:00
Matthew Kennedy bb57a4b084
detect more overflows with asan (#3582)
* overflow detector

* type list dynamic allocate

* fix the buffer length

* comment

* pr fb

* sanitize sim

* fix sim sanitizer bug

* didn't mean to turn off optimization for sim

* asan can do that, if you turn it on!

* cleaning
2021-11-20 01:38:39 -05:00
Scott Smith 69d36dad6e
Final cleanup of ENGINE macros (#3567)
Fix some uses of ENGINE() not detected by regex due to parenthesis.
Remove now empty engine_ptr.h
Don't worry about EFI_* not being defined, the compiler defaults to 0 if they aren't.
2021-11-17 13:45:10 -05:00
Scott Smith 988aacdd91
Create a base class EngineModule for that contains various useful callbacks. (#3548)
* Create a base class EngineModule for that contains various useful callbacks.

This cleans up the API by not requiring the notifiers to know about who wants callbacks.  The only
place you need to update to add a module is in one place.

* Add mockability.

* Convert InjectorModel to a Mockable EngineModule
2021-11-17 20:13:19 +03:00
Scott Smith 823d9a07e0
Programmatically replace ENGINE() and CONFIG() with engine-> etc (#3565)
git grep -l -w ENGINE | xargs sed -i -r "s/ENGINE\(([]a-zA-Z_0-9.[]+)\)/engine->\1/g"

git grep -l -w CONFIG | xargs sed -i -r "s/([^a-zA-Z_])CONFIG\(([]a-zA-Z_0-9.[]+)\)/\1engineConfiguration->\2/g"
2021-11-17 03:54:21 -05:00
Scott Smith 70ad9724c0
Make engine* and friends be const pointers in production. (#3564)
This allows the compiler to see through the pointer and make accesses faster.
It saves 1336 bytes of text.
2021-11-17 03:53:17 -05:00
Matthew Kennedy 8cdac4cac0
remove engine pointer passing (#3556)
* some

* more

* more

* the last?!
2021-11-16 04:15:29 -05:00
Andrey 0cc88ec6e2 Not all launch control options are used #3554 2021-11-15 21:13:01 -05:00
rusefillc 68ebb8045d Epic: Remove FSIO #2928 2021-11-14 11:04:51 -05:00
rusefillc 22c872d8d8 Epic: Remove FSIO #2928 2021-11-14 10:57:19 -05:00
rusefillc c22215cea7 Epic: Remove FSIO #2928 2021-11-14 10:39:47 -05:00
rusefillc 991d0c5001 Epic: Remove FSIO #2928 2021-11-14 08:33:19 -05:00
rusefillc 0a9682c553 Epic: Remove FSIO #2928 2021-11-14 07:24:50 -05:00
rusefillc a9bcce88d0 script settings need names! 2021-11-13 22:47:46 -05:00
rusefillc 8333234737 Something something Automatic Compression Release #3442 2021-11-13 04:24:53 -05:00
rusefi 8aaecb568e pid demo progress 2021-11-08 17:31:33 -05:00
rusefillc ce45a907a7 a bit of dead code 2021-11-06 23:39:56 -04:00
rusefillc b244c59cd8 a bit of dead code 2021-11-06 21:19:56 -04:00
rusefillc 4f738b366e a bit of dead code 2021-11-06 21:01:01 -04:00
rusefillc 7b8821955b a bit of dead code 2021-11-06 18:43:19 -04:00
rusefillc 1ead914f93 more curves! also names for curves 2021-11-04 23:59:04 -04:00
rusefillc 85984928ca more curves! also names for curves 2021-11-04 23:19:44 -04:00
rusefi 1d9aa8bd12 turboSpeedSensorMultiplier 2021-11-04 19:35:58 -04:00
rusefillc db310a4bd0 most dead miata config 2021-11-04 09:56:05 -04:00
rusefillc 7e4ade6b0f better VVT default? 2021-10-31 15:25:43 -04:00
rusefillc 4c164aaf5c Honda K & default VVT pid 2021-10-29 12:16:19 -04:00
rusefi 75d8d334b7 secondary MRE 2021-10-27 19:54:45 -04:00
Andrey e6faf2fa15 UNUSED 2021-10-26 21:24:16 -04:00
Andrey 45280d7435 MRE_SECONDARY_CAN 2021-10-26 21:05:38 -04:00
rusefillc 87b3df1cf5 generate java enum from C enum? generate both C and java from yaml? #2102 2021-10-24 14:17:37 -04:00
rusefillc bf7ae2c76e generate java enum from C enum? generate both C and java from yaml? #2102 2021-10-24 13:10:38 -04:00
rusefillc eead8fa1f6 generate java enum from C enum? generate both C and java from yaml? #2102 2021-10-24 09:31:32 -04:00
rusefillc c6d47c1a8a generate java enum from C enum? generate both C and java from yaml? #2102 2021-10-24 09:16:11 -04:00
rusefillc e6b92ddb0c very old very dead code 2021-10-20 10:45:43 -04:00
rusefillc 66e0ecf0f2 honda 2021-10-12 18:31:48 -04:00
rusefillc 7e57239cae hyundai 2021-10-11 15:04:27 -04:00
rusefillc 376b227480 hyundai 2021-10-11 14:22:35 -04:00
rusefillc 2a87208380 hyundai 2021-10-11 12:37:24 -04:00
rusefillc f57ac55d9e NB1 defaults #3299 2021-10-02 23:21:43 -04:00
rusefillc 0f1a640258 proteus adapters 2021-10-02 13:20:19 -04:00
rusefillc b64c499848 nb1 is 144 pin 2021-09-27 22:26:09 -04:00
Andrey 65f8caa686 vr threshold test configuration 2021-09-26 02:21:21 -04:00
rusefi 2d74840296 hellen and else are confused about pins they do not know about 2021-09-25 19:37:30 -04:00
rusefi 26dc3303bd hellen and else are confused about pins they do not know about 2021-09-25 19:06:24 -04:00
Matthew Kennedy 8cd132b8a8
dead knock code (#3255)
* more unification

* hip stub

* comment

* guard

* channel idx

* include

* hip

* move in to engine

* hip9011

* dead stuff

* dead

* fsio

* lcd

* more dead
2021-09-21 20:40:20 -04:00
rusefillc 3e50319eb7 merc128: engine config defaults #3236 2021-09-18 21:27:17 -04:00
rusefillc 9d0c043dc1 merc128: engine config defaults #3236 2021-09-18 00:17:52 -04:00
rusefillc 092cca03ab merc128: engine config defaults #3236 2021-09-17 23:10:36 -04:00
Matthew Kennedy a18b86a09b
start allowing ADC change while running (#3100)
* allow re-register of the same sensor

* add api to unsubscribe

* do it for tps

* clear the pin

* happy test

* maybe make afr happy for now

* tests build

* happy simulator

* active configuration

* check valid

* we need vbatt now

* manage all pin init in init_sensors.cpp

* don't need that

* cleanup

* thermistors

* do two phase reinit in the right place

* config vs engine

* finally the tests are happy
2021-08-24 16:41:16 -04:00
rusefillc 767496f3f4 94/95 miata presets #3191 2021-08-24 16:03:50 -04:00
Andrey 03ffa82d8e zero dwell warning at zero RPM #3153 2021-08-16 09:11:22 -04:00
rusefillc e786af1c83 NB2 36 2021-08-10 02:34:59 -04:00
rusefillc 63e53aebc0 Implement auto knock threshold sampling #3033 2021-08-09 17:07:38 -04:00
Andrey 0df437e749 Nissan 4 cylinder QR trigger wheel #3118 2021-08-08 07:04:18 -04:00
Andrey 08dff4ceb6 Nissan 4 cylinder QR trigger wheel #3118 2021-08-08 06:16:19 -04:00
rusefillc 8cffec5c31 HELLEN_154_HYUNDAI 2021-08-03 13:51:33 -04:00
Matthew Kennedy b52d50bbf2
Use pch in lots of files (#3066)
* most engine.h

* most engine_configuration

* more

* more

* more

* more

* more

* moooooore

* ok I'm done for now

* oops
2021-07-26 01:05:17 -04:00
rusefi ee1426387b Red test mule cranking to idling is weird #3050 2021-07-24 11:56:29 -04:00
Andrey a8afb6eb85 trailing spark outputs #2931 2021-07-21 19:55:14 -04:00
Matthew Kennedy 2ce7777865
don't require EXTERN_ENGINE in every file (#2969)
* move enginePins

* no more extern engine

* uses

* more

* extern config too

* put this where it belongs

* include correct header

* merge
2021-07-16 18:13:33 -04:00
Andrey 23be588af6 trigger signal debug pins - logic level output #2959 2021-07-15 01:28:44 -04:00
Andrey 70872c8bf4 trigger signal debug pins - logic level output #2959 2021-07-14 22:35:29 -04:00
rusefi 6b25e220e6 VAG canned tunes 2021-07-09 01:53:09 -04:00
Andrey 3d0ba4af5c VAG canned tunes 2021-07-08 20:42:35 -04:00
rusefillc c229aeb46c
mobile browser coding 2021-07-08 18:09:03 -04:00
rusefi 4ead86c521 VAG canned tunes 2021-07-08 16:35:58 -04:00
Matthew Kennedy 188bf9bd57
hellen 128 defaults (#2912)
* all the pins

* s

* ign
2021-07-06 01:03:07 -04:00
Matthew Kennedy 142e44d82b
misc (#2899)
* dead fields

* defaults

* ui

* configs
2021-07-04 09:22:42 -04:00
Andrey bd5ff4b5a5 Nissan progress 2021-07-02 16:31:10 -04:00
Andrey a039c52897 Nissan progress 2021-07-02 16:26:23 -04:00
Andrey 82439b3ffd so many wonderful discoveries 2021-06-27 00:54:38 -04:00
Andrey 4463ca1fdb depressing code comment 2021-06-26 23:01:47 -04:00
Matthew Kennedy ce4eb2b55d
fix trigger changed logic (#2860)
* reenable

* fix

* longer interval between updates

* only deinit hard trigger outputs if necessary

* init logic

* init order

* warning

* guard

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-06-25 19:38:42 -04:00
Andrey 266e50f4ca Trigger: warning code on normal engine start up #669
making more code unit-testable
2021-06-25 11:50:23 -04:00
Andrey 35a63cad89 Revert "TS Burned All Data engine stop #2839"
This reverts commit dcb52a5b
2021-06-21 08:53:39 -04:00
Andrey dcb52a5b37 TS Burned All Data engine stop #2839
second guess
2021-06-21 03:10:59 -04:00
Andrey 3aab93b122 TS Burned All Data engine stop #2839
first wild guess
2021-06-21 02:51:12 -04:00
Andrey 640097f327 Review default H64 tune #2815 2021-06-13 21:27:03 -04:00
Matthew Kennedy e7f17b0365
move ign & cranking defaults (#2791)
* ignition defaults

* cranking

* s
2021-06-03 14:40:19 -04:00
Matthew Kennedy 981e8f5047
defaults cleanup: base engine & fuel (#2790)
* build

* fuel and base

* fix build

* cleanup

* extern

* tps/tps

* alternator

* tps

* iat timing

* cranking RPM

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-06-03 00:50:07 +03:00
Matthew Kennedy 790ac08a2e
Cranking defaults (#2787)
* defaults

* more

* cranking fuel

* cranking timing

* cranking time digits

* ugh these tests shouldn't depend on defaults
2021-06-02 08:21:36 +03:00
Matthew Kennedy de7879b6e4
convert a table to scaled_channel (#2724)
* scaled VE table

* use setTable

* efi::clear

* ratio -> struct
2021-05-20 20:00:32 -04:00
Andrey a762853d3b refactoring magic constant STOICH_RATIO 2021-05-20 02:39:20 -04:00
rusefillc 73bc91dee4 Improve default H64 tune #2709 2021-05-19 03:50:28 -04:00
Matthew Kennedy b373c03db8
Lua script editor in console (#2699)
* stub

* implement reset

* console

* just use the console command

* cleanup

* s

* s

* ui

* write in chunks

* fix write

* tab size, script read

* parse script properly

* put lua script in flash, tiny for now

* generated fields
2021-05-18 20:58:39 +03:00
Matthew Kennedy 04f9019df2
Post cranking fuel tweaks (#2718)
* post cranking factor limits

* sensible defaults

* but not for tests

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-05-17 17:24:29 -04:00
Matthew Kennedy dd6105cfa3
shrink canned tables (#2651)
* helper

* use it miata

* do type safe copy

* miata vvt

* etb

* default iat correction

* magic is afoot here

* hunchback

* misc

* neon

* neon

* aspire

* citroen

* neon

* missed one

* dead

* festiva

* remove andreyism

* very dead

* no need for copy of that function

* cleanup
2021-05-09 14:37:16 -04:00
Andrey G e18ba01fe5
hip9011 (#2658)
* hip9011: isolate debug stuff

* hip9011: renames

* hip9011: start sensing knockDetectionWindowStart degres from fire

* engine: more realistic values for knock window

* hip9011: remove magic CS toggling

* hip9011: EFI_HIP_9011_DEBUG should depend on EFI_HIP_9011
2021-05-08 18:43:55 -04:00
Matthew Kennedy bb0662791b
use setTable (#2621) 2021-05-04 10:03:41 -04:00
rusefillc 4dc461891a 2021 is the year of Hellen 2021-05-03 00:01:53 -04:00