6b4e6c8169
tear down Engine god object #4511
...
just trying different things
2022-09-03 11:07:26 -04:00
d329f8ae10
tear down Engine god object #4511
...
just trying different things
2022-09-03 07:44:24 -04:00
aef1f19af9
typo
2022-09-03 07:26:49 -04:00
244ef7630d
Auto-generated configs and docs
2022-09-02 18:42:52 +00:00
25f4ebbc01
moving state into specific class ( #4520 )
...
* moving state into specific class
* moving state into specific class
2022-09-02 14:38:03 -04:00
f6ae78e72c
another huh ( #4517 )
...
* another huh
* why does this not compile
2022-09-02 13:10:21 -04:00
8e46e9e61f
I am sure that's not magic ( #4516 )
...
* I am sure that's not magic
* forward declaration acts funny
2022-09-01 22:33:45 -04:00
93d28555f6
Revert "tear down Engine god object #4511"
...
This reverts commit 8d6a87ae21
2022-09-01 20:44:51 -04:00
48f960b581
Revert "tear down Engine god object #4511"
...
This reverts commit dc60837e4c
2022-09-01 20:44:51 -04:00
dc60837e4c
tear down Engine god object #4511
...
just trying different things
2022-09-01 20:16:41 -04:00
8d6a87ae21
tear down Engine god object #4511
...
just trying different things
2022-09-01 20:15:46 -04:00
e6ae70dee6
tear down Engine god object #4511
...
just trying different things
2022-09-01 19:24:19 -04:00
059b06292b
Auto-generated configs and docs
2022-09-01 23:18:26 +00:00
db9d4c8201
tear down Engine god object #4511
...
just trying different things
2022-09-01 19:05:40 -04:00
fcd0636a01
tear down Engine god object #4511
...
just trying different things
2022-09-01 19:00:16 -04:00
e617722fb1
tear down Engine god object #4511
...
smallest step maybe forward
2022-09-01 13:55:03 -04:00
3d6d710379
Auto-generated configs and docs
2022-09-01 15:03:34 +00:00
7e340cceb3
refactoring: reducing outputChannels copy
2022-09-01 10:58:16 -04:00
ea1d2b848f
Auto-generated configs and docs
2022-09-01 14:39:52 +00:00
56f6c10042
refactoring: reducing outputChannels copy
2022-09-01 10:30:07 -04:00
b6bb5f148d
set a default, detect error ( #4504 )
2022-08-31 20:32:37 -04:00
4d66dff87c
dfco delay ( #4482 )
...
* dfco delay
* config
* using a function that doesn't exist? who does that
* test new behavior
* clearer test
2022-08-25 21:26:17 -04:00
923d2c2e44
unexpected contains information about why it failed ( #4393 )
...
* unexpected can contain information
* info printing
* sensors return appropriate error codes
* remove reliance on undefined behavior
* s
2022-07-28 10:04:28 +03:00
38213bbc00
more missing autoscale ( #4112 )
...
* autoscale m_config->timeConstant
* min/max afr
* more
* dwell voltage
* closed loop fuel
* knock
* map estimate
* applyNonlinearBelowPulse
* fix
* add a test while we're at it for un-covered code
* test fallback MAP since we touched that
* always compute fallback MAP even if sensor is OK
2022-04-28 08:16:02 -04:00
a2cff4ee12
Auto-generated configs and docs
2022-04-17 20:30:07 +00:00
28950acf3e
disable fuel trim shortly after DFCO ( #3847 )
...
* vss based dfco
* fix digits while we're here
* fix some other digits for fun
* don't use custom assert
* simplify test
* less than or equal, test vss behavior
* disable closed loop fuel after dfco1
* I can't type
* correct comparison helps
* poke
2022-01-28 21:35:23 -05:00
2444090933
vss based dfco ( #3845 )
...
* vss based dfco
* fix digits while we're here
* fix some other digits for fun
* don't use custom assert
* simplify test
* less than or equal, test vss behavior
* even better than comments are tooltips
2022-01-27 14:05:18 -05:00
df1635b5a0
dfco checks driver throttle intent ( #3832 )
2022-01-24 14:26:39 -05:00
717d931e78
refactor decel fuel cut ( #3830 )
...
* refactor dfco
* s
* output channel logs dfco
* slightly cheeky comment
2022-01-23 19:44:41 -05:00
2208947bb3
Auto-generated configs and docs
2022-01-05 06:49:51 +00:00
38b17f5859
Auto-generated configs and docs
2022-01-05 05:09:04 +00:00
8f68e8e646
refactoring - enum has more usages now
2021-12-26 14:53:27 -05:00
b337fed520
live data
2021-12-26 13:00:17 -05:00
7cb3eb4c9a
live data
2021-12-26 13:00:17 -05:00
9f8ccececd
docs & refactoring
2021-12-26 12:35:41 -05:00
940b04ab24
Let's always have TS structure so that unit tests can check values in outputChannels, kind of making outputChannels a god dump for state but whatever since Live View is coming
2021-12-07 20:18:47 -05:00
26997ab9e3
why so many channels are hidden in debug ? #3614
2021-11-29 01:02:40 -05:00
988aacdd91
Create a base class EngineModule for that contains various useful callbacks. ( #3548 )
...
* Create a base class EngineModule for that contains various useful callbacks.
This cleans up the API by not requiring the notifiers to know about who wants callbacks. The only
place you need to update to add a module is in one place.
* Add mockability.
* Convert InjectorModel to a Mockable EngineModule
2021-11-17 20:13:19 +03:00
823d9a07e0
Programmatically replace ENGINE() and CONFIG() with engine-> etc ( #3565 )
...
git grep -l -w ENGINE | xargs sed -i -r "s/ENGINE\(([]a-zA-Z_0-9.[]+)\)/engine->\1/g"
git grep -l -w CONFIG | xargs sed -i -r "s/([^a-zA-Z_])CONFIG\(([]a-zA-Z_0-9.[]+)\)/\1engineConfiguration->\2/g"
2021-11-17 03:54:21 -05:00
cc95bd6c8e
Programmatically remove EnginePtr/inject, EXPAND_Engine, and WITH_ENGINE_TEST_HELPER* ( #3560 )
...
* Programmatically remove EnginePtr/inject, EXPAND_Engine, and WITH_ENGINE_TEST_HELPER*
for i in ": public EnginePtr " ", public EnginePtr" "EXPAND_Engine;" "EXPAND_Engine"; do
git grep -l "$i" | xargs sed -i "s/$i//g"
done
git grep -l "inject" | xargs sed -i "/inject[(][)]/d"
for i in WITH_ENGINE_TEST_HELPER_SENS WITH_ENGINE_TEST_HELPER_BOARD_CALLBACK WITH_ENGINE_TEST_HELPER; do
git grep -l "$i" | xargs sed -i "s/$i/EngineTestHelper eth/g"
done
git checkout firmware/controllers/core/engine_ptr.h
git checkout unit_tests/global.h
* Review fixups.
2021-11-16 16:52:11 -05:00
8cdac4cac0
remove engine pointer passing ( #3556 )
...
* some
* more
* more
* the last?!
2021-11-16 04:15:29 -05:00
145316c497
less macro, more c++ ( #3549 )
...
* less macro
* s
2021-11-15 12:44:40 +01:00
675460fafb
Move fuel density to a header file so it can be accessed by other components. ( #3474 )
2021-11-05 22:29:56 -04:00
980a7cc833
autoscale fields in generated structs ( #3444 )
...
* add to grammar
* parser
* parser
* example consumer
* build config tool
* commit the right jar
2021-11-02 18:59:19 -04:00
25414ebdad
yet more pch ( #3068 )
...
* big pch energy
* put back ramdisk stub
* tests are happy
* h743 nucleo
* kinetis
* I love deleting code!
* make stepper happy
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-08-03 22:05:01 -04:00
b52d50bbf2
Use pch in lots of files ( #3066 )
...
* most engine.h
* most engine_configuration
* more
* more
* more
* more
* more
* moooooore
* ok I'm done for now
* oops
2021-07-26 01:05:17 -04:00
f6095b8339
fix nonlinear correction threshold ( #3060 )
...
* s
* macro
* test has to do the inverse
2021-07-25 20:42:26 -04:00
2ce7777865
don't require EXTERN_ENGINE in every file ( #2969 )
...
* move enginePins
* no more extern engine
* uses
* more
* extern config too
* put this where it belongs
* include correct header
* merge
2021-07-16 18:13:33 -04:00
d10ba3ddfa
injector nonlinearity ( #2916 )
...
* nonlinear polynomial
* make existing tests work again
* test that nonlinearity is called
* s
* fix enum
* ui
* fix and test
* comment
* changeloggy
2021-07-07 23:46:44 -04:00
526f1f97a0
Assorted todos ( #2762 )
...
* gpiochip todos
* fuel computer
* this was already done
2021-05-30 19:23:29 -04:00
a762853d3b
refactoring magic constant STOICH_RATIO
2021-05-20 02:39:20 -04:00
2328c1be6b
Fuel pressure sensor checks ( #2449 )
...
* test for missing sensor
* test negative pressure delta checking logic
* test new hasSensor logic
2021-03-12 23:32:41 -05:00
16b8fb64ca
vBatt -> SensorType::vBatt fix #2260
2021-03-11 23:07:18 -05:00
5067b81fce
Compute injection duration later in the pipeline ( #2175 )
...
* injector model, test
* new math
* inject fuel based on new math
* tests
* fix
* it should work like this
* format
* update TPS AE even when we're cutting fuel
* comment
* conversion factor
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-03-03 07:30:56 -05:00
4a1d3de9a6
remove unused msg parameter ( #2360 )
...
* dead parameter
* last few
2021-02-16 09:32:16 -05:00
eabb5c7366
flex fuel AFR interpolation ( #2190 )
...
* config
* implement flex
* secondary fuel default
* test
* test works
* rename
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-01-05 16:27:23 -05:00
92ea09b0a6
switch more map to read from sensor model ( #2162 )
...
* hook up map
* check for init
* switch some consumers
* that's the rest of them
* test
* tests
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-01-02 19:13:10 -05:00
02c4d630f6
compensate injector flow based on fuel pressure ( #1931 )
...
* injector compensation
* fix
* ui
* testability & comments
* hella testing
* debug channels
* enum value
* auto generated enums
* update comment
* oops too much
* update config fields
* handle failed pressure sensor
* build
* fix
* add some todos for the future
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-11-10 23:11:22 -05:00
15d5c872c2
log afr in addition to lambda ( #1920 )
...
* log afr
* log it
* weird double commas
2020-10-31 17:52:07 -04:00
09b41bb1bb
Everything in lambda! ( #1893 )
...
* lambda
* default configs, fix build
* config, gauge, UI
* more digits
* change menu text
* fix that while I'm here
* doesn't need extra word
* todo note
* tests
* last test
* missed a config
* update java
* store target lambda
* more java
* format
* hopefully enough java for CI to pass
2020-10-26 18:15:17 -04:00
a90792fa44
convert mass -> duration later in the pipeline ( #1906 )
...
* cranking duration to mass
* implement
* units
* patch types
* suppress warning
* fix output channels
* add note about how to set it
2020-10-26 07:23:13 -04:00
10c1ad7698
use fuel model ( #1901 )
...
* use fuel model
* spit'n'polish
2020-10-23 20:25:47 -04:00
83fe9dae77
ign mode overrides ( #1869 )
2020-10-09 17:16:49 -04:00
6d1acb40f8
Selectable AFR axis override ( #1771 )
...
* add config fields
* config options
* new output channels
* dump out state to ts
* s
* implement override
* enums
* this test is no longer used
* test new behavior
* old
* comments
* impl
* unhide option
* fix
* tests
2020-09-08 17:15:18 -04:00
ef0b2f7be0
Selectable VE axis override ( #1769 )
...
* add config fields
* config options
* new output channels
* dump out state to ts
* s
* implement override
* enums
* this test is no longer used
* test new behavior
* old
* comments
2020-09-07 10:15:42 -04:00
c53979a017
Configurable stoichiometric ratio ( #1710 )
...
* configurable stoich ratio
* afr table always in gas afr
* default
* typo
* use defined ratio
* do it in config too
* missed a spot
* oops wrong one
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-08-21 19:43:30 -04:00
33a2354e44
inject fuel & injector models so they can be mocked ( #1697 )
...
* stub injector model
* tests
* inject fuel/injector models
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-08-17 17:03:59 -04:00
5929164fb3
Add injector model class ( #1687 )
...
* stub injector model
* tests
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-08-17 05:22:25 -04:00
3c72fa93e4
fix
2020-08-10 21:53:45 -07:00
1d0a244fa4
add fuel computer
2020-08-10 21:40:19 -07:00
Andrey
rusefillc
GitHub gen-configs Action
rusefillc
Matthew Kennedy
Scott Smith
Matthew Kennedy