Commit Graph

40 Commits

Author SHA1 Message Date
kifir 1a56187c57 implement ignition cut for shift torque reduction #5608 2024-10-05 03:01:03 +03:00
Andrey c3bc395cf5 int rpm -> float rpm 2024-09-26 00:34:00 -04:00
Matthew Kennedy af2e425761 only:int rpm -> float rpm 2024-09-26 00:27:35 -04:00
kifir 373c8b35b4 support isLaunchPrecondition indicator (#6566) 2024-06-11 09:00:03 -06:00
kifir 455a30247b get rid of delay on activation launch mode - it looks like launchActivateDelay setting is always zero, because there is no way to configure this setting 2024-06-11 09:00:03 -06:00
kifir fdc60e4bff implement launch spark skip functionality (#6566) 2024-06-07 11:09:29 -04:00
kifir 3e4d1db28b now we use updateTargetSkipRatio method instead of setTargetSkipRatio (#6566) 2024-06-07 11:09:29 -04:00
kifir 6b2019adf2 light refactoring: encapsulate processing of `useHardSkipInTraction` setting in SoftSparkLimiter class (#6566) 2024-06-06 18:40:55 -04:00
kifir eda1a54047 light refactoring: forbid modification of SoftSparkLimiter::allowHardCut field (#6566) 2024-06-06 18:40:55 -04:00
kifir e60038f8ca now timing stays at the "ignition retard" after the end RPM for smooth timing retard #5611 2024-05-28 18:55:27 -04:00
kifir 6464d4dc7b fix smooth retard functionality #5611 2024-05-27 09:06:42 -04:00
kifir 9f053cf4b7 enhance hysterisis detection: now we use isAfterLaunch indicator on launch_control_state panel instead of hidden class field #5610 2024-05-21 13:29:49 -04:00
kifir af6786e237 implement hysterisis functionality for ignition and fuel cut #5610 2024-05-21 10:08:56 -04:00
kifir 8a4f53214b refactoring: LaunchControlBase::isInsideRPMCondition method returns bool again 2024-05-21 10:08:56 -04:00
kifir fee1602fd9 add tests for targetSkipRatio calculation #6528 2024-05-17 13:31:52 -04:00
Andrey 946bc82376 refactoring: LaunchCondition enum 2024-03-09 08:39:58 -05:00
Andrey 8f852fd4e7 only: typo? red flag that launch control coverage does not care 2024-02-29 22:33:37 -05:00
rusefi 78e48d3718 only:timer.h goes to libfirmware! 2023-08-30 23:11:24 -04:00
Andrey 4390320b6c setSparkSkipRatio limitation #5231 2023-05-25 12:41:11 -04:00
rusefi a17e12747e Add fuel adder to launch fix #4777 2022-11-13 20:23:19 -05:00
rusefillc 81759802d0 live data for wastegate and launch control #3588 2021-12-16 14:47:00 -05:00
rusefillc 877535b8ff proportional spark cut #3427 2021-11-17 23:35:26 -05:00
Scott Smith 69d36dad6e
Final cleanup of ENGINE macros (#3567)
Fix some uses of ENGINE() not detected by regex due to parenthesis.
Remove now empty engine_ptr.h
Don't worry about EFI_* not being defined, the compiler defaults to 0 if they aren't.
2021-11-17 13:45:10 -05:00
Scott Smith cc95bd6c8e
Programmatically remove EnginePtr/inject, EXPAND_Engine, and WITH_ENGINE_TEST_HELPER* (#3560)
* Programmatically remove EnginePtr/inject, EXPAND_Engine, and WITH_ENGINE_TEST_HELPER*

for i in ": public EnginePtr " ", public EnginePtr" "EXPAND_Engine;" "EXPAND_Engine"; do
    git grep -l "$i" | xargs sed -i "s/$i//g"
done

git grep -l "inject" | xargs sed -i "/inject[(][)]/d"

for i in WITH_ENGINE_TEST_HELPER_SENS WITH_ENGINE_TEST_HELPER_BOARD_CALLBACK WITH_ENGINE_TEST_HELPER; do
    git grep -l "$i" | xargs sed -i "s/$i/EngineTestHelper eth/g"
done

git checkout firmware/controllers/core/engine_ptr.h
git checkout unit_tests/global.h

* Review fixups.
2021-11-16 16:52:11 -05:00
Andrey a61043e570 proportional spark cut #3427 2021-11-16 13:23:08 -05:00
Matthew Kennedy 8cdac4cac0
remove engine pointer passing (#3556)
* some

* more

* more

* the last?!
2021-11-16 04:15:29 -05:00
Andrey 0cc88ec6e2 Not all launch control options are used #3554 2021-11-15 21:13:01 -05:00
Andrey 928c673695 refactoring launch 2021-11-15 20:09:03 -05:00
Andrey 05fa6071dd refactoring launch 2021-11-15 19:55:04 -05:00
Andrey 4002c92dcc refactoring launch 2021-11-15 18:57:12 -05:00
Andrey 34015eceee refactoring launch 2021-11-15 14:40:35 -05:00
Matthew Kennedy 145316c497
less macro, more c++ (#3549)
* less macro

* s
2021-11-15 12:44:40 +01:00
Matthew Kennedy bd1c84fa62
Logging remove 3 (#2568)
* ts logger

* sensors

* wideband too

* missed one

* init

* motors, pid, etc

* vvt

* more

* idle

* missed one

* dynoview

* launch

* can

* console IO

* s

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-04-20 14:09:41 -04:00
shadowm60 6fb745d29c
Launch Control refactoring (#1992)
* refactor

- called from periodicFastCallback
- removed defines

* Update rusefi.input

removed unused configurations.
added clutch inversion option

* Added new tests

fixed limiting only in case we have launch condition and rpm outside of window

* Update launch_control.cpp

Unintialized config update, now it is working fine with VSS and with clutch as well.

* small fixes

updated after review findings

* Fix breaking engine rev limiter

applyLaunchControlLimiting should not overwrite booleans to false!

* Delay timer in seconds

timer uses ms, so convert seconds to ms
2020-12-01 13:03:42 -05:00
Matthew Kennedy d48367d565
timer (#1994) 2020-11-30 19:35:06 -05:00
shadowm60 7c793834ef
Launch control unit tests update (#1972)
* testable launch start

* extract base class

* add a test

* fix ts debug

* Launch control unit_tests

updated launch control for a better split
VSS mock for unit tests

Co-authored-by: Matthew Kennedy <matthewkennedy@outlook.com>
2020-11-19 21:14:38 -05:00
Matthew Kennedy ee51da64ad
Launch control testable (#1967)
* testable launch start

* extract base class

* add a test

* fix ts debug
2020-11-19 08:15:56 -05:00
shadowm60 8d8e8ec260
Launch control - experimental (#1816)
* Update tachometer.cpp

Initial implementation of E30 M3 Tach output solution #907, unit_test plus debugging next

* tacho unit tests

First successfull unit test for tachometer

* RAM adjustment so it would link

* refactoring tacho, broken!

* starting to make some progress...still fails after a few seconds

* Rework with SW PWM

* Update after code review

* unit_test update

* First working unit_test

* Update .gitignore

* Update engine_controller.cpp

* Update engine_controller.cpp

* Update tachometer.h

* Update test_tacho.cpp

* Switched UART DMA on

* Revert "Switched UART DMA on"

This reverts commit 4a23974c431e0e7fd760595d2161e74e6854897e.

* enable launch control

make use of already existent code + integration

* Delete compile_frankenso_all.sh

remove it since it is not part of the project

* Update main_trigger_callback.cpp

broke unit_Tests

Co-authored-by: rusefi <rusefi@users.noreply.github.com>
2020-09-22 16:25:27 -04:00
rusefi 5dce6e7104 launch control #203
somewhat questionable code
2020-03-23 23:20:54 -04:00
rusefi 43440afade launch control #203 2020-03-23 20:44:34 -04:00