Scott Smith
dac67235c4
Don't keep a separate MultiChannelStateSequence for the trigger emulator, version 2. ( #3517 )
...
All it wants is to use the main trigger state, so don't bother copying it. Instead, change
PwmConfig to take a const pointer to a Multi.*Sequence, then make all the users adapt. Worse
fallout is that SimplePwm now has its own Multi.*Sequence, but PwmConfig is downgraded to a
pointer, so that's only a net +4 bytes. And we can make the overhead of Multi.*Sequence much lower
using embedded arrays, which only the caller can do since it knows the maximum size... (for another
day...)
Also remove SimplePwm's 2nd copy of SingleChannelStateSequence. It served no purpose.
Saves 1992 bytes of BSS and 24 bytes of RAM4 (latter probably due to SimplePwm change)
2021-11-10 07:01:20 -05:00
rusefillc
1db9a02f1d
Revert "Don't keep a separate MultiChannelStateSequence for the trigger emulator. ( #3513 )"
...
This reverts commit 280dfa94e7
.
2021-11-09 20:42:23 -05:00
Scott Smith
280dfa94e7
Don't keep a separate MultiChannelStateSequence for the trigger emulator. ( #3513 )
...
All it wants is to use the main trigger state, so don't bother copying it. Instead, change
PwmConfig to take a const pointer to a Multi.*Sequence, then make all the users adapt. Worse
fallout is that SimplePwm now has its own Multi.*Sequence, but PwmConfig is downgraded to a
pointer, so that's only a net +4 bytes. And we can make the overhead of Multi.*Sequence much lower
using embedded arrays, which only the caller can do since it knows the maximum size... (for another
day...)
Also remove SimplePwm's 2nd copy of SingleChannelStateSequence. It served no purpose.
Saves 1992 bytes of BSS and 24 bytes of RAM4 (latter probably due to SimplePwm change)
2021-11-09 14:35:07 -05:00
Scott Smith
158f719d95
Save ~2800 bytes of RAM by not caching angle->trigger mapping ( #3506 )
...
Memory seems more valuable than CPU; use the O(lg n) lookup by angle. A side effect is that it
seems to fix trigger lookup for the second phase of TRIGGERTYPE 53 544 TT_TRI _TACH 0.00
2021-11-09 07:03:27 -05:00
Andrey
9ac1575777
reducing complexity
2021-11-07 01:57:32 -05:00
rusefillc
5de6c2a270
typo
2021-11-07 01:51:05 -05:00
rusefillc
20784db801
refactoring - magic constant bad
...
cypress and kinetis both have this macro already
2021-11-07 01:34:16 -04:00
rusefillc
0af09f596c
refactoring - magic constant bad
...
cypress and kinetis both have this macro already
2021-11-07 01:28:28 -04:00
rusefillc
656b8c3429
refactoring - magic constant bad
2021-11-07 00:03:16 -04:00
Matthew Kennedy
036c1b17d3
make master happy ( #3467 )
2021-11-05 16:01:13 -04:00
Matthew Kennedy
2b9696442e
nissan MR18DE VVT cam pattern ( #3466 )
...
* refactoring nissan trigger
* comments
* plumbing
* b
* enums
* image
* image
* implement decoder
* reshuffle
* don't case unused
* dead trigger enums
2021-11-05 15:33:22 -04:00
Matthew Kennedy
365691cb37
nissan 4yl crank pattern ( #3462 )
...
* refactoring nissan trigger
* comments
* plumbing
* b
2021-11-05 07:15:03 -04:00
Andrey
61777564d4
Honda K cam wheels #3405
2021-10-30 21:09:58 -04:00
Andrey
a6a969390f
Honda K cam wheels #3405
2021-10-28 19:26:59 -04:00
Andrey
de350131e6
Honda K cam wheels #3405
2021-10-28 11:40:31 -04:00
Andrey
484d078752
Honda K cam wheels #3405
2021-10-26 22:47:19 -04:00
rusefi
30f9c57f70
Honda K cam wheels #3405
2021-10-26 17:29:26 -04:00
rusefillc
4ef959a60e
generate java enum from C enum? generate both C and java from yaml? #2102
2021-10-25 11:05:45 -04:00
Andrey
229419d04b
Honda K cam wheels #3405
2021-10-24 17:12:19 -04:00
rusefillc
eb05f4594e
very old very dead code
2021-10-20 12:57:07 -04:00
rusefillc
8a2472126a
https://rusefi.com/forum/viewtopic.php?f=5&t=2143 Suzuki G13B tooth pattern
2021-10-04 19:59:51 -04:00
Andrey
b0ae87054a
https://rusefi.com/forum/viewtopic.php?f=5&t=2143 Suzuki G13B tooth pattern
2021-10-04 19:29:58 -04:00
rusefillc
eccdf18eec
https://rusefi.com/forum/viewtopic.php?f=5&t=2143 Suzuki G13B tooth pattern
2021-10-04 11:25:27 -04:00
rusefillc
58cd414c0a
miata NB1 is a weird half-VR/half-Hall sensor
2021-09-29 14:31:36 -04:00
Matthew Kennedy
35e1a7cc0c
fix ( #3253 )
2021-09-21 00:27:14 -04:00
rusefillc
7fc88fa304
https://rusefi.com/forum/viewtopic.php?f=5&t=2117
2021-09-12 13:58:03 -04:00
Andrey
301f5e7ec4
https://rusefi.com/forum/viewtopic.php?f=5&t=2117
2021-09-12 11:56:12 -04:00
rusefi
83c0372729
https://rusefi.com/forum/viewtopic.php?f=5&t=2117
...
Ford TFI PIP
2021-09-11 23:42:05 -04:00
rusefi
48c516f9f7
https://rusefi.com/forum/viewtopic.php?f=5&t=2117
...
Ford TFI PIP
2021-09-11 23:16:22 -04:00
Matthew Kennedy
c72bd07179
enable address sanitizer ( #3217 )
...
* enable asan
* lua
* this is dead and leaky
* leaky nissan
* fix pwm generator use-after-stack
* initializers
* prevent problems in case of invalid trigger shape
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-09-05 05:56:59 -04:00
Andrey G
39664d98a0
Subaru svx trigger update (not vvt) ( #3210 )
...
* trigger: subaru: SVX: some comments
* trigger: subaru: svx: fix crank 2 offset
* trigger: subaru: svx: rework a bit
* trigger: subaru: svx: fix dtc position
2021-09-04 11:42:12 -04:00
rusefillc
526340de78
Subaru svx vvt #3210
...
helping or not
2021-08-31 06:05:57 -04:00
rusefillc
1a1b7f95c0
Subaru svx vvt #3210
...
helping or not
2021-08-31 05:54:04 -04:00
rusefillc
6ea76921f4
docs
2021-08-31 04:27:31 -04:00
rusefillc
3d4ff9083b
Pavel says there are issues
2021-08-11 04:16:51 -04:00
Andrey
08dff4ceb6
Nissan 4 cylinder QR trigger wheel #3118
2021-08-08 06:16:19 -04:00
Andrey
167f2dbba0
Nissan 4 cylinder QR trigger wheel #3118
2021-08-08 04:56:56 -04:00
Andrey
a2d18fa0b7
Nissan 4 cylinder QR trigger wheel #3118
2021-08-08 04:45:40 -04:00
Matthew Kennedy
b52d50bbf2
Use pch in lots of files ( #3066 )
...
* most engine.h
* most engine_configuration
* more
* more
* more
* more
* more
* moooooore
* ok I'm done for now
* oops
2021-07-26 01:05:17 -04:00
rusefillc
23842bf143
safer NB2 progress ( #3041 )
...
* safer NB2 progress
* one step back
2021-07-23 16:43:24 -04:00
Matthew Kennedy
d520d12490
adjust nb2 vvt sync ( #3019 )
...
* test existing implementation
* nb2 vvt pattern sync
* update test
2021-07-21 20:07:28 -04:00
Matthew Kennedy
5f3464b204
Fix prepareEventAngles for symmetrical crank triggers ( #2982 )
...
* fix and make code legible
* update test to check every tooth
* symmetrical crank
* simplify findTriggerPosition
* make getAngle intelligable
2021-07-17 23:27:20 -04:00
Andrey
9345e5d2e0
NB2 trigger shape does not seem to match JimStim #2980
...
only first steps of unit test
2021-07-17 17:47:32 -04:00
rusefillc
6da3310d97
kaiju is asking for vq30de trigger wheel decoder #2974
2021-07-17 02:03:55 -04:00
Andrey
180d7bc899
kaiju is asking for vq30de trigger wheel decoder #2974
2021-07-17 01:10:13 -04:00
Andrey
ffe2fe3271
refactoring
2021-07-17 00:56:50 -04:00
Andrey
d583c91a7a
refactoring
2021-07-17 00:53:51 -04:00
Andrey
d16d6dd58d
kaiju is asking for vq30de trigger wheel decoder #2974
2021-07-17 00:46:39 -04:00
Andrey
f54b3cd1b2
refactoring
2021-07-17 00:46:39 -04:00
Andrey
df558303d3
kaiju is asking for vq30de trigger wheel decoder #2974
2021-07-17 00:27:56 -04:00