Matthew Kennedy
28fd3c59ac
remove wrapAngle2, wrapAngle does fine
2023-10-19 22:53:09 -04:00
Andrey
a6103dca56
tooth-event angle cannot be negative
2023-10-06 12:21:55 -04:00
rusefi
0099de49af
ignition timing clamping settings
2023-07-22 00:07:15 -04:00
rusefi
4fbc9d7b06
ignition timing clamping settings
...
only:atomic change around timing range
2023-07-21 23:48:58 -04:00
rusefillc
800752d389
per-cylinder logging fix: using better sign
2023-05-31 17:44:33 -04:00
rusefillc
ed18cb1a53
it's going to be...
2023-05-31 17:36:12 -04:00
rusefillc
c15ab187c5
it's going to be p
2023-05-31 17:23:46 -04:00
rusefillc
91d08f0465
it's going to be p
2023-05-31 17:15:43 -04:00
Matthew Kennedy
12a29232cc
tooth_logger.h -> pch
...
(cherry picked from commit ad3ea57276361b6da69eb920dd056a662f6f5c70)
2023-05-31 15:59:02 -04:00
Andrey
902c61f9d8
setSparkSkipRatio limitation #5231
2023-05-25 13:26:17 -04:00
Matthew Kennedy
40673ffda2
add ignition/injection mode output channel #85
...
(cherry picked from commit 9621ff844eea704421dc6172d66a2f4053467277)
2023-05-04 18:58:50 -04:00
Matthew Kennedy
d897a96c05
is this just dead?
...
(cherry picked from commit cd6b770945aa56ae52e188476034a862cba47bb0)
2023-04-29 01:08:14 -04:00
Andrey
51d0f6e347
it's going to be painful
2023-04-29 00:44:00 -04:00
Andrey
f296e30fb5
it's going to be painful
2023-04-28 21:01:08 -04:00
Matthew Kennedy
d488ed5858
function >>> macro
...
(cherry picked from commit 489d016682d1c3eb4eb707cd1686686e40175dcd)
2023-04-28 20:27:12 -04:00
Andrey
b95353cc12
logging of live data structs was: data points, we are moving away from debug mode #3614
2023-04-12 17:31:00 -04:00
Andrey
0470953cb8
We need to reshuffle timing calculation a bit, add one more gauge #5235
2023-04-12 17:22:28 -04:00
Andrey
32b7b014c9
per-cylinder should not contain firingOrderOffset fix #5236
2023-04-12 15:18:29 -04:00
Andrey
588bf77492
wow we have two separate per-cylinder trims?! fix #5237
...
refactoring: bringing two offsets much closer together, no change in overall logic
2023-04-12 15:04:14 -04:00
rusefillc
deaee9ceae
Ignition Knock response logging progress
2023-04-11 10:54:10 -04:00
Andreika
919ed2d934
RPM soft limit and hysteresis #5214 , #5224 ( #5228 )
...
* [DRAFT] RPM soft limit and hysteresis #5214 , #5224
* fix m_timingRetard
* fix rpmHardLimitHyst
* unit-tests for #5214 , #5224
2023-04-10 17:18:51 -04:00
Andrey
1c7a800d7b
https://github.com/rusefi/rusefi/pull/5040
...
only:mre_f4
2023-02-24 22:48:33 -05:00
Andrey
6588e813ae
totalFuel and totalIgnition correction gauges in Tunerstudio #4955
2023-01-15 08:26:38 -05:00
Andrey
9abdab795d
totalFuel and totalIgnition correction gauges in Tunerstudio #4955
2023-01-14 23:21:23 -05:00
Matthew Kennedy
d5b00e1187
don't warn if we intentionally skipped this spark ( #4961 )
...
* don't warn if we intentionally skipped this spark
* header
* real nb2
2023-01-10 19:07:44 -05:00
rusefillc
0300376c84
CI is useful
2023-01-01 11:30:50 -05:00
rusefillc
6146b01a36
antilag and anti-lag #2403
...
TurboMarian is the ALS boss
2022-12-21 20:12:00 -05:00
Matthew Kennedy
769cdd32ca
TriggerScheduler cleanup ( #4844 )
...
* TriggerScheduler cleanup
* remove TRIGGER_EVENT_UNDEFINED
* remove dead overload of scheduleOrQueue
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2022-11-28 08:55:38 -05:00
Andrey G
e7b06cbfca
compile warnings: signed vs unsigned and unused ( #4713 )
2022-10-30 09:47:53 -04:00
Matthew Kennedy
940e0dc369
require ignition on for firing ( #4628 )
...
* require ignition on for firing
* too much havoc for a unit test
* patch up references
* last one
* fix changelog mangling
* fix the changelog template too
* bad merge
* fix the template again
* s
* fake battery voltage on hw ci
* ugh merge
* ugh merge
2022-10-04 20:36:03 -04:00
Matthew Kennedy
b089825a4a
schedule ignition charge by angle instead of tooth ( #4513 )
...
* schedule ignition charge by angle
* same mistake as #4536
* s
* wrap sparkAngle too
* AngleBasedEventNew
* function moved
* implement scheduleOrQueue
* prints
2022-09-25 11:00:55 -04:00
Matthew Kennedy
dfe1b47b4d
remove ignitionPin ( #4608 )
...
* remove ignitionPin
* now that's gone
* BMW test
2022-09-23 17:30:10 -04:00
Matthew Kennedy
a9cc3223dc
plumbing for 4513 ( #4599 )
...
* plumbing for 4513
* not static
2022-09-20 06:19:51 -04:00
Matthew Kennedy
3a57c41c1b
add fuel/spark cut codes to TS indicators ( #4592 )
...
* add fuel/spark cut codes to TS indicators
* fix list
* only set clearReason if not cleared
2022-09-19 22:01:03 -04:00
rusefillc
d9733199c1
"angle range findAngle#a6" critical error #4593
2022-09-19 18:33:19 -04:00
Andrey
82cda62bac
inline method to reduce confusion
2022-09-14 01:34:52 -04:00
rusefillc
e733782920
i suspect that no one cares about these
2022-09-14 00:34:04 -04:00
Andrey
197454ac34
tear down Engine god object #4511
...
just trying different things
2022-09-07 15:38:15 -04:00
Andrey
e240ac84d3
refactoring: reducing outputChannels copy
2022-09-01 01:06:49 -04:00
Andrey
9f4f85a097
let spark deal with spark limpManager
2022-08-31 23:59:40 -04:00
Andrey
cecc5a9d6e
https://github.com/rusefi/hellen154hyundai/issues/60
...
extra logging
2022-08-25 19:58:10 -04:00
Matthew Kennedy
16de438ab8
knock threshold table fix ( #4077 )
...
* fix knock threshold table
* defaults
* knock controller is engine module
* testable
* test builds
* knock tests work
* s
* format
* everyone loves changelogs
2022-04-18 08:03:16 -04:00
Matthew Kennedy
497e7ffe77
allow setting injection phase by start or center of injection ( #4068 )
...
* allow SOI/COI
* other change
* renames and simplify
* clean up ownIndex
* double check in spark logic
2022-04-15 10:22:36 -04:00
Matthew Kennedy
41ab294281
fix sequential mode cranking ( #2919 )
...
* fix
* use the right enum
* do it for fuel too
* earlier
* s
2022-02-01 19:04:20 -05:00
Andrey
cda2b711cf
migrating to SensorType::Rpm API
2022-01-20 23:32:59 -05:00
Andrey
940b04ab24
Let's always have TS structure so that unit tests can check values in outputChannels, kind of making outputChannels a god dump for state but whatever since Live View is coming
2021-12-07 20:18:47 -05:00
Matthew Kennedy
3a95e86112
calculate per-cylinder ignition timing ( #3652 )
...
* simplify cylinder phasing
* per cylinder timing
* s
* s
* s
* why was there a divide by 2?
2021-12-06 21:19:37 -05:00
Matthew Kennedy
555a8d5f43
simplify cylinder phasing ( #3650 )
2021-12-05 10:46:35 -05:00
Scott Smith
18c27a6e9c
Separate out scheduleOrQueue into it's own standalone scheduler. ( #3573 )
...
It's a large enough entity that it shouldn't be buried in ignition logic.
2021-11-18 14:27:21 -05:00
Scott Smith
ba8bd0a704
Add a lock for scheduleOrQueue events. ( #3572 )
...
Ignition callers are all tooth based, but aux valves calls it from both the microsecond timer and
the main initialization thread. HPFP will also soon call it from both those places too.
2021-11-18 05:08:32 +03:00