a5136a0eae
trigger refactoring: instance RPM #4740
2022-11-06 11:05:57 -05:00
53d3c4a529
minor trigger refactoring
2022-11-06 01:32:59 -04:00
e3fd84ed08
minor trigger refactoring
2022-11-06 00:32:38 -04:00
cd77afe464
minor fix: will be invoked downstream
2022-11-05 23:58:05 -04:00
2866ba54b8
minor fix: no need to assign same value twice
2022-11-05 23:50:03 -04:00
b57bf2903a
minor trigger refactoring
2022-11-05 21:43:12 -04:00
e7b06cbfca
compile warnings: signed vs unsigned and unused ( #4713 )
2022-10-30 09:47:53 -04:00
983f88709a
progress: allow only exhaust cam input now that we have index parameter
2022-10-22 08:40:36 -04:00
da0fa03f0a
refactoring: wider usage of helper method
2022-10-22 08:39:55 -04:00
aa881efe89
fix 36-2-1 trigger ( #4645 )
...
* fix
* test files
* test real 4b11
* test.mk
* better angle error math
* test GM too
* changelog
2022-10-09 21:22:05 -04:00
6a99469c8a
// todo: what is broken _exactly_? ( #4531 )
...
* // todo: what is broken _exactly_?
* hold on, why "float autoscale" at all here?
Co-authored-by: rusefillc <sdfsdfqsf2334234234>
2022-10-08 23:13:14 -04:00
940e0dc369
require ignition on for firing ( #4628 )
...
* require ignition on for firing
* too much havoc for a unit test
* patch up references
* last one
* fix changelog mangling
* fix the changelog template too
* bad merge
* fix the template again
* s
* fake battery voltage on hw ci
* ugh merge
* ugh merge
2022-10-04 20:36:03 -04:00
57c804c6f5
there is no third trigger simulator channel right?
2022-10-03 00:18:11 -04:00
ca623eb6ee
plumbing parts of 4621 ( #4622 )
...
* plumbing parts of 4621
* show error list
* exit on error too!
* this test has some unhealthy undefined behavior
* no uninitialized values
* no that doesn't work
* remove the invalid data and the bug becomes obvious
2022-09-25 18:49:54 -04:00
9d27780974
Honda K cam wheels #3405
2022-09-24 23:49:41 -04:00
61cfff1e9e
K progress - just a rename
2022-09-24 23:25:36 -04:00
cff779dd78
K progress
2022-09-24 23:18:57 -04:00
dd41cf0a05
log tooth angle difference ( #4613 )
2022-09-23 23:49:28 -04:00
7139ddcda2
explicitly pass which edges we sync trigger on ( #4607 )
...
* require sync edge type
* s
* fix neon
* info printing
* put enums back
* auto gen enum fiddling
2022-09-23 20:39:41 -04:00
efb232223f
moving acceleration around
2022-09-16 00:06:57 -04:00
3104538022
just a rename & hiding unit test method
2022-09-15 23:07:08 -04:00
50cef9a201
tear down Engine god object #4511
2022-09-15 22:12:49 -04:00
85b170f84e
dead idea
2022-09-15 14:55:32 -04:00
0c87bb7260
deep rabbit holes are the best ones!
...
refactoring: encapsulation
2022-09-14 02:45:31 -04:00
0e91914266
deep rabbit holes are the best ones!
...
refactoring: encapsulation
2022-09-14 02:35:55 -04:00
663c39afdc
deep rabbit holes are the best ones!
...
refactoring: encapsulation
2022-09-14 02:24:41 -04:00
2c0ce0ec7d
deep rabbit holes are the best ones!
...
refactoring: encapsulation
2022-09-14 02:17:04 -04:00
12d857b99c
deep rabbit holes are the best ones!
...
refactoring: encapsulation
2022-09-14 02:06:52 -04:00
6cdb0dc0af
deep rabbit holes are the best ones!
...
refactoring: encapsulation
2022-09-14 01:53:17 -04:00
82cda62bac
inline method to reduce confusion
2022-09-14 01:34:52 -04:00
2a05a31550
refactoring: type safety
2022-09-11 03:46:50 -04:00
851e8e48d3
refactoring: type safety
2022-09-11 02:57:35 -04:00
cfb843b315
send more of Engine Sniffer data #4560
...
hello Kinetis it has been a while!
2022-09-11 00:18:08 -04:00
7b4a5c9be6
vvtBooleanForVerySpecialCases, tempBooleanForVerySpecialLogic
2022-09-09 17:52:54 -04:00
72299bd1ba
only report vvt position if we have full sync ( #4547 )
...
* only report vvt position if we have full sync
* comments
* make it selectable, since that makes the test useful
2022-09-08 16:15:36 -04:00
8e49542600
trigger: in corner cases like NB2 and VQ35 those are not revolutions
2022-09-07 22:24:28 -04:00
ab4b451195
os_access.h dead?
2022-09-07 15:56:45 -04:00
c1b218b772
refactoring: let's use different names for different things
2022-09-05 01:16:24 -04:00
c28c876357
todo: what is broken _exactly_?
2022-09-03 06:55:47 -04:00
5941ad8fb7
smaller step forward
2022-09-01 10:06:00 -04:00
1d1fd2da43
Revert "smaller step forward"
...
This reverts commit f0e6bcc279
2022-09-01 09:10:11 -04:00
e1b3c3380f
Revert "smaller step forward"
...
This reverts commit f388163d2a
2022-09-01 09:10:07 -04:00
f388163d2a
smaller step forward
2022-09-01 08:51:13 -04:00
f0e6bcc279
smaller step forward
2022-09-01 08:44:46 -04:00
ce5e618e3f
smaller step forward
2022-09-01 01:08:51 -04:00
9e14073feb
c63fb29aaf partial rollback
2022-09-01 00:46:54 -04:00
da66fa055c
refactoring: enum name clean-up
2022-09-01 00:23:33 -04:00
c63fb29aaf
refactoring: reducing outputChannels copy
2022-09-01 00:13:55 -04:00
28d797d5c2
moving confusion further away from fuel control
2022-08-31 23:59:40 -04:00
6d3a6dc2f8
readability
2022-08-31 23:29:47 -04:00
ca4936d3fe
rename and fix skyactiv cam mode ( #4505 )
2022-08-31 22:12:45 -04:00
b7490590a2
TT_VVT_MAZDA_MYSTERY
2022-08-28 23:01:38 -04:00
76f5832db9
resolve VVT phase using every tooth, not just sync point ( #4434 )
...
* resolve VVT phase using every tooth, not just sync point
* fix tests
* comment
* changelog
2022-08-12 08:08:23 -04:00
e9d092f975
big delete ICU ( #4270 )
...
* big delete
* icu vestiges
* changelog
2022-07-07 15:27:59 -04:00
c0f290b922
Injector scheduled by angle, not tooth index ( #4208 )
...
* trigger decoder returns a result
* TriggerFormDetails
* s
* don't reach out and touch the engine
* injection doesn't care about teeth
* fix up existing tests
* oh look, we can actually test this logic now without trying to depend on trigger shape!!!
* fix a real bug
* simplify
2022-06-24 17:43:23 -04:00
fcd3d991ee
trigger tweaks cleanup ( #4278 )
...
* simplify some math
* we say yes to the todo
* and put back that test
* test
2022-06-23 23:11:29 -04:00
dacc43acad
verbose trigger sync should reuse engineSnifferRpmThreshold #4259
...
docs
2022-06-18 14:44:21 -04:00
a552d58d42
verbose trigger sync should reuse engineSnifferRpmThreshold #4259
...
reducing complexity
2022-06-18 14:17:36 -04:00
6c1d2a297e
more into "triggerinfo"
2022-06-17 22:10:48 -04:00
4ada633206
Remove third trigger channel ( #4226 )
...
* remove third trigger
* clean up the honda mess
* there was nothing novel about this engine config
* include
* missed a few
* s
* x
* changelog
* don't set the third trigger input
* don't redefine the same thing 3 times
* only two inputs!
* test
2022-06-01 21:24:20 -04:00
c0d8cbfef4
Trigger cleanup init ( #4222 )
...
* extra parameter
* name decoders in constructor
* s
2022-06-01 00:55:34 -04:00
70c2689f1e
remove trigger duty cycle calculation ( #4213 )
...
* This field was ignored.
* move pad out
* gone
* make trigger configuration a little clearer
* even simpler!
* format
* test fix
* remove duty cycle thing
2022-05-30 22:39:57 -04:00
d5a4804993
remove dead useOnlyFirstChannel ( #4211 )
...
* This field was ignored.
* move pad out
* gone
2022-05-30 07:03:40 -04:00
66fffee321
More trigger encapsulation ( #4207 )
...
* trigger decoder returns a result
* TriggerFormDetails
* s
* don't reach out and touch the engine
2022-05-29 13:49:00 -04:00
e8be471b46
bail from trigger_central ( #4210 )
2022-05-29 10:42:08 -04:00
720c463ffb
trigger decoder returns a result ( #4206 )
2022-05-28 09:01:45 -04:00
fe77f5127e
12 tooth crank mode ( #4179 )
...
* 12 tooth crank
* comment
* s
* rusefi config
2022-05-17 21:38:24 -04:00
170d574a5d
move logic in to trigger decoder ( #4162 )
...
* move logic in to trigger decoder
* status loop
* minor cleanup
* s
2022-05-10 23:55:28 +03:00
d4509cab8a
TriggerState -> TriggerDecoder ( #4157 )
2022-05-10 11:41:39 +03:00
5eb5b7cfbb
phase resolution rpm limit ( #4156 )
2022-05-10 07:22:50 +03:00
7f5672aaec
encapsulate stuff properly ( #4154 )
2022-05-09 15:46:36 -04:00
bd8459875d
refactoring: bringing method names up to date
2022-05-08 09:04:27 -04:00
bd9639b91d
Remove value copy from controller into outputChannels #4095
2022-05-08 08:50:27 -04:00
e4a0979dc2
Brain pin is enum class ( #4108 )
...
* change most usages to Gpio::
* board configs
* engine configs etc
* isBrainPinValid, smart gpio
* generator
* generator
* generator
* connector yamls
* kinetis enums
* cypress txt
* kinetis config
* frankenso
* config generator
* actually do it for the others
* disable skips for pr ci
* fix tle8888
* misc
* weird cast from int
* needs this operator too
* this can be an unsigned subtract
* happy tests
* s
* kinetis isConfigurationChanged weirdness
* missed J/K
* cypress efifeatures
* build script mistake (!)
* mistake in smart gpio
* debounce
* eg33
* kinetis, so needy
* it's pretty green, we can skip these again
2022-04-28 17:32:39 -04:00
838e8d8ddb
Remove value copy from controller into outputChannels #4095
2022-04-23 19:53:05 -04:00
71275e841b
m_hasSynchronizedSymmetrical handling improvements #4099 ( #4101 )
2022-04-23 19:45:29 -04:00
b9769f59cc
i will confess: i need to fit a debug build into discovery
2022-04-16 17:24:31 -04:00
204ac3961b
Trigger setup in TS is highly confusing: hide operation mode from users? #4031
...
WOW it works?!
2022-04-03 02:30:43 -04:00
c2a97343f2
Trigger setup in TS is highly confusing: hide operation mode from users? #4031
2022-04-03 01:11:53 -04:00
6b5747d4c8
refactoring: method rename
2022-04-02 21:01:29 -04:00
b1de262520
toothed previous time #4019
2022-03-21 20:41:09 -04:00
084a582775
Mitsubishi 3A92 Support - 3 cylinder #4011
2022-03-19 22:24:50 -04:00
625af513fb
Mitsubishi 3A92 Support - 3 cylinder #4011
2022-03-19 22:11:51 -04:00
1d64929f33
Remove Miata MX5 NB1 trigger fix #3488
2022-01-31 18:20:43 -05:00
21c2a2f7a9
Bosch Quick Start on B6 Passat is confused about phase #3812
...
running engine proved VVT_BOSCH_QUICK_START to match VVT_SECOND_HALF thus hard-coding phase choice
2022-01-19 01:30:16 -05:00
046f26508a
Bosch Quick Start on B6 Passat is confused about phase #3812
...
OMG :( we were totally not using VVT info of VVT_BOSCH_QUICK_START and VVT_NISSAN_MR and etc etc
2022-01-19 00:48:39 -05:00
577b9ccb06
refactoring: reusing existing flag instead of switch which refers to same thing
2022-01-19 00:48:39 -05:00
860f2f96f9
docs
2021-12-29 16:18:21 -05:00
c3b712aa3b
remove vvtSyncTimeNt ( #3722 )
...
* s
* poke
* poke again for science
* kick for science
* kick
* kick
* comment kick
* s
* don't try to compare the array decay pointer to 0 (!)
* collateral damage
* adjust miata sync
* reset trigger states correctly on engine stop
* s
* check synchronized bit
* now we don't need it at all?!
* and *NOT* synced
* start VVT sync earlier
2021-12-28 00:00:26 -05:00
95ad75318d
improved noFiringUntilVvtSync logic ( #3696 )
...
* s
* poke
* poke again for science
* kick for science
* kick
* kick
* comment kick
* s
* don't try to compare the array decay pointer to 0 (!)
* collateral damage
* adjust miata sync
* reset trigger states correctly on engine stop
* s
* nissan MR too
2021-12-27 12:09:38 -05:00
099f7d5a86
MAP phase sensing #3544
...
limiting to below cranking RPM limit
2021-12-11 02:56:19 -05:00
6de8364895
maybe more working MAP sampling ( #3689 )
...
* what if we do this
* cleanup
* s
* test
2021-12-11 03:01:28 -04:00
17879ef7de
MAP phase sensing #3544
2021-12-09 22:16:42 -05:00
f44370a5b8
MAP phase sensing #3544
...
gauge name fix
2021-12-08 12:44:43 -05:00
3a00fc4767
MAP phase sensing #3544
...
new implementation seems complete? 360 fix
2021-12-07 21:37:33 -05:00
50038167d8
MAP phase sensing #3544
...
new implementation seems complete?
2021-12-07 21:08:25 -05:00
940b04ab24
Let's always have TS structure so that unit tests can check values in outputChannels, kind of making outputChannels a god dump for state but whatever since Live View is coming
2021-12-07 20:18:47 -05:00
e72d57438a
MAP phase sensing #3544
...
new implementation
2021-12-07 20:00:04 -05:00
f826fe13aa
MAP phase sensing #3544
...
trigger sync better gauges/logging
2021-12-06 17:04:05 -05:00
25beb610b0
log actual tooth angle ( #3646 )
2021-12-02 19:22:33 -05:00
Andrey
Andrey G
rusefillc
Matthew Kennedy
rusefillc