allow settle from token page

components/account/AccountTabs.tsx

@@ -76,8 +76,6 @@ const AccountTabs = () => {
 }
 
 const TabContent = ({ activeTab }: { activeTab: string }) => {
-  const unsettledSpotBalances = useUnsettledSpotBalances()
-  const unsettledPerpPositions = useUnsettledPerpPositions()
   switch (activeTab) {
     case 'overview':
       return <AccountOverview />
@@ -88,12 +86,7 @@ const TabContent = ({ activeTab }: { activeTab: string }) => {
     case 'trade:orders':
       return <AccountOrders />
     case 'trade:unsettled':
-      return (
-        <UnsettledTrades
-          unsettledSpotBalances={unsettledSpotBalances}
-          unsettledPerpPositions={unsettledPerpPositions}
-        />
-      )
+      return <UnsettledTrades />
     case 'history':
       return <HistoryTabs />
     default:

components/token/ActionPanel.tsx

@@ -1,8 +1,10 @@
 import { Bank } from '@blockworks-foundation/mango-v4'
 import DepositWithdrawModal from '@components/modals/DepositWithdrawModal'
-import Button from '@components/shared/Button'
+import Button, { LinkButton } from '@components/shared/Button'
 import FormatNumericValue from '@components/shared/FormatNumericValue'
+import Modal from '@components/shared/Modal'
 import Tooltip from '@components/shared/Tooltip'
+import UnsettledTrades from '@components/trade/UnsettledTrades'
 import { ArrowDownTrayIcon, ArrowUpTrayIcon } from '@heroicons/react/20/solid'
 import mangoStore from '@store/mangoStore'
 import useAccountInterest from 'hooks/useAccountInterest'
@@ -11,6 +13,8 @@ import useMangoAccount from 'hooks/useMangoAccount'
 import useUnsettledPerpPositions from 'hooks/useUnsettledPerpPositions'
 import { useTranslation } from 'next-i18next'
 import { useMemo, useState } from 'react'
+import { ModalProps } from 'types/modal'
+import { formatCurrencyValue } from 'utils/numbers'
 
 const ActionPanel = ({ bank }: { bank: Bank }) => {
   const { t } = useTranslation(['common', 'trade'])
@@ -19,6 +23,7 @@ const ActionPanel = ({ bank }: { bank: Bank }) => {
   const [showDepositModal, setShowDepositModal] = useState<
     'deposit' | 'withdraw' | ''
   >('')
+  const [showSettleModal, setShowSettleModal] = useState(false)
   const { data: totalInterestData } = useAccountInterest()
   const [depositRate, borrowRate] = useMemo(() => {
     const depositRate = bank.getDepositRateUi()
@@ -84,12 +89,7 @@ const ActionPanel = ({ bank }: { bank: Bank }) => {
           <div className="flex justify-between border-t border-th-bkg-4 py-3">
             <p>{t('collateral-value')}</p>
             <p className="font-mono text-th-fgd-2">
-              $
-              {mangoAccount ? (
-                <FormatNumericValue value={collateralValue} decimals={2} />
-              ) : (
-                '0.00'
-              )}
+              {mangoAccount ? formatCurrencyValue(collateralValue) : '$0.00'}
             </p>
           </div>
           <div className="flex justify-between border-t border-th-bkg-4 py-3">
@@ -107,16 +107,21 @@ const ActionPanel = ({ bank }: { bank: Bank }) => {
           </div>
           <div className="flex justify-between border-t border-th-bkg-4 py-3">
             <p>{t('trade:unsettled')}</p>
-            <p className="font-mono text-th-fgd-2">
-              {unsettled ? (
-                <FormatNumericValue
-                  value={unsettled}
-                  decimals={bank.mintDecimals}
-                />
-              ) : (
-                0
-              )}
-            </p>
+            {unsettled ? (
+              <div className="flex space-x-2">
+                <p className="font-mono text-th-fgd-2">
+                  <FormatNumericValue
+                    value={unsettled}
+                    decimals={bank.mintDecimals}
+                  />
+                </p>
+                <LinkButton onClick={() => setShowSettleModal(true)}>
+                  {t('trade:settle')}
+                </LinkButton>
+              </div>
+            ) : (
+              <p className="font-mono text-th-fgd-2">0</p>
+            )}
           </div>
           <div className="flex justify-between border-t border-th-bkg-4 py-3">
             <p>{t('interest-earned')}</p>
@@ -191,8 +196,26 @@ const ActionPanel = ({ bank }: { bank: Bank }) => {
           token={bank?.name}
         />
       ) : null}
+      {showSettleModal ? (
+        <UnsettledModal
+          isOpen={showSettleModal}
+          onClose={() => setShowSettleModal(false)}
+        />
+      ) : null}
     </>
   )
 }
 
 export default ActionPanel
+
+const UnsettledModal = ({ isOpen, onClose }: ModalProps) => {
+  const { t } = useTranslation('trade')
+  return (
+    <Modal isOpen={isOpen} onClose={onClose}>
+      <h2 className="mb-4 text-center md:mb-0">{t('unsettled-balances')}</h2>
+      <div className="border-t border-th-bkg-3 md:border-t-0">
+        <UnsettledTrades />
+      </div>
+    </Modal>
+  )
+}

components/trade/TradeInfoTabs.tsx

@@ -84,20 +84,13 @@ const TradeInfoTabs = () => {
 export default TradeInfoTabs
 
 const TabContent = ({ selectedTab }: { selectedTab: string }) => {
-  const unsettledSpotBalances = useUnsettledSpotBalances()
-  const unsettledPerpPositions = useUnsettledPerpPositions()
   switch (selectedTab) {
     case 'balances':
       return <SwapTradeBalances />
     case 'trade:orders':
       return <AccountOrders />
     case 'trade:unsettled':
-      return (
-        <UnsettledTrades
-          unsettledSpotBalances={unsettledSpotBalances}
-          unsettledPerpPositions={unsettledPerpPositions}
-        />
-      )
+      return <UnsettledTrades />
     case 'trade:positions':
       return <PerpPositions />
     case 'trade-history':

components/trade/UnsettledTrades.tsx

@@ -12,7 +12,7 @@ import { useViewport } from 'hooks/useViewport'
 import { breakpoints } from 'utils/theme'
 import { Table, Td, Th, TrBody, TrHead } from '@components/shared/TableElements'
 import useMangoGroup from 'hooks/useMangoGroup'
-import { PerpMarket, PerpPosition } from '@blockworks-foundation/mango-v4'
+import { PerpMarket } from '@blockworks-foundation/mango-v4'
 import TableMarketName from './TableMarketName'
 import useMangoAccount from 'hooks/useMangoAccount'
 import { useWallet } from '@solana/wallet-adapter-react'
@@ -20,16 +20,14 @@ import ConnectEmptyState from '@components/shared/ConnectEmptyState'
 import FormatNumericValue from '@components/shared/FormatNumericValue'
 import useUnownedAccount from 'hooks/useUnownedAccount'
 import { isMangoError } from 'types'
+import { useUnsettledSpotBalances } from 'hooks/useUnsettledSpotBalances'
+import useUnsettledPerpPositions from 'hooks/useUnsettledPerpPositions'
 
-const UnsettledTrades = ({
-  unsettledSpotBalances,
-  unsettledPerpPositions,
-}: {
-  unsettledSpotBalances: any
-  unsettledPerpPositions: PerpPosition[]
-}) => {
+const UnsettledTrades = () => {
   const { t } = useTranslation(['common', 'trade'])
   const { group } = useMangoGroup()
+  const unsettledSpotBalances = useUnsettledSpotBalances()
+  const unsettledPerpPositions = useUnsettledPerpPositions()
   const [settleMktAddress, setSettleMktAddress] = useState<string>('')
   const { width } = useViewport()
   const showTableView = width ? width > breakpoints.md : false
@@ -136,8 +134,8 @@ const UnsettledTrades = ({
   if (!group) return null
 
   return mangoAccountAddress &&
-    Object.values(unsettledSpotBalances).flat().concat(unsettledPerpPositions)
-      .length ? (
+    (Object.values(unsettledSpotBalances)?.length ||
+      unsettledPerpPositions?.length) ? (
     showTableView ? (
       <Table>
         <thead>
@@ -163,22 +161,22 @@ const UnsettledTrades = ({
                   <TableMarketName market={market} />
                 </Td>
                 <Td className="text-right font-mono">
-                  <div className="flex justify-end">
+                  <div className="flex flex-wrap justify-end">
                     {unsettledSpotBalances[mktAddress].base ? (
-                      <div>
+                      <p>
                         <FormatNumericValue
                           value={unsettledSpotBalances[mktAddress].base}
                         />{' '}
                         <span className="font-body text-th-fgd-4">{base}</span>
-                      </div>
+                      </p>
                     ) : null}
                     {unsettledSpotBalances[mktAddress].quote ? (
-                      <div className="ml-4">
+                      <p className="ml-3">
                         <FormatNumericValue
                           value={unsettledSpotBalances[mktAddress].quote}
                         />{' '}
                         <span className="font-body text-th-fgd-4">{quote}</span>
-                      </div>
+                      </p>
                     ) : null}
                   </div>
                 </Td>
@@ -212,12 +210,14 @@ const UnsettledTrades = ({
                 <Td>
                   <TableMarketName market={market} />
                 </Td>
-                <Td className="text-right font-mono">
-                  <FormatNumericValue
-                    value={position.getUnsettledPnlUi(market)}
-                    decimals={2}
-                  />{' '}
-                  <span className="font-body text-th-fgd-4">USDC</span>
+                <Td>
+                  <p className="text-right font-mono">
+                    <FormatNumericValue
+                      value={position.getUnsettledPnlUi(market)}
+                      decimals={2}
+                    />{' '}
+                    <span className="font-body text-th-fgd-4">USDC</span>
+                  </p>
                 </Td>
                 {!isUnownedAccount ? (
                   <Td>
@@ -254,13 +254,13 @@ const UnsettledTrades = ({
             >
               <TableMarketName market={market} />
               <div className="flex items-center space-x-3">
-                <div className="font-mono">
+                <p className="font-mono text-th-fgd-1">
                   <FormatNumericValue
                     value={position.getUnsettledPnlUi(market)}
                     decimals={market.baseDecimals}
                   />{' '}
                   <span className="font-body text-th-fgd-4">USDC</span>
-                </div>
+                </p>
                 {!isUnownedAccount ? (
                   <IconButton
                     onClick={() => handleSettlePerpFunds(market)}
@@ -291,22 +291,24 @@ const UnsettledTrades = ({
             >
               <TableMarketName market={market} />
               <div className="flex items-center space-x-3">
-                {unsettledSpotBalances[mktAddress].base ? (
-                  <span className="font-mono text-sm">
-                    <FormatNumericValue
-                      value={unsettledSpotBalances[mktAddress].base}
-                    />{' '}
-                    <span className="font-body text-th-fgd-4">{base}</span>
-                  </span>
-                ) : null}
-                {unsettledSpotBalances[mktAddress].quote ? (
-                  <span className="font-mono text-sm">
-                    <FormatNumericValue
-                      value={unsettledSpotBalances[mktAddress].quote}
-                    />{' '}
-                    <span className="font-body text-th-fgd-4">{quote}</span>
-                  </span>
-                ) : null}
+                <div>
+                  {unsettledSpotBalances[mktAddress].base ? (
+                    <p className="text-right font-mono text-sm text-th-fgd-1">
+                      <FormatNumericValue
+                        value={unsettledSpotBalances[mktAddress].base}
+                      />{' '}
+                      <span className="font-body text-th-fgd-4">{base}</span>
+                    </p>
+                  ) : null}
+                  {unsettledSpotBalances[mktAddress].quote ? (
+                    <p className="text-right font-mono text-sm text-th-fgd-1">
+                      <FormatNumericValue
+                        value={unsettledSpotBalances[mktAddress].quote}
+                      />{' '}
+                      <span className="font-body text-th-fgd-4">{quote}</span>
+                    </p>
+                  ) : null}
+                </div>
                 {!isUnownedAccount ? (
                   <IconButton
                     onClick={() => handleSettleSerumFunds(mktAddress)}

public/locales/en/trade.json

@@ -101,6 +101,7 @@
     "return-on-equity": "Return on Equity",
     "rises-to": "rises above",
     "sells": "Sells",
+    "settle": "Settle",
     "settle-funds": "Settle Funds",
     "settle-funds-error": "Failed to settle funds",
     "short": "Short",
@@ -143,6 +144,7 @@
     "tweet-position": "Tweet",
     "unrealized-pnl": "Unrealized PnL",
     "unsettled": "Unsettled",
+    "unsettled-balances": "Unsettled Balances",
     "volume-alert": "Volume Alert",
     "volume-alert-desc": "Play a sound whenever volume exceeds your alert threshold",
     "warning-init-health": "You have no free collateral",

public/locales/es/trade.json

@@ -101,6 +101,7 @@
     "return-on-equity": "Return on Equity",
     "rises-to": "rises above",
     "sells": "Sells",
+    "settle": "Settle",
     "settle-funds": "Settle Funds",
     "settle-funds-error": "Failed to settle funds",
     "short": "Short",
@@ -143,6 +144,7 @@
     "tweet-position": "Tweet",
     "unrealized-pnl": "Unrealized PnL",
     "unsettled": "Unsettled",
+    "unsettled-balances": "Unsettled Balances",
     "view-counterparty": "View counterparty {{pk}}",
     "volume-alert": "Volume Alert",
     "volume-alert-desc": "Play a sound whenever volume exceeds your alert threshold",

public/locales/pt/trade.json

@@ -101,6 +101,7 @@
     "return-on-equity": "Retorno sobre o Patrimônio",
     "rises-to": "sobe acima de",
     "sells": "Vende",
+    "settle": "Liquidar",
     "settle-funds": "Liquidar Fundos",
     "settle-funds-error": "Falha ao liquidar fundos",
     "short": "Short",
@@ -143,6 +144,7 @@
     "tweet-position": "Tweetar",
     "unrealized-pnl": "PnL Não Realizado",
     "unsettled": "Não Liquidado",
+    "unsettled-balances": "Unsettled Balances",
     "volume-alert": "Alerta de Volume",
     "volume-alert-desc": "Tocar um som sempre que o volume exceder seu limite de alerta",
     "warning-init-health": "You have no free collateral",

public/locales/ru/trade.json

@@ -101,6 +101,7 @@
     "return-on-equity": "Return on Equity",
     "rises-to": "rises above",
     "sells": "Sells",
+    "settle": "Settle",
     "settle-funds": "Settle Funds",
     "settle-funds-error": "Failed to settle funds",
     "short": "Short",
@@ -143,6 +144,7 @@
     "tweet-position": "Tweet",
     "unrealized-pnl": "Unrealized PnL",
     "unsettled": "Unsettled",
+    "unsettled-balances": "Unsettled Balances",
     "view-counterparty": "View counterparty {{pk}}",
     "volume-alert": "Volume Alert",
     "volume-alert-desc": "Play a sound whenever volume exceeds your alert threshold",

public/locales/zh/trade.json

@@ -101,6 +101,7 @@
     "return-on-equity": "股本回报率",
     "rises-to": "上涨至",
     "sells": "卖单",
+    "settle": "Settle",
     "settle-funds": "结清资金",
     "settle-funds-error": "结清出错",
     "short": "做空",
@@ -143,6 +144,7 @@
     "tweet-position": "分享至Twitter",
     "unrealized-pnl": "未实现盈亏",
     "unsettled": "未结清",
+    "unsettled-balances": "Unsettled Balances",
     "view-counterparty": "查看交易对手 {{pk}}",
     "volume-alert": "交易量警报",
     "volume-alert-desc": "交易量超过警报设定时播放声音",

public/locales/zh_tw/trade.json

@@ -101,6 +101,7 @@
     "return-on-equity": "股本回報率",
     "rises-to": "上漲至",
     "sells": "賣單",
+    "settle": "Settle",
     "settle-funds": "結清資金",
     "settle-funds-error": "結清出錯",
     "short": "做空",
@@ -143,6 +144,7 @@
     "tweet-position": "分享至Twitter",
     "unrealized-pnl": "未實現盈虧",
     "unsettled": "未結清",
+    "unsettled-balances": "Unsettled Balances",
     "view-counterparty": "查看交易對手 {{pk}}",
     "volume-alert": "交易量警報",
     "volume-alert-desc": "交易量超過警報設定時播放聲音",