use title instead of tooltip

This commit is contained in:
saml33 2024-03-18 10:06:33 +11:00
parent 15979d4f39
commit e12b24ee2e
3 changed files with 52 additions and 73 deletions

View File

@ -34,7 +34,6 @@ import React, {
} from 'react' } from 'react'
import { Disclosure, Popover, Transition } from '@headlessui/react' import { Disclosure, Popover, Transition } from '@headlessui/react'
import MangoAccountSummary from './account/MangoAccountSummary' import MangoAccountSummary from './account/MangoAccountSummary'
import Tooltip from './shared/Tooltip'
import { HealthType } from '@blockworks-foundation/mango-v4' import { HealthType } from '@blockworks-foundation/mango-v4'
import { useWallet } from '@solana/wallet-adapter-react' import { useWallet } from '@solana/wallet-adapter-react'
import mangoStore from '@store/mangoStore' import mangoStore from '@store/mangoStore'
@ -232,7 +231,6 @@ const SideNav = ({ collapsed }: { collapsed: boolean }) => {
title={t('overview')} title={t('overview')}
pagePath="/?view=overview" pagePath="/?view=overview"
hideIconBg hideIconBg
showTooltip={false}
/> />
<MenuItem <MenuItem
active={ active={
@ -245,7 +243,6 @@ const SideNav = ({ collapsed }: { collapsed: boolean }) => {
title={t('balances')} title={t('balances')}
pagePath="/?view=balances" pagePath="/?view=balances"
hideIconBg hideIconBg
showTooltip={false}
/> />
<MenuItem <MenuItem
active={ active={
@ -258,7 +255,6 @@ const SideNav = ({ collapsed }: { collapsed: boolean }) => {
title={t('trade:positions')} title={t('trade:positions')}
pagePath="/?view=positions" pagePath="/?view=positions"
hideIconBg hideIconBg
showTooltip={false}
/> />
<MenuItem <MenuItem
active={ active={
@ -271,7 +267,6 @@ const SideNav = ({ collapsed }: { collapsed: boolean }) => {
title={t('trade:orders')} title={t('trade:orders')}
pagePath="/?view=orders" pagePath="/?view=orders"
hideIconBg hideIconBg
showTooltip={false}
/> />
<MenuItem <MenuItem
active={ active={
@ -284,7 +279,6 @@ const SideNav = ({ collapsed }: { collapsed: boolean }) => {
title={t('trade:unsettled')} title={t('trade:unsettled')}
pagePath="/?view=unsettled" pagePath="/?view=unsettled"
hideIconBg hideIconBg
showTooltip={false}
/> />
<MenuItem <MenuItem
active={ active={
@ -297,7 +291,6 @@ const SideNav = ({ collapsed }: { collapsed: boolean }) => {
title={t('history')} title={t('history')}
pagePath="/?view=history" pagePath="/?view=history"
hideIconBg hideIconBg
showTooltip={false}
/> />
</ExpandableMenuItem> </ExpandableMenuItem>
<MenuItem <MenuItem
@ -324,7 +317,6 @@ const SideNav = ({ collapsed }: { collapsed: boolean }) => {
title={t('perp')} title={t('perp')}
pagePath="/trade?name=SOL-PERP" pagePath="/trade?name=SOL-PERP"
hideIconBg hideIconBg
showTooltip={false}
/> />
<MenuItem <MenuItem
active={ active={
@ -337,7 +329,6 @@ const SideNav = ({ collapsed }: { collapsed: boolean }) => {
title={t('spot')} title={t('spot')}
pagePath="/trade?name=SOL/USDC" pagePath="/trade?name=SOL/USDC"
hideIconBg hideIconBg
showTooltip={false}
/> />
</ExpandableMenuItem> </ExpandableMenuItem>
<MenuItem <MenuItem
@ -382,7 +373,6 @@ const SideNav = ({ collapsed }: { collapsed: boolean }) => {
title={t('search:search-accounts')} title={t('search:search-accounts')}
pagePath="/search" pagePath="/search"
hideIconBg hideIconBg
showTooltip={false}
/> />
<MenuItem <MenuItem
active={pathname === '/governance/list'} active={pathname === '/governance/list'}
@ -391,7 +381,6 @@ const SideNav = ({ collapsed }: { collapsed: boolean }) => {
title={t('common:list-market-token')} title={t('common:list-market-token')}
pagePath="/governance/list" pagePath="/governance/list"
hideIconBg hideIconBg
showTooltip={false}
/> />
<MenuItem <MenuItem
active={pathname === '/governance/vote'} active={pathname === '/governance/vote'}
@ -400,7 +389,6 @@ const SideNav = ({ collapsed }: { collapsed: boolean }) => {
title={t('common:vote')} title={t('common:vote')}
pagePath="/governance/vote" pagePath="/governance/vote"
hideIconBg hideIconBg
showTooltip={false}
/> />
<MenuItem <MenuItem
collapsed={false} collapsed={false}
@ -409,7 +397,6 @@ const SideNav = ({ collapsed }: { collapsed: boolean }) => {
pagePath="https://docs.mango.markets" pagePath="https://docs.mango.markets"
hideIconBg hideIconBg
isExternal isExternal
showTooltip={false}
/> />
<MenuItem <MenuItem
collapsed={false} collapsed={false}
@ -418,7 +405,6 @@ const SideNav = ({ collapsed }: { collapsed: boolean }) => {
pagePath="https://dao.mango.markets" pagePath="https://dao.mango.markets"
hideIconBg hideIconBg
isExternal isExternal
showTooltip={false}
/> />
{/* <MenuItem {/* <MenuItem
collapsed={false} collapsed={false}
@ -427,7 +413,6 @@ const SideNav = ({ collapsed }: { collapsed: boolean }) => {
pagePath="https://forms.gle/JgV4w7SJ2kPH89mq7" pagePath="https://forms.gle/JgV4w7SJ2kPH89mq7"
hideIconBg hideIconBg
isExternal isExternal
showTooltip={false}
/> */} /> */}
<MenuItem <MenuItem
collapsed={false} collapsed={false}
@ -436,7 +421,6 @@ const SideNav = ({ collapsed }: { collapsed: boolean }) => {
pagePath="https://docs.mango.markets/legal" pagePath="https://docs.mango.markets/legal"
hideIconBg hideIconBg
isExternal isExternal
showTooltip={false}
/> />
<MenuItem <MenuItem
collapsed={false} collapsed={false}
@ -445,7 +429,6 @@ const SideNav = ({ collapsed }: { collapsed: boolean }) => {
pagePath="https://docs.mango.markets/mango-markets/risks" pagePath="https://docs.mango.markets/mango-markets/risks"
hideIconBg hideIconBg
isExternal isExternal
showTooltip={false}
/> />
</ExpandableMenuItem> </ExpandableMenuItem>
</div> </div>
@ -503,7 +486,6 @@ const MenuItem = ({
pagePath, pagePath,
hideIconBg, hideIconBg,
isExternal, isExternal,
showTooltip = true,
}: { }: {
active?: boolean active?: boolean
collapsed: boolean collapsed: boolean
@ -513,67 +495,59 @@ const MenuItem = ({
pagePath: string pagePath: string
hideIconBg?: boolean hideIconBg?: boolean
isExternal?: boolean isExternal?: boolean
showTooltip?: boolean
}) => { }) => {
const { theme } = useTheme() const { theme } = useTheme()
const { width } = useViewport()
const hideTooltip = width >= breakpoints.lg
return ( return (
<Tooltip <Link
content={title} href={pagePath}
placement="right" onClick={onClick ? onClick : undefined}
show={collapsed && showTooltip && !hideTooltip} shallow={true}
className={`flex cursor-pointer pl-4 focus:outline-none focus-visible:text-th-active md:hover:text-th-active ${
active
? 'text-th-active'
: theme === 'Light'
? 'text-th-fgd-3'
: 'text-th-fgd-2'
} ${hideIconBg ? 'py-1' : 'py-1.5 xl:py-2'}`}
target={isExternal ? '_blank' : ''}
rel={isExternal ? 'noopener noreferrer' : ''}
title={title}
> >
<Link <div className="flex w-full items-center">
href={pagePath} <div className="flex items-center">
onClick={onClick ? onClick : undefined} {icon ? (
shallow={true} <div
className={`flex cursor-pointer pl-4 focus:outline-none focus-visible:text-th-active md:hover:text-th-active ${ className={
active hideIconBg
? 'text-th-active' ? ''
: theme === 'Light' : `flex h-8 w-8 items-center justify-center rounded-full ${
? 'text-th-fgd-3' theme === 'Light' ? 'bg-th-bkg-2' : 'bg-th-bkg-3'
: 'text-th-fgd-2' }`
} ${hideIconBg ? 'py-1' : 'py-1.5 xl:py-2'}`} }
target={isExternal ? '_blank' : ''}
rel={isExternal ? 'noopener noreferrer' : ''}
>
<div className="flex w-full items-center">
<div className="flex items-center">
{icon ? (
<div
className={
hideIconBg
? ''
: `flex h-8 w-8 items-center justify-center rounded-full ${
theme === 'Light' ? 'bg-th-bkg-2' : 'bg-th-bkg-3'
}`
}
>
{icon}
</div>
) : null}
<Transition
show={!collapsed}
as={Fragment}
enter={`transition-all ease-in duration-${sideBarAnimationDuration}`}
enterFrom="opacity-50"
enterTo="opacity-100"
leave={`transition-all ease-out duration-${sideBarAnimationDuration}`}
leaveFrom="opacity-100"
leaveTo="opacity-0"
> >
<span className="ml-3 whitespace-nowrap 2xl:text-base"> {icon}
{title} </div>
</span>
</Transition>
</div>
{isExternal ? (
<ArrowTopRightOnSquareIcon className="ml-2 h-3 w-3" />
) : null} ) : null}
<Transition
show={!collapsed}
as={Fragment}
enter={`transition-all ease-in duration-${sideBarAnimationDuration}`}
enterFrom="opacity-50"
enterTo="opacity-100"
leave={`transition-all ease-out duration-${sideBarAnimationDuration}`}
leaveFrom="opacity-100"
leaveTo="opacity-0"
>
<span className="ml-3 whitespace-nowrap 2xl:text-base">
{title}
</span>
</Transition>
</div> </div>
</Link> {isExternal ? (
</Tooltip> <ArrowTopRightOnSquareIcon className="ml-2 h-3 w-3" />
) : null}
</div>
</Link>
) )
} }
@ -670,6 +644,7 @@ export const ExpandableMenuItem = ({
onKeyDown={() => { onKeyDown={() => {
setIsOpen(!isOpen) setIsOpen(!isOpen)
}} }}
title={`${title}`}
> >
<div <div
className={` ${ className={` ${

View File

@ -278,7 +278,7 @@ const TopBar = () => {
<button <button
onClick={() => handleDepositWithdrawModal('deposit')} onClick={() => handleDepositWithdrawModal('deposit')}
className={TOPBAR_ICON_BUTTON_CLASSES} className={TOPBAR_ICON_BUTTON_CLASSES}
title="Deposit Withdraw" title="Deposit/Withdraw"
> >
<DepositWithdrawIcon className="h-6 w-6" /> <DepositWithdrawIcon className="h-6 w-6" />
</button> </button>
@ -301,6 +301,7 @@ const TopBar = () => {
<button <button
className={TOPBAR_ICON_BUTTON_CLASSES} className={TOPBAR_ICON_BUTTON_CLASSES}
onClick={() => setShowSettingsModal(true)} onClick={() => setShowSettingsModal(true)}
title={t('settings')}
> >
<Cog8ToothIcon className="h-5 w-5" /> <Cog8ToothIcon className="h-5 w-5" />
<span className="sr-only">Settings</span> <span className="sr-only">Settings</span>

View File

@ -7,8 +7,10 @@ import { useCookies } from 'hooks/notifications/useCookies'
import { useNotificationSocket } from 'hooks/notifications/useNotificationSocket' import { useNotificationSocket } from 'hooks/notifications/useNotificationSocket'
import { formatNumericValue } from 'utils/numbers' import { formatNumericValue } from 'utils/numbers'
import { TOPBAR_ICON_BUTTON_CLASSES } from '@components/TopBar' import { TOPBAR_ICON_BUTTON_CLASSES } from '@components/TopBar'
import { useTranslation } from 'react-i18next'
const NotificationsButton = () => { const NotificationsButton = () => {
const { t } = useTranslation('notifications')
useCookies() useCookies()
useNotificationSocket() useNotificationSocket()
@ -33,6 +35,7 @@ const NotificationsButton = () => {
<button <button
className={TOPBAR_ICON_BUTTON_CLASSES} className={TOPBAR_ICON_BUTTON_CLASSES}
onClick={() => toggleModal()} onClick={() => toggleModal()}
title={t('notifications')}
> >
<BellIcon className="h-5 w-5" /> <BellIcon className="h-5 w-5" />
<span className="sr-only">Notifications</span> <span className="sr-only">Notifications</span>