From 8108b31ff9a142586cd58cab224d68ecad4f8100 Mon Sep 17 00:00:00 2001
From: Christian Kamm <mail@ckamm.de>
Date: Tue, 2 Apr 2024 14:43:49 +0200
Subject: [PATCH] keeper: report confirmation times only on success (#928)

reporting a "confirmation time" on an error response made the metrics
confusing
---
 bin/keeper/src/crank.rs | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/bin/keeper/src/crank.rs b/bin/keeper/src/crank.rs
index 5884c6ef5..78ff4aef0 100644
--- a/bin/keeper/src/crank.rs
+++ b/bin/keeper/src/crank.rs
@@ -245,21 +245,21 @@ pub async fn loop_update_index_and_rate(
             .send_and_confirm_permissionless_tx(instructions)
             .await;
 
-        let confirmation_time = pre.elapsed().as_millis();
-        METRIC_CONFIRMATION_TIMES.observe(confirmation_time as f64);
+        let duration_ms = pre.elapsed().as_millis();
 
         if let Err(e) = sig_result {
             METRIC_UPDATE_TOKENS_FAILURE.inc();
             info!(
                 "metricName=UpdateTokensV4Failure tokens={} durationMs={} error={}",
-                token_names, confirmation_time, e
+                token_names, duration_ms, e
             );
             error!("{:?}", e)
         } else {
             METRIC_UPDATE_TOKENS_SUCCESS.inc();
+            METRIC_CONFIRMATION_TIMES.observe(duration_ms as f64);
             info!(
                 "metricName=UpdateTokensV4Success tokens={} durationMs={}",
-                token_names, confirmation_time,
+                token_names, duration_ms,
             );
             info!("{:?}", sig_result);
         }