blockworks-foundation
/
pyth-crosschain
mirror of https://github.com/blockworks-foundation/pyth-crosschain.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

[cosmwasm] address audit (#685) 

* remove todos

* add governance source index check

* bumb pyth-sdk-cw version
This commit is contained in:
Dev Kalra 2023-03-14 00:18:19 +05:30 committed by GitHub
parent b6fcb03d6b
commit 3e104b4184
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 12 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
target_chains/cosmwasm/Cargo.lock generated
View File

@ -1305,7 +1305,7 @@ dependencies = [
[[package]]
name = "pyth-sdk-cw"
version = "1.0.0"
version = "1.1.0"
dependencies = [
"cosmwasm-schema",
"cosmwasm-std",

13
target_chains/cosmwasm/contracts/pyth/src/contract.rs
View File

@ -334,8 +334,8 @@ fn transfer_governance(
RequestGovernanceDataSourceTransfer {
governance_data_source_index,
} => {
if current_config.governance_source_index >= governance_data_source_index {
Err(PythContractError::OldGovernanceMessage)?
if current_config.governance_source_index != governance_data_source_index - 1 {
Err(PythContractError::InvalidGovernanceSourceIndex)?
}
next_config.governance_source_index = governance_data_source_index;
@ -657,8 +657,7 @@ mod test {
fn create_price_update_msg(emitter_address: &[u8], emitter_chain: u16) -> Binary {
let batch_attestation = BatchPriceAttestation {
// TODO: pass these in
price_attestations: vec![],
price_attestations: vec![PriceAttestation::default()],
};
let mut vaa = create_zero_vaa();
@ -1292,7 +1291,7 @@ mod test {
module: Target,
target_chain_id: test_config.chain_id,
action: RequestGovernanceDataSourceTransfer {
governance_data_source_index: 11,
governance_data_source_index: 1,
},
}
.serialize()
@ -1306,7 +1305,7 @@ mod test {
let test_vaa = governance_vaa(&test_instruction);
let (_response, result_config) = apply_governance_vaa(&test_config, &test_vaa).unwrap();
assert_eq!(result_config.governance_source, source_2);
assert_eq!(result_config.governance_source_index, 11);
assert_eq!(result_config.governance_source_index, 1);
assert_eq!(result_config.governance_sequence_number, 12);
}
@ -1345,7 +1344,7 @@ mod test {
let test_vaa = governance_vaa(&test_instruction);
assert_eq!(
apply_governance_vaa(&test_config, &test_vaa),
Err(PythContractError::OldGovernanceMessage.into())
Err(PythContractError::InvalidGovernanceSourceIndex.into())
);
}

2
target_chains/cosmwasm/pyth-sdk-cw/Cargo.toml
View File

@ -1,6 +1,6 @@
[package]
name = "pyth-sdk-cw"
version = "1.0.0"
version = "1.1.0"
authors = ["Pyth Data Foundation"]
edition = "2018"
license = "Apache-2.0"

4
target_chains/cosmwasm/pyth-sdk-cw/src/error.rs
View File

@ -41,6 +41,10 @@ pub enum PythContractError {
#[error("OldGovernanceMessage")]
OldGovernanceMessage,
/// The governance source index it not valid.
#[error("OldGovernanceMessage")]
InvalidGovernanceSourceIndex,
/// The message did not include a sufficient fee.
#[error("InsufficientFee")]
InsufficientFee,