add zero value check (#1181)

This commit is contained in:
Dev Kalra 2023-12-14 17:54:43 +05:30 committed by GitHub
parent 9875bc2ba4
commit 654c1eae89
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 21 additions and 0 deletions

View File

@ -81,6 +81,12 @@ abstract contract Entropy is IEntropy, EntropyState {
address defaultProvider, address defaultProvider,
bool prefillRequestStorage bool prefillRequestStorage
) internal { ) internal {
require(admin != address(0), "admin is zero address");
require(
defaultProvider != address(0),
"defaultProvider is zero address"
);
_state.admin = admin; _state.admin = admin;
_state.accruedPythFeesInWei = 0; _state.accruedPythFeesInWei = 0;
_state.pythFeeInWei = pythFeeInWei; _state.pythFeeInWei = pythFeeInWei;

View File

@ -30,6 +30,8 @@ abstract contract EntropyGovernance is EntropyState {
* Can only be called by either admin or owner. * Can only be called by either admin or owner.
*/ */
function proposeAdmin(address newAdmin) public virtual { function proposeAdmin(address newAdmin) public virtual {
require(newAdmin != address(0), "newAdmin is zero address");
_authoriseAdminAction(); _authoriseAdminAction();
_state.proposedAdmin = newAdmin; _state.proposedAdmin = newAdmin;
@ -78,6 +80,10 @@ abstract contract EntropyGovernance is EntropyState {
* Emits an {DefaultProviderSet} event. * Emits an {DefaultProviderSet} event.
*/ */
function setDefaultProvider(address newDefaultProvider) external { function setDefaultProvider(address newDefaultProvider) external {
require(
newDefaultProvider != address(0),
"newDefaultProvider is zero address"
);
_authoriseAdminAction(); _authoriseAdminAction();
address oldDefaultProvider = _state.defaultProvider; address oldDefaultProvider = _state.defaultProvider;

View File

@ -31,6 +31,13 @@ contract EntropyUpgradable is
address defaultProvider, address defaultProvider,
bool prefillRequestStorage bool prefillRequestStorage
) public initializer { ) public initializer {
require(owner != address(0), "owner is zero address");
require(admin != address(0), "admin is zero address");
require(
defaultProvider != address(0),
"defaultProvider is zero address"
);
__Ownable_init(); __Ownable_init();
__UUPSUpgradeable_init(); __UUPSUpgradeable_init();

View File

@ -49,6 +49,8 @@ contract Executor {
uint16 _ownerEmitterChainId, uint16 _ownerEmitterChainId,
bytes32 _ownerEmitterAddress bytes32 _ownerEmitterAddress
) { ) {
require(_wormhole != address(0), "_wormhole is zero address");
wormhole = IWormhole(_wormhole); wormhole = IWormhole(_wormhole);
lastExecutedSequence = _lastExecutedSequence; lastExecutedSequence = _lastExecutedSequence;
chainId = _chainId; chainId = _chainId;