2018-09-19 17:25:57 -07:00
|
|
|
//! budget program
|
2019-09-09 18:17:32 -07:00
|
|
|
use crate::{
|
|
|
|
budget_expr::Witness,
|
|
|
|
budget_instruction::{BudgetError, BudgetInstruction},
|
|
|
|
budget_state::BudgetState,
|
|
|
|
};
|
2018-09-17 13:36:31 -07:00
|
|
|
use chrono::prelude::{DateTime, Utc};
|
2018-12-14 20:39:10 -08:00
|
|
|
use log::*;
|
2019-09-09 18:17:32 -07:00
|
|
|
use solana_sdk::{
|
2019-11-22 13:34:50 -08:00
|
|
|
account::KeyedAccount,
|
|
|
|
hash::hash,
|
|
|
|
instruction::InstructionError,
|
|
|
|
instruction_processor_utils::{limited_deserialize, next_keyed_account},
|
|
|
|
pubkey::Pubkey,
|
2019-09-09 18:17:32 -07:00
|
|
|
};
|
2019-03-03 13:17:51 -08:00
|
|
|
|
|
|
|
/// Process a Witness Signature. Any payment plans waiting on this signature
|
|
|
|
/// will progress one step.
|
|
|
|
fn apply_signature(
|
|
|
|
budget_state: &mut BudgetState,
|
2020-01-22 17:54:06 -08:00
|
|
|
witness_keyed_account: &KeyedAccount,
|
|
|
|
contract_keyed_account: &KeyedAccount,
|
|
|
|
to_keyed_account: Result<&KeyedAccount, InstructionError>,
|
2019-11-22 13:34:50 -08:00
|
|
|
) -> Result<(), InstructionError> {
|
2019-03-03 13:17:51 -08:00
|
|
|
let mut final_payment = None;
|
|
|
|
if let Some(ref mut expr) = budget_state.pending_budget {
|
2019-11-22 13:34:50 -08:00
|
|
|
let key = witness_keyed_account.signer_key().unwrap();
|
2019-03-03 13:17:51 -08:00
|
|
|
expr.apply_witness(&Witness::Signature, key);
|
|
|
|
final_payment = expr.final_payment();
|
|
|
|
}
|
|
|
|
|
|
|
|
if let Some(payment) = final_payment {
|
2019-11-22 13:34:50 -08:00
|
|
|
if let Some(key) = witness_keyed_account.signer_key() {
|
2019-03-03 13:17:51 -08:00
|
|
|
if &payment.to == key {
|
|
|
|
budget_state.pending_budget = None;
|
2020-01-22 09:11:56 -08:00
|
|
|
contract_keyed_account.try_account_ref_mut()?.lamports -= payment.lamports;
|
|
|
|
witness_keyed_account.try_account_ref_mut()?.lamports += payment.lamports;
|
2019-03-03 13:17:51 -08:00
|
|
|
return Ok(());
|
|
|
|
}
|
|
|
|
}
|
2019-11-22 13:34:50 -08:00
|
|
|
let to_keyed_account = to_keyed_account?;
|
|
|
|
if &payment.to != to_keyed_account.unsigned_key() {
|
2019-03-03 13:17:51 -08:00
|
|
|
trace!("destination missing");
|
2019-11-22 13:34:50 -08:00
|
|
|
return Err(BudgetError::DestinationMissing.into());
|
2019-03-03 13:17:51 -08:00
|
|
|
}
|
|
|
|
budget_state.pending_budget = None;
|
2020-01-22 09:11:56 -08:00
|
|
|
contract_keyed_account.try_account_ref_mut()?.lamports -= payment.lamports;
|
|
|
|
to_keyed_account.try_account_ref_mut()?.lamports += payment.lamports;
|
2019-03-03 13:17:51 -08:00
|
|
|
}
|
|
|
|
Ok(())
|
2018-09-17 13:36:31 -07:00
|
|
|
}
|
|
|
|
|
2019-03-03 13:17:51 -08:00
|
|
|
/// Process a Witness Timestamp. Any payment plans waiting on this timestamp
|
|
|
|
/// will progress one step.
|
|
|
|
fn apply_timestamp(
|
|
|
|
budget_state: &mut BudgetState,
|
2020-01-22 17:54:06 -08:00
|
|
|
witness_keyed_account: &KeyedAccount,
|
|
|
|
contract_keyed_account: &KeyedAccount,
|
|
|
|
to_keyed_account: Result<&KeyedAccount, InstructionError>,
|
2019-03-03 13:17:51 -08:00
|
|
|
dt: DateTime<Utc>,
|
2019-11-22 13:34:50 -08:00
|
|
|
) -> Result<(), InstructionError> {
|
2019-03-03 13:17:51 -08:00
|
|
|
// Check to see if any timelocked transactions can be completed.
|
|
|
|
let mut final_payment = None;
|
|
|
|
|
|
|
|
if let Some(ref mut expr) = budget_state.pending_budget {
|
2019-11-22 13:34:50 -08:00
|
|
|
let key = witness_keyed_account.signer_key().unwrap();
|
2019-03-03 13:17:51 -08:00
|
|
|
expr.apply_witness(&Witness::Timestamp(dt), key);
|
|
|
|
final_payment = expr.final_payment();
|
|
|
|
}
|
|
|
|
|
|
|
|
if let Some(payment) = final_payment {
|
2019-11-22 13:34:50 -08:00
|
|
|
let to_keyed_account = to_keyed_account?;
|
|
|
|
if &payment.to != to_keyed_account.unsigned_key() {
|
2019-03-03 13:17:51 -08:00
|
|
|
trace!("destination missing");
|
2019-11-22 13:34:50 -08:00
|
|
|
return Err(BudgetError::DestinationMissing.into());
|
2019-03-03 13:17:51 -08:00
|
|
|
}
|
|
|
|
budget_state.pending_budget = None;
|
2020-01-22 09:11:56 -08:00
|
|
|
contract_keyed_account.try_account_ref_mut()?.lamports -= payment.lamports;
|
|
|
|
to_keyed_account.try_account_ref_mut()?.lamports += payment.lamports;
|
2019-03-03 13:17:51 -08:00
|
|
|
}
|
|
|
|
Ok(())
|
2018-09-17 13:36:31 -07:00
|
|
|
}
|
|
|
|
|
2019-06-13 18:20:28 -07:00
|
|
|
/// Process an AccountData Witness and any payment waiting on it.
|
|
|
|
fn apply_account_data(
|
|
|
|
budget_state: &mut BudgetState,
|
2020-01-22 17:54:06 -08:00
|
|
|
witness_keyed_account: &KeyedAccount,
|
|
|
|
contract_keyed_account: &KeyedAccount,
|
|
|
|
to_keyed_account: Result<&KeyedAccount, InstructionError>,
|
2019-11-22 13:34:50 -08:00
|
|
|
) -> Result<(), InstructionError> {
|
2019-06-13 18:20:28 -07:00
|
|
|
// Check to see if any timelocked transactions can be completed.
|
|
|
|
let mut final_payment = None;
|
|
|
|
|
|
|
|
if let Some(ref mut expr) = budget_state.pending_budget {
|
|
|
|
let key = witness_keyed_account.unsigned_key();
|
2020-01-22 09:11:56 -08:00
|
|
|
let program_id = witness_keyed_account.owner()?;
|
|
|
|
let actual_hash = hash(&witness_keyed_account.try_account_ref()?.data);
|
2019-06-13 18:20:28 -07:00
|
|
|
expr.apply_witness(&Witness::AccountData(actual_hash, program_id), key);
|
|
|
|
final_payment = expr.final_payment();
|
|
|
|
}
|
|
|
|
|
|
|
|
if let Some(payment) = final_payment {
|
2019-11-22 13:34:50 -08:00
|
|
|
let to_keyed_account = to_keyed_account?;
|
|
|
|
if &payment.to != to_keyed_account.unsigned_key() {
|
2019-06-13 18:20:28 -07:00
|
|
|
trace!("destination missing");
|
2019-11-22 13:34:50 -08:00
|
|
|
return Err(BudgetError::DestinationMissing.into());
|
2019-06-13 18:20:28 -07:00
|
|
|
}
|
|
|
|
budget_state.pending_budget = None;
|
2020-01-22 09:11:56 -08:00
|
|
|
contract_keyed_account.try_account_ref_mut()?.lamports -= payment.lamports;
|
|
|
|
to_keyed_account.try_account_ref_mut()?.lamports += payment.lamports;
|
2019-06-13 18:20:28 -07:00
|
|
|
}
|
|
|
|
Ok(())
|
|
|
|
}
|
|
|
|
|
2019-03-15 15:10:00 -07:00
|
|
|
pub fn process_instruction(
|
|
|
|
_program_id: &Pubkey,
|
2020-01-22 17:54:06 -08:00
|
|
|
keyed_accounts: &[KeyedAccount],
|
2019-03-15 15:10:00 -07:00
|
|
|
data: &[u8],
|
2019-03-18 09:05:03 -07:00
|
|
|
) -> Result<(), InstructionError> {
|
2020-01-22 17:54:06 -08:00
|
|
|
let keyed_accounts_iter = &mut keyed_accounts.iter();
|
2019-10-23 19:56:07 -07:00
|
|
|
let instruction = limited_deserialize(data)?;
|
2019-03-15 15:10:00 -07:00
|
|
|
|
|
|
|
trace!("process_instruction: {:?}", instruction);
|
|
|
|
|
2018-11-23 12:45:34 -08:00
|
|
|
match instruction {
|
2019-03-03 13:17:51 -08:00
|
|
|
BudgetInstruction::InitializeAccount(expr) => {
|
2019-11-22 13:34:50 -08:00
|
|
|
let contract_keyed_account = next_keyed_account(keyed_accounts_iter)?;
|
2019-12-19 23:27:54 -08:00
|
|
|
|
2018-11-23 12:45:34 -08:00
|
|
|
if let Some(payment) = expr.final_payment() {
|
2019-11-22 13:34:50 -08:00
|
|
|
let to_keyed_account = contract_keyed_account;
|
|
|
|
let contract_keyed_account = next_keyed_account(keyed_accounts_iter)?;
|
2020-01-22 09:11:56 -08:00
|
|
|
contract_keyed_account.try_account_ref_mut()?.lamports = 0;
|
|
|
|
to_keyed_account.try_account_ref_mut()?.lamports += payment.lamports;
|
2019-03-15 15:10:00 -07:00
|
|
|
return Ok(());
|
|
|
|
}
|
2020-01-22 09:11:56 -08:00
|
|
|
let existing =
|
|
|
|
BudgetState::deserialize(&contract_keyed_account.try_account_ref_mut()?.data).ok();
|
2019-03-15 15:10:00 -07:00
|
|
|
if Some(true) == existing.map(|x| x.initialized) {
|
|
|
|
trace!("contract already exists");
|
2019-03-18 09:05:03 -07:00
|
|
|
return Err(InstructionError::AccountAlreadyInitialized);
|
2018-11-23 12:45:34 -08:00
|
|
|
}
|
2019-03-15 15:10:00 -07:00
|
|
|
let mut budget_state = BudgetState::default();
|
2019-06-13 18:20:28 -07:00
|
|
|
budget_state.pending_budget = Some(*expr);
|
2019-03-15 15:10:00 -07:00
|
|
|
budget_state.initialized = true;
|
2020-01-22 09:11:56 -08:00
|
|
|
budget_state.serialize(&mut contract_keyed_account.try_account_ref_mut()?.data)
|
2018-11-23 12:45:34 -08:00
|
|
|
}
|
2019-03-03 13:17:51 -08:00
|
|
|
BudgetInstruction::ApplyTimestamp(dt) => {
|
2019-11-22 13:34:50 -08:00
|
|
|
let witness_keyed_account = next_keyed_account(keyed_accounts_iter)?;
|
|
|
|
let contract_keyed_account = next_keyed_account(keyed_accounts_iter)?;
|
2020-01-22 09:11:56 -08:00
|
|
|
let mut budget_state =
|
|
|
|
BudgetState::deserialize(&contract_keyed_account.try_account_ref()?.data)?;
|
2019-03-15 15:10:00 -07:00
|
|
|
if !budget_state.is_pending() {
|
|
|
|
return Ok(()); // Nothing to do here.
|
|
|
|
}
|
|
|
|
if !budget_state.initialized {
|
|
|
|
trace!("contract is uninitialized");
|
2019-03-18 09:05:03 -07:00
|
|
|
return Err(InstructionError::UninitializedAccount);
|
2018-11-23 12:45:34 -08:00
|
|
|
}
|
2019-11-22 13:34:50 -08:00
|
|
|
if witness_keyed_account.signer_key().is_none() {
|
2019-03-18 09:05:03 -07:00
|
|
|
return Err(InstructionError::MissingRequiredSignature);
|
2019-03-15 15:10:00 -07:00
|
|
|
}
|
|
|
|
trace!("apply timestamp");
|
2019-11-22 13:34:50 -08:00
|
|
|
apply_timestamp(
|
|
|
|
&mut budget_state,
|
|
|
|
witness_keyed_account,
|
|
|
|
contract_keyed_account,
|
|
|
|
next_keyed_account(keyed_accounts_iter),
|
|
|
|
dt,
|
|
|
|
)?;
|
2019-03-15 15:10:00 -07:00
|
|
|
trace!("apply timestamp committed");
|
2020-01-22 09:11:56 -08:00
|
|
|
budget_state.serialize(&mut contract_keyed_account.try_account_ref_mut()?.data)
|
2018-11-23 12:45:34 -08:00
|
|
|
}
|
2019-03-03 13:17:51 -08:00
|
|
|
BudgetInstruction::ApplySignature => {
|
2019-11-22 13:34:50 -08:00
|
|
|
let witness_keyed_account = next_keyed_account(keyed_accounts_iter)?;
|
|
|
|
let contract_keyed_account = next_keyed_account(keyed_accounts_iter)?;
|
2020-01-22 09:11:56 -08:00
|
|
|
let mut budget_state =
|
|
|
|
BudgetState::deserialize(&contract_keyed_account.try_account_ref()?.data)?;
|
2019-03-15 15:10:00 -07:00
|
|
|
if !budget_state.is_pending() {
|
|
|
|
return Ok(()); // Nothing to do here.
|
|
|
|
}
|
|
|
|
if !budget_state.initialized {
|
|
|
|
trace!("contract is uninitialized");
|
2019-03-18 09:05:03 -07:00
|
|
|
return Err(InstructionError::UninitializedAccount);
|
2018-11-23 12:45:34 -08:00
|
|
|
}
|
2019-11-22 13:34:50 -08:00
|
|
|
if witness_keyed_account.signer_key().is_none() {
|
2019-03-18 09:05:03 -07:00
|
|
|
return Err(InstructionError::MissingRequiredSignature);
|
2019-03-15 15:10:00 -07:00
|
|
|
}
|
|
|
|
trace!("apply signature");
|
2019-11-22 13:34:50 -08:00
|
|
|
apply_signature(
|
|
|
|
&mut budget_state,
|
|
|
|
witness_keyed_account,
|
|
|
|
contract_keyed_account,
|
|
|
|
next_keyed_account(keyed_accounts_iter),
|
|
|
|
)?;
|
2019-03-15 15:10:00 -07:00
|
|
|
trace!("apply signature committed");
|
2020-01-22 09:11:56 -08:00
|
|
|
budget_state.serialize(&mut contract_keyed_account.try_account_ref_mut()?.data)
|
2018-11-23 12:45:34 -08:00
|
|
|
}
|
2019-06-13 18:20:28 -07:00
|
|
|
BudgetInstruction::ApplyAccountData => {
|
2019-11-22 13:34:50 -08:00
|
|
|
let witness_keyed_account = next_keyed_account(keyed_accounts_iter)?;
|
|
|
|
let contract_keyed_account = next_keyed_account(keyed_accounts_iter)?;
|
2020-01-22 09:11:56 -08:00
|
|
|
let mut budget_state =
|
|
|
|
BudgetState::deserialize(&contract_keyed_account.try_account_ref()?.data)?;
|
2019-06-13 18:20:28 -07:00
|
|
|
if !budget_state.is_pending() {
|
|
|
|
return Ok(()); // Nothing to do here.
|
|
|
|
}
|
|
|
|
if !budget_state.initialized {
|
|
|
|
trace!("contract is uninitialized");
|
|
|
|
return Err(InstructionError::UninitializedAccount);
|
|
|
|
}
|
2019-11-22 13:34:50 -08:00
|
|
|
apply_account_data(
|
|
|
|
&mut budget_state,
|
|
|
|
witness_keyed_account,
|
|
|
|
contract_keyed_account,
|
|
|
|
next_keyed_account(keyed_accounts_iter),
|
|
|
|
)?;
|
2019-06-13 18:20:28 -07:00
|
|
|
trace!("apply account data committed");
|
2020-01-22 09:11:56 -08:00
|
|
|
budget_state.serialize(&mut contract_keyed_account.try_account_ref_mut()?.data)
|
2019-06-13 18:20:28 -07:00
|
|
|
}
|
2018-11-23 12:45:34 -08:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2018-09-17 13:36:31 -07:00
|
|
|
#[cfg(test)]
|
2019-03-22 05:47:05 -07:00
|
|
|
mod tests {
|
2018-11-23 12:45:34 -08:00
|
|
|
use super::*;
|
2019-04-03 08:45:57 -07:00
|
|
|
use crate::budget_instruction;
|
2019-03-21 15:24:54 -07:00
|
|
|
use crate::id;
|
2019-03-16 04:50:44 -07:00
|
|
|
use solana_runtime::bank::Bank;
|
2019-03-16 13:30:10 -07:00
|
|
|
use solana_runtime::bank_client::BankClient;
|
2019-06-13 18:20:28 -07:00
|
|
|
use solana_sdk::account::Account;
|
2019-04-11 00:25:14 -07:00
|
|
|
use solana_sdk::client::SyncClient;
|
2019-11-08 20:56:57 -08:00
|
|
|
use solana_sdk::genesis_config::create_genesis_config;
|
2019-06-13 18:20:28 -07:00
|
|
|
use solana_sdk::hash::hash;
|
2019-03-23 20:12:27 -07:00
|
|
|
use solana_sdk::instruction::InstructionError;
|
2019-03-27 04:36:01 -07:00
|
|
|
use solana_sdk::message::Message;
|
2018-12-03 10:26:28 -08:00
|
|
|
use solana_sdk::signature::{Keypair, KeypairUtil};
|
2019-03-27 04:36:01 -07:00
|
|
|
use solana_sdk::transaction::TransactionError;
|
2018-09-26 09:33:52 -07:00
|
|
|
|
2019-03-16 04:50:44 -07:00
|
|
|
fn create_bank(lamports: u64) -> (Bank, Keypair) {
|
2019-11-08 20:56:57 -08:00
|
|
|
let (genesis_config, mint_keypair) = create_genesis_config(lamports);
|
|
|
|
let mut bank = Bank::new(&genesis_config);
|
2019-03-16 16:20:09 -07:00
|
|
|
bank.add_instruction_processor(id(), process_instruction);
|
2019-03-16 04:50:44 -07:00
|
|
|
(bank, mint_keypair)
|
2018-09-28 16:16:35 -07:00
|
|
|
}
|
2019-03-07 09:35:28 -08:00
|
|
|
|
2019-11-22 13:34:50 -08:00
|
|
|
#[test]
|
|
|
|
fn test_initialize_no_panic() {
|
|
|
|
let (bank, alice_keypair) = create_bank(1);
|
|
|
|
let bank_client = BankClient::new(bank);
|
|
|
|
|
|
|
|
let alice_pubkey = alice_keypair.pubkey();
|
|
|
|
let budget_keypair = Keypair::new();
|
|
|
|
let budget_pubkey = budget_keypair.pubkey();
|
|
|
|
let bob_pubkey = Pubkey::new_rand();
|
|
|
|
|
|
|
|
let mut instructions =
|
|
|
|
budget_instruction::payment(&alice_pubkey, &bob_pubkey, &budget_pubkey, 1);
|
|
|
|
instructions[1].accounts = vec![]; // <!-- Attack! Prevent accounts from being passed into processor.
|
|
|
|
|
|
|
|
let message = Message::new(instructions);
|
|
|
|
assert_eq!(
|
|
|
|
bank_client
|
|
|
|
.send_message(&[&alice_keypair, &budget_keypair], message)
|
|
|
|
.unwrap_err()
|
|
|
|
.unwrap(),
|
|
|
|
TransactionError::InstructionError(1, InstructionError::NotEnoughAccountKeys)
|
|
|
|
);
|
|
|
|
}
|
|
|
|
|
2019-03-16 16:37:18 -07:00
|
|
|
#[test]
|
|
|
|
fn test_budget_payment() {
|
2019-03-27 06:34:01 -07:00
|
|
|
let (bank, alice_keypair) = create_bank(10_000);
|
2019-04-11 11:29:59 -07:00
|
|
|
let bank_client = BankClient::new(bank);
|
2019-03-27 06:34:01 -07:00
|
|
|
let alice_pubkey = alice_keypair.pubkey();
|
2019-03-30 20:37:33 -07:00
|
|
|
let bob_pubkey = Pubkey::new_rand();
|
2019-11-08 02:27:35 -08:00
|
|
|
let budget_keypair = Keypair::new();
|
|
|
|
let budget_pubkey = budget_keypair.pubkey();
|
|
|
|
let instructions =
|
|
|
|
budget_instruction::payment(&alice_pubkey, &bob_pubkey, &budget_pubkey, 100);
|
2019-03-27 04:50:50 -07:00
|
|
|
let message = Message::new(instructions);
|
2019-03-27 06:34:01 -07:00
|
|
|
bank_client
|
2019-11-08 02:27:35 -08:00
|
|
|
.send_message(&[&alice_keypair, &budget_keypair], message)
|
2019-03-27 06:34:01 -07:00
|
|
|
.unwrap();
|
2019-04-03 20:40:29 -07:00
|
|
|
assert_eq!(bank_client.get_balance(&bob_pubkey).unwrap(), 100);
|
2019-03-16 16:37:18 -07:00
|
|
|
}
|
|
|
|
|
2018-10-18 20:10:33 -07:00
|
|
|
#[test]
|
|
|
|
fn test_unsigned_witness_key() {
|
2019-03-27 06:34:01 -07:00
|
|
|
let (bank, alice_keypair) = create_bank(10_000);
|
2019-04-11 11:29:59 -07:00
|
|
|
let bank_client = BankClient::new(bank);
|
2019-03-27 06:34:01 -07:00
|
|
|
let alice_pubkey = alice_keypair.pubkey();
|
2018-10-18 20:10:33 -07:00
|
|
|
|
2019-03-03 13:17:51 -08:00
|
|
|
// Initialize BudgetState
|
2019-11-08 02:27:35 -08:00
|
|
|
let budget_keypair = Keypair::new();
|
|
|
|
let budget_pubkey = budget_keypair.pubkey();
|
2019-03-30 20:37:33 -07:00
|
|
|
let bob_pubkey = Pubkey::new_rand();
|
|
|
|
let witness = Pubkey::new_rand();
|
2019-04-03 08:45:57 -07:00
|
|
|
let instructions = budget_instruction::when_signed(
|
2019-03-16 13:30:10 -07:00
|
|
|
&alice_pubkey,
|
|
|
|
&bob_pubkey,
|
|
|
|
&budget_pubkey,
|
|
|
|
&witness,
|
|
|
|
None,
|
|
|
|
1,
|
|
|
|
);
|
2019-03-27 04:50:50 -07:00
|
|
|
let message = Message::new(instructions);
|
2019-03-27 06:34:01 -07:00
|
|
|
bank_client
|
2019-11-08 02:27:35 -08:00
|
|
|
.send_message(&[&alice_keypair, &budget_keypair], message)
|
2019-03-27 06:34:01 -07:00
|
|
|
.unwrap();
|
2018-10-18 20:10:33 -07:00
|
|
|
|
|
|
|
// Attack! Part 1: Sign a witness transaction with a random key.
|
2019-03-27 06:34:01 -07:00
|
|
|
let mallory_keypair = Keypair::new();
|
|
|
|
let mallory_pubkey = mallory_keypair.pubkey();
|
|
|
|
bank_client
|
|
|
|
.transfer(1, &alice_keypair, &mallory_pubkey)
|
|
|
|
.unwrap();
|
2019-03-16 13:30:10 -07:00
|
|
|
let instruction =
|
2019-04-03 08:45:57 -07:00
|
|
|
budget_instruction::apply_signature(&mallory_pubkey, &budget_pubkey, &bob_pubkey);
|
2019-03-27 04:36:01 -07:00
|
|
|
let mut message = Message::new(vec![instruction]);
|
2018-10-18 20:10:33 -07:00
|
|
|
|
|
|
|
// Attack! Part 2: Point the instruction to the expected, but unsigned, key.
|
2019-05-22 15:23:16 -07:00
|
|
|
message.account_keys.insert(3, alice_pubkey);
|
2019-03-27 04:36:01 -07:00
|
|
|
message.instructions[0].accounts[0] = 3;
|
2019-07-01 17:34:22 -07:00
|
|
|
message.instructions[0].program_id_index = 4;
|
2018-10-18 20:10:33 -07:00
|
|
|
|
|
|
|
// Ensure the transaction fails because of the unsigned key.
|
|
|
|
assert_eq!(
|
2019-04-03 20:40:29 -07:00
|
|
|
bank_client
|
|
|
|
.send_message(&[&mallory_keypair], message)
|
|
|
|
.unwrap_err()
|
|
|
|
.unwrap(),
|
|
|
|
TransactionError::InstructionError(0, InstructionError::MissingRequiredSignature)
|
2018-10-18 20:10:33 -07:00
|
|
|
);
|
|
|
|
}
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
fn test_unsigned_timestamp() {
|
2019-03-27 06:34:01 -07:00
|
|
|
let (bank, alice_keypair) = create_bank(10_000);
|
2019-04-11 11:29:59 -07:00
|
|
|
let bank_client = BankClient::new(bank);
|
2019-03-27 06:34:01 -07:00
|
|
|
let alice_pubkey = alice_keypair.pubkey();
|
2018-10-18 20:10:33 -07:00
|
|
|
|
2019-03-03 13:17:51 -08:00
|
|
|
// Initialize BudgetState
|
2019-11-08 02:27:35 -08:00
|
|
|
let budget_keypair = Keypair::new();
|
|
|
|
let budget_pubkey = budget_keypair.pubkey();
|
2019-03-30 20:37:33 -07:00
|
|
|
let bob_pubkey = Pubkey::new_rand();
|
2018-10-18 20:10:33 -07:00
|
|
|
let dt = Utc::now();
|
2019-04-03 08:45:57 -07:00
|
|
|
let instructions = budget_instruction::on_date(
|
2019-03-16 13:30:10 -07:00
|
|
|
&alice_pubkey,
|
|
|
|
&bob_pubkey,
|
|
|
|
&budget_pubkey,
|
2018-10-18 20:10:33 -07:00
|
|
|
dt,
|
2019-03-16 13:30:10 -07:00
|
|
|
&alice_pubkey,
|
2018-10-18 20:10:33 -07:00
|
|
|
None,
|
|
|
|
1,
|
|
|
|
);
|
2019-03-27 04:50:50 -07:00
|
|
|
let message = Message::new(instructions);
|
2019-03-27 06:34:01 -07:00
|
|
|
bank_client
|
2019-11-08 02:27:35 -08:00
|
|
|
.send_message(&[&alice_keypair, &budget_keypair], message)
|
2019-03-27 06:34:01 -07:00
|
|
|
.unwrap();
|
2018-10-18 20:10:33 -07:00
|
|
|
|
|
|
|
// Attack! Part 1: Sign a timestamp transaction with a random key.
|
2019-03-27 06:34:01 -07:00
|
|
|
let mallory_keypair = Keypair::new();
|
|
|
|
let mallory_pubkey = mallory_keypair.pubkey();
|
|
|
|
bank_client
|
|
|
|
.transfer(1, &alice_keypair, &mallory_pubkey)
|
|
|
|
.unwrap();
|
2019-04-03 08:45:57 -07:00
|
|
|
let instruction =
|
|
|
|
budget_instruction::apply_timestamp(&mallory_pubkey, &budget_pubkey, &bob_pubkey, dt);
|
2019-03-27 04:36:01 -07:00
|
|
|
let mut message = Message::new(vec![instruction]);
|
2018-10-18 20:10:33 -07:00
|
|
|
|
|
|
|
// Attack! Part 2: Point the instruction to the expected, but unsigned, key.
|
2019-05-22 15:23:16 -07:00
|
|
|
message.account_keys.insert(3, alice_pubkey);
|
2019-03-27 04:36:01 -07:00
|
|
|
message.instructions[0].accounts[0] = 3;
|
2019-07-01 17:34:22 -07:00
|
|
|
message.instructions[0].program_id_index = 4;
|
2018-10-18 20:10:33 -07:00
|
|
|
|
|
|
|
// Ensure the transaction fails because of the unsigned key.
|
|
|
|
assert_eq!(
|
2019-04-03 20:40:29 -07:00
|
|
|
bank_client
|
|
|
|
.send_message(&[&mallory_keypair], message)
|
|
|
|
.unwrap_err()
|
|
|
|
.unwrap(),
|
|
|
|
TransactionError::InstructionError(0, InstructionError::MissingRequiredSignature)
|
2018-10-18 20:10:33 -07:00
|
|
|
);
|
|
|
|
}
|
|
|
|
|
2018-09-17 13:36:31 -07:00
|
|
|
#[test]
|
2019-03-18 04:17:59 -07:00
|
|
|
fn test_pay_on_date() {
|
2019-03-27 06:34:01 -07:00
|
|
|
let (bank, alice_keypair) = create_bank(2);
|
2019-04-11 11:29:59 -07:00
|
|
|
let bank_client = BankClient::new(bank);
|
2019-03-27 06:34:01 -07:00
|
|
|
let alice_pubkey = alice_keypair.pubkey();
|
2019-11-08 02:27:35 -08:00
|
|
|
let budget_keypair = Keypair::new();
|
|
|
|
let budget_pubkey = budget_keypair.pubkey();
|
2019-03-30 20:37:33 -07:00
|
|
|
let bob_pubkey = Pubkey::new_rand();
|
|
|
|
let mallory_pubkey = Pubkey::new_rand();
|
2018-09-17 13:36:31 -07:00
|
|
|
let dt = Utc::now();
|
2019-11-08 02:27:35 -08:00
|
|
|
|
2019-04-03 08:45:57 -07:00
|
|
|
let instructions = budget_instruction::on_date(
|
2019-03-16 13:30:10 -07:00
|
|
|
&alice_pubkey,
|
|
|
|
&bob_pubkey,
|
|
|
|
&budget_pubkey,
|
2018-09-17 13:36:31 -07:00
|
|
|
dt,
|
2019-03-16 13:30:10 -07:00
|
|
|
&alice_pubkey,
|
2018-09-22 16:51:21 -07:00
|
|
|
None,
|
2018-09-17 13:36:31 -07:00
|
|
|
1,
|
|
|
|
);
|
2019-03-27 04:50:50 -07:00
|
|
|
let message = Message::new(instructions);
|
2019-03-27 06:34:01 -07:00
|
|
|
bank_client
|
2019-11-08 02:27:35 -08:00
|
|
|
.send_message(&[&alice_keypair, &budget_keypair], message)
|
2019-03-27 06:34:01 -07:00
|
|
|
.unwrap();
|
2019-04-03 20:40:29 -07:00
|
|
|
assert_eq!(bank_client.get_balance(&alice_pubkey).unwrap(), 1);
|
|
|
|
assert_eq!(bank_client.get_balance(&budget_pubkey).unwrap(), 1);
|
2019-03-16 04:50:44 -07:00
|
|
|
|
2019-04-03 20:40:29 -07:00
|
|
|
let contract_account = bank_client
|
|
|
|
.get_account_data(&budget_pubkey)
|
|
|
|
.unwrap()
|
|
|
|
.unwrap();
|
2019-04-03 15:36:10 -07:00
|
|
|
let budget_state = BudgetState::deserialize(&contract_account).unwrap();
|
2019-03-03 13:17:51 -08:00
|
|
|
assert!(budget_state.is_pending());
|
2018-09-17 13:36:31 -07:00
|
|
|
|
2019-03-16 13:30:10 -07:00
|
|
|
// Attack! Try to payout to mallory_pubkey
|
2019-04-03 08:45:57 -07:00
|
|
|
let instruction =
|
|
|
|
budget_instruction::apply_timestamp(&alice_pubkey, &budget_pubkey, &mallory_pubkey, dt);
|
2018-09-24 16:00:55 -07:00
|
|
|
assert_eq!(
|
2019-03-27 06:34:01 -07:00
|
|
|
bank_client
|
2019-04-03 14:11:08 -07:00
|
|
|
.send_instruction(&alice_keypair, instruction)
|
2019-04-03 20:40:29 -07:00
|
|
|
.unwrap_err()
|
|
|
|
.unwrap(),
|
2019-03-15 15:10:00 -07:00
|
|
|
TransactionError::InstructionError(
|
|
|
|
0,
|
2019-04-11 11:41:12 -07:00
|
|
|
InstructionError::CustomError(BudgetError::DestinationMissing as u32)
|
2019-03-15 15:10:00 -07:00
|
|
|
)
|
2018-09-24 16:00:55 -07:00
|
|
|
);
|
2019-04-03 20:40:29 -07:00
|
|
|
assert_eq!(bank_client.get_balance(&alice_pubkey).unwrap(), 1);
|
|
|
|
assert_eq!(bank_client.get_balance(&budget_pubkey).unwrap(), 1);
|
|
|
|
assert_eq!(bank_client.get_balance(&bob_pubkey).unwrap(), 0);
|
2018-09-17 13:36:31 -07:00
|
|
|
|
2019-04-03 20:40:29 -07:00
|
|
|
let contract_account = bank_client
|
|
|
|
.get_account_data(&budget_pubkey)
|
|
|
|
.unwrap()
|
|
|
|
.unwrap();
|
2019-04-03 15:36:10 -07:00
|
|
|
let budget_state = BudgetState::deserialize(&contract_account).unwrap();
|
2019-03-03 13:17:51 -08:00
|
|
|
assert!(budget_state.is_pending());
|
2018-09-17 13:36:31 -07:00
|
|
|
|
|
|
|
// Now, acknowledge the time in the condition occurred and
|
|
|
|
// that pubkey's funds are now available.
|
2019-03-16 13:30:10 -07:00
|
|
|
let instruction =
|
2019-04-03 08:45:57 -07:00
|
|
|
budget_instruction::apply_timestamp(&alice_pubkey, &budget_pubkey, &bob_pubkey, dt);
|
2019-03-27 06:34:01 -07:00
|
|
|
bank_client
|
2019-04-03 14:11:08 -07:00
|
|
|
.send_instruction(&alice_keypair, instruction)
|
2019-03-27 06:34:01 -07:00
|
|
|
.unwrap();
|
2019-04-03 20:40:29 -07:00
|
|
|
assert_eq!(bank_client.get_balance(&alice_pubkey).unwrap(), 1);
|
|
|
|
assert_eq!(bank_client.get_balance(&budget_pubkey).unwrap(), 0);
|
|
|
|
assert_eq!(bank_client.get_balance(&bob_pubkey).unwrap(), 1);
|
|
|
|
assert_eq!(bank_client.get_account_data(&budget_pubkey).unwrap(), None);
|
2018-09-17 13:36:31 -07:00
|
|
|
}
|
2019-03-16 04:50:44 -07:00
|
|
|
|
2018-09-17 13:36:31 -07:00
|
|
|
#[test]
|
2019-03-18 04:17:59 -07:00
|
|
|
fn test_cancel_payment() {
|
2019-03-27 06:34:01 -07:00
|
|
|
let (bank, alice_keypair) = create_bank(3);
|
2019-04-11 11:29:59 -07:00
|
|
|
let bank_client = BankClient::new(bank);
|
2019-03-27 06:34:01 -07:00
|
|
|
let alice_pubkey = alice_keypair.pubkey();
|
2019-11-08 02:27:35 -08:00
|
|
|
let budget_keypair = Keypair::new();
|
|
|
|
let budget_pubkey = budget_keypair.pubkey();
|
2019-03-30 20:37:33 -07:00
|
|
|
let bob_pubkey = Pubkey::new_rand();
|
2018-09-17 13:36:31 -07:00
|
|
|
let dt = Utc::now();
|
2019-03-16 04:50:44 -07:00
|
|
|
|
2019-04-03 08:45:57 -07:00
|
|
|
let instructions = budget_instruction::on_date(
|
2019-03-16 13:30:10 -07:00
|
|
|
&alice_pubkey,
|
|
|
|
&bob_pubkey,
|
|
|
|
&budget_pubkey,
|
2018-09-17 13:36:31 -07:00
|
|
|
dt,
|
2019-03-16 13:30:10 -07:00
|
|
|
&alice_pubkey,
|
|
|
|
Some(alice_pubkey),
|
2018-09-17 13:36:31 -07:00
|
|
|
1,
|
|
|
|
);
|
2019-03-27 04:50:50 -07:00
|
|
|
let message = Message::new(instructions);
|
2019-03-27 06:34:01 -07:00
|
|
|
bank_client
|
2019-11-08 02:27:35 -08:00
|
|
|
.send_message(&[&alice_keypair, &budget_keypair], message)
|
2019-03-27 06:34:01 -07:00
|
|
|
.unwrap();
|
2019-04-03 20:40:29 -07:00
|
|
|
assert_eq!(bank_client.get_balance(&alice_pubkey).unwrap(), 2);
|
|
|
|
assert_eq!(bank_client.get_balance(&budget_pubkey).unwrap(), 1);
|
2019-03-16 04:50:44 -07:00
|
|
|
|
2019-04-03 20:40:29 -07:00
|
|
|
let contract_account = bank_client
|
|
|
|
.get_account_data(&budget_pubkey)
|
|
|
|
.unwrap()
|
|
|
|
.unwrap();
|
2019-04-03 15:36:10 -07:00
|
|
|
let budget_state = BudgetState::deserialize(&contract_account).unwrap();
|
2019-03-03 13:17:51 -08:00
|
|
|
assert!(budget_state.is_pending());
|
2018-09-17 13:36:31 -07:00
|
|
|
|
2019-03-05 16:28:14 -08:00
|
|
|
// Attack! try to put the lamports into the wrong account with cancel
|
2019-03-27 06:34:01 -07:00
|
|
|
let mallory_keypair = Keypair::new();
|
|
|
|
let mallory_pubkey = mallory_keypair.pubkey();
|
|
|
|
bank_client
|
|
|
|
.transfer(1, &alice_keypair, &mallory_pubkey)
|
|
|
|
.unwrap();
|
2019-04-03 20:40:29 -07:00
|
|
|
assert_eq!(bank_client.get_balance(&alice_pubkey).unwrap(), 1);
|
2019-03-16 13:30:10 -07:00
|
|
|
|
|
|
|
let instruction =
|
2019-04-03 08:45:57 -07:00
|
|
|
budget_instruction::apply_signature(&mallory_pubkey, &budget_pubkey, &bob_pubkey);
|
2019-03-27 06:34:01 -07:00
|
|
|
bank_client
|
2019-04-03 14:11:08 -07:00
|
|
|
.send_instruction(&mallory_keypair, instruction)
|
2019-03-27 06:34:01 -07:00
|
|
|
.unwrap();
|
2018-09-17 13:36:31 -07:00
|
|
|
// nothing should be changed because apply witness didn't finalize a payment
|
2019-04-03 20:40:29 -07:00
|
|
|
assert_eq!(bank_client.get_balance(&alice_pubkey).unwrap(), 1);
|
|
|
|
assert_eq!(bank_client.get_balance(&budget_pubkey).unwrap(), 1);
|
|
|
|
assert_eq!(bank_client.get_account_data(&bob_pubkey).unwrap(), None);
|
2019-03-16 13:30:10 -07:00
|
|
|
|
|
|
|
// Now, cancel the transaction. mint gets her funds back
|
|
|
|
let instruction =
|
2019-04-03 08:45:57 -07:00
|
|
|
budget_instruction::apply_signature(&alice_pubkey, &budget_pubkey, &alice_pubkey);
|
2019-03-27 06:34:01 -07:00
|
|
|
bank_client
|
2019-04-03 14:11:08 -07:00
|
|
|
.send_instruction(&alice_keypair, instruction)
|
2019-03-27 06:34:01 -07:00
|
|
|
.unwrap();
|
2019-04-03 20:40:29 -07:00
|
|
|
assert_eq!(bank_client.get_balance(&alice_pubkey).unwrap(), 2);
|
|
|
|
assert_eq!(bank_client.get_account_data(&budget_pubkey).unwrap(), None);
|
|
|
|
assert_eq!(bank_client.get_account_data(&bob_pubkey).unwrap(), None);
|
2018-09-17 13:36:31 -07:00
|
|
|
}
|
2019-06-13 18:20:28 -07:00
|
|
|
|
|
|
|
#[test]
|
|
|
|
fn test_pay_when_account_data() {
|
|
|
|
let (bank, alice_keypair) = create_bank(42);
|
|
|
|
let game_pubkey = Pubkey::new_rand();
|
|
|
|
let game_account = Account {
|
|
|
|
lamports: 1,
|
|
|
|
data: vec![1, 2, 3],
|
|
|
|
..Account::default()
|
|
|
|
};
|
|
|
|
bank.store_account(&game_pubkey, &game_account);
|
|
|
|
assert_eq!(bank.get_account(&game_pubkey).unwrap().data, vec![1, 2, 3]);
|
|
|
|
|
|
|
|
let bank_client = BankClient::new(bank);
|
|
|
|
|
|
|
|
let alice_pubkey = alice_keypair.pubkey();
|
|
|
|
let game_hash = hash(&[1, 2, 3]);
|
2019-11-08 02:27:35 -08:00
|
|
|
let budget_keypair = Keypair::new();
|
|
|
|
let budget_pubkey = budget_keypair.pubkey();
|
2019-06-13 18:20:28 -07:00
|
|
|
let bob_keypair = Keypair::new();
|
|
|
|
let bob_pubkey = bob_keypair.pubkey();
|
|
|
|
|
|
|
|
// Give Bob some lamports so he can sign the witness transaction.
|
|
|
|
bank_client
|
|
|
|
.transfer(1, &alice_keypair, &bob_pubkey)
|
|
|
|
.unwrap();
|
|
|
|
|
|
|
|
let instructions = budget_instruction::when_account_data(
|
|
|
|
&alice_pubkey,
|
|
|
|
&bob_pubkey,
|
|
|
|
&budget_pubkey,
|
|
|
|
&game_pubkey,
|
|
|
|
&game_account.owner,
|
|
|
|
game_hash,
|
|
|
|
41,
|
|
|
|
);
|
|
|
|
let message = Message::new(instructions);
|
|
|
|
bank_client
|
2019-11-08 02:27:35 -08:00
|
|
|
.send_message(&[&alice_keypair, &budget_keypair], message)
|
2019-06-13 18:20:28 -07:00
|
|
|
.unwrap();
|
|
|
|
assert_eq!(bank_client.get_balance(&alice_pubkey).unwrap(), 0);
|
|
|
|
assert_eq!(bank_client.get_balance(&budget_pubkey).unwrap(), 41);
|
|
|
|
|
|
|
|
let contract_account = bank_client
|
|
|
|
.get_account_data(&budget_pubkey)
|
|
|
|
.unwrap()
|
|
|
|
.unwrap();
|
|
|
|
let budget_state = BudgetState::deserialize(&contract_account).unwrap();
|
|
|
|
assert!(budget_state.is_pending());
|
|
|
|
|
|
|
|
// Acknowledge the condition occurred and that Bob's funds are now available.
|
|
|
|
let instruction =
|
|
|
|
budget_instruction::apply_account_data(&game_pubkey, &budget_pubkey, &bob_pubkey);
|
|
|
|
|
|
|
|
// Anyone can sign the message, but presumably it's Bob, since he's the
|
|
|
|
// one claiming the payout.
|
|
|
|
let message = Message::new_with_payer(vec![instruction], Some(&bob_pubkey));
|
|
|
|
bank_client.send_message(&[&bob_keypair], message).unwrap();
|
|
|
|
|
|
|
|
assert_eq!(bank_client.get_balance(&alice_pubkey).unwrap(), 0);
|
|
|
|
assert_eq!(bank_client.get_balance(&budget_pubkey).unwrap(), 0);
|
|
|
|
assert_eq!(bank_client.get_balance(&bob_pubkey).unwrap(), 42);
|
|
|
|
assert_eq!(bank_client.get_account_data(&budget_pubkey).unwrap(), None);
|
|
|
|
}
|
2018-09-17 13:36:31 -07:00
|
|
|
}
|