From 456e6711f0c24b13ae5e923ff8cd2af3caab496d Mon Sep 17 00:00:00 2001 From: Phil Chen Date: Wed, 18 May 2022 08:59:04 +0900 Subject: [PATCH] chore: typo in BlockheightBasedTransactionConfirmationStrategy (#25279) * fix typo: Confimation => Confirmation * chore: run prettier Co-authored-by: steveluscher --- web3.js/src/connection.ts | 12 +++++++----- web3.js/src/util/send-and-confirm-raw-transaction.ts | 12 ++++++------ 2 files changed, 13 insertions(+), 11 deletions(-) diff --git a/web3.js/src/connection.ts b/web3.js/src/connection.ts index ed186261e..48154dfd1 100644 --- a/web3.js/src/connection.ts +++ b/web3.js/src/connection.ts @@ -293,7 +293,7 @@ export type BlockhashWithExpiryBlockHeight = Readonly<{ * A strategy for confirming transactions that uses the last valid * block height for a given blockhash to check for transaction expiration. */ -export type BlockheightBasedTransactionConfimationStrategy = { +export type BlockheightBasedTransactionConfirmationStrategy = { signature: TransactionSignature; } & BlockhashWithExpiryBlockHeight; @@ -2842,7 +2842,7 @@ export class Connection { } confirmTransaction( - strategy: BlockheightBasedTransactionConfimationStrategy, + strategy: BlockheightBasedTransactionConfirmationStrategy, commitment?: Commitment, ): Promise>; @@ -2856,7 +2856,7 @@ export class Connection { // eslint-disable-next-line no-dupe-class-members async confirmTransaction( strategy: - | BlockheightBasedTransactionConfimationStrategy + | BlockheightBasedTransactionConfirmationStrategy | TransactionSignature, commitment?: Commitment, ): Promise> { @@ -2865,7 +2865,8 @@ export class Connection { if (typeof strategy == 'string') { rawSignature = strategy; } else { - const config = strategy as BlockheightBasedTransactionConfimationStrategy; + const config = + strategy as BlockheightBasedTransactionConfirmationStrategy; rawSignature = config.signature; } @@ -2942,7 +2943,8 @@ export class Connection { timeoutMs, ); } else { - let config = strategy as BlockheightBasedTransactionConfimationStrategy; + let config = + strategy as BlockheightBasedTransactionConfirmationStrategy; (async () => { let currentBlockHeight = await checkBlockHeight(); if (done) return; diff --git a/web3.js/src/util/send-and-confirm-raw-transaction.ts b/web3.js/src/util/send-and-confirm-raw-transaction.ts index f57021437..ed9de3a90 100644 --- a/web3.js/src/util/send-and-confirm-raw-transaction.ts +++ b/web3.js/src/util/send-and-confirm-raw-transaction.ts @@ -1,7 +1,7 @@ import type {Buffer} from 'buffer'; import { - BlockheightBasedTransactionConfimationStrategy, + BlockheightBasedTransactionConfirmationStrategy, Connection, } from '../connection'; import type {TransactionSignature} from '../transaction'; @@ -14,14 +14,14 @@ import type {ConfirmOptions} from '../connection'; * * @param {Connection} connection * @param {Buffer} rawTransaction - * @param {BlockheightBasedTransactionConfimationStrategy} confirmationStrategy + * @param {BlockheightBasedTransactionConfirmationStrategy} confirmationStrategy * @param {ConfirmOptions} [options] * @returns {Promise} */ export async function sendAndConfirmRawTransaction( connection: Connection, rawTransaction: Buffer, - confirmationStrategy: BlockheightBasedTransactionConfimationStrategy, + confirmationStrategy: BlockheightBasedTransactionConfirmationStrategy, options?: ConfirmOptions, ): Promise; @@ -41,13 +41,13 @@ export async function sendAndConfirmRawTransaction( connection: Connection, rawTransaction: Buffer, confirmationStrategyOrConfirmOptions: - | BlockheightBasedTransactionConfimationStrategy + | BlockheightBasedTransactionConfirmationStrategy | ConfirmOptions | undefined, maybeConfirmOptions?: ConfirmOptions, ): Promise { let confirmationStrategy: - | BlockheightBasedTransactionConfimationStrategy + | BlockheightBasedTransactionConfirmationStrategy | undefined; let options: ConfirmOptions | undefined; if ( @@ -58,7 +58,7 @@ export async function sendAndConfirmRawTransaction( ) ) { confirmationStrategy = - confirmationStrategyOrConfirmOptions as BlockheightBasedTransactionConfimationStrategy; + confirmationStrategyOrConfirmOptions as BlockheightBasedTransactionConfirmationStrategy; options = maybeConfirmOptions; } else { options = confirmationStrategyOrConfirmOptions as