From 55fc647568a1da8821e2b4c5d472936173b5122c Mon Sep 17 00:00:00 2001 From: Rob Walker Date: Sat, 23 Jun 2018 13:12:24 -0700 Subject: [PATCH] fix more shellcheck --- multinode-demo/myip.sh | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/multinode-demo/myip.sh b/multinode-demo/myip.sh index ea63a923a..4ec054e7b 100755 --- a/multinode-demo/myip.sh +++ b/multinode-demo/myip.sh @@ -2,10 +2,16 @@ function myip() { - declare ipaddrs=( - $(curl -s ifconfig.co) # query interwebs - $(ifconfig | awk '/inet(6)? (addr:)?/ {print $2}') # machine interfaces - ) + declare ipaddrs=( ) + + # query interwebs + mapfile -t ipaddrs < <(curl -s ifconfig.co) + + # machine's interfaces + mapfile -t -O "${#ipaddrs[*]}" ipaddrs < \ + <(ifconfig | awk '/inet(6)? (addr:)?/ {print $2}') + + ipaddrs=( "${extips[@]}" "${ipaddrs[@]}" ) if (( ! ${#ipaddrs[*]} )) then