From 6d703edd2e85ac16b8a6410dc4a9db2d296b5d4a Mon Sep 17 00:00:00 2001 From: Andrew Fitzgerald Date: Wed, 22 Nov 2023 13:19:13 -0800 Subject: [PATCH] check vote costs against block limits in would_fit (#34207) --- cost-model/src/cost_tracker.rs | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/cost-model/src/cost_tracker.rs b/cost-model/src/cost_tracker.rs index efdd86512..9d322d009 100644 --- a/cost-model/src/cost_tracker.rs +++ b/cost-model/src/cost_tracker.rs @@ -186,7 +186,9 @@ impl CostTracker { if self.vote_cost.saturating_add(cost) > self.vote_cost_limit { return Err(CostTrackerError::WouldExceedVoteMaxLimit); } - } else if self.block_cost.saturating_add(cost) > self.block_cost_limit { + } + + if self.block_cost.saturating_add(cost) > self.block_cost_limit { // check against the total package cost return Err(CostTrackerError::WouldExceedBlockMaxLimit); }