Switch to using hashbrown version of HashMap and (#2158)

HashSet for improved performance and memory usage

Cargo.lock

@@ -654,6 +654,15 @@ name = "half"
 version = "1.3.0"
 source = "registry+https://github.com/rust-lang/crates.io-index"
 
+[[package]]
+name = "hashbrown"
+version = "0.1.7"
+source = "registry+https://github.com/rust-lang/crates.io-index"
+dependencies = [
+ "byteorder 1.2.7 (registry+https://github.com/rust-lang/crates.io-index)",
+ "scopeguard 0.3.3 (registry+https://github.com/rust-lang/crates.io-index)",
+]
+
 [[package]]
 name = "hex-literal"
 version = "0.1.1"
@@ -1732,6 +1741,7 @@ dependencies = [
  "clap 2.32.0 (registry+https://github.com/rust-lang/crates.io-index)",
  "dirs 1.0.4 (registry+https://github.com/rust-lang/crates.io-index)",
  "generic-array 0.12.0 (registry+https://github.com/rust-lang/crates.io-index)",
+ "hashbrown 0.1.7 (registry+https://github.com/rust-lang/crates.io-index)",
  "hex-literal 0.1.1 (registry+https://github.com/rust-lang/crates.io-index)",
  "indexmap 1.0.2 (registry+https://github.com/rust-lang/crates.io-index)",
  "ipnetwork 0.12.8 (registry+https://github.com/rust-lang/crates.io-index)",
@@ -2798,6 +2808,7 @@ dependencies = [
 "checksum globset 0.4.2 (registry+https://github.com/rust-lang/crates.io-index)" = "4743617a7464bbda3c8aec8558ff2f9429047e025771037df561d383337ff865"
 "checksum h2 0.1.13 (registry+https://github.com/rust-lang/crates.io-index)" = "7dd33bafe2e6370e6c8eb0cf1b8c5f93390b90acde7e9b03723f166b28b648ed"
 "checksum half 1.3.0 (registry+https://github.com/rust-lang/crates.io-index)" = "9353c2a89d550b58fa0061d8ed8d002a7d8cdf2494eb0e432859bd3a9e543836"
+"checksum hashbrown 0.1.7 (registry+https://github.com/rust-lang/crates.io-index)" = "64b7d419d0622ae02fe5da6b9a5e1964b610a65bb37923b976aeebb6dbb8f86e"
 "checksum hex-literal 0.1.1 (registry+https://github.com/rust-lang/crates.io-index)" = "4da5f0e01bd8a71a224a4eedecaacfcabda388dbb7a80faf04d3514287572d95"
 "checksum hex-literal-impl 0.1.1 (registry+https://github.com/rust-lang/crates.io-index)" = "1d340b6514f232f6db1bd16db65302a5278a04fef9ce867cb932e7e5fa21130a"
 "checksum http 0.1.14 (registry+https://github.com/rust-lang/crates.io-index)" = "02096a6d2c55e63f7fcb800690e4f889a25f6ec342e3adb4594e293b625215ab"

Cargo.toml

@@ -76,6 +76,7 @@ solana-vote-signer = { path = "vote-signer", version = "0.0.1" }
 tokio = "0.1"
 tokio-codec = "0.1"
 untrusted = "0.6.2"
+hashbrown = "0.1.7"
 
 [[bench]]
 name = "bank"

src/bank.rs

@@ -16,6 +16,7 @@ use crate::runtime::{self, RuntimeError};
 use crate::storage_stage::StorageState;
 use bincode::deserialize;
 use bincode::serialize;
+use hashbrown::{HashMap, HashSet};
 use itertools::Itertools;
 use log::Level;
 use rayon::prelude::*;
@@ -38,7 +39,7 @@ use solana_sdk::token_program;
 use solana_sdk::transaction::Transaction;
 use solana_sdk::vote_program;
 use std;
-use std::collections::{BTreeMap, HashMap, HashSet, VecDeque};
+use std::collections::{BTreeMap, VecDeque};
 use std::result;
 use std::sync::atomic::{AtomicUsize, Ordering};
 use std::sync::{Arc, Mutex, RwLock};
@@ -207,7 +208,7 @@ pub struct Accounts {
 
 impl Accounts {
     /// Returns a read-only iterator over all known accounts
-    pub fn account_values(&self) -> std::collections::hash_map::Values<Pubkey, Account> {
+    pub fn account_values(&self) -> hashbrown::hash_map::Values<Pubkey, Account> {
         self.accounts.values()
     }
 

src/cluster_info.rs

@@ -27,6 +27,7 @@ use crate::rpc::RPC_PORT;
 use crate::streamer::{BlobReceiver, BlobSender};
 use crate::window::{SharedWindow, WindowIndex};
 use bincode::{deserialize, serialize};
+use hashbrown::HashMap;
 use log::Level;
 use rand::{thread_rng, Rng};
 use rayon::prelude::*;
@@ -35,7 +36,6 @@ use solana_sdk::hash::Hash;
 use solana_sdk::pubkey::Pubkey;
 use solana_sdk::signature::{Keypair, KeypairUtil, Signable, Signature};
 use solana_sdk::timing::{duration_as_ms, timestamp};
-use std::collections::HashMap;
 use std::io;
 use std::net::{IpAddr, Ipv4Addr, SocketAddr, UdpSocket};
 use std::sync::atomic::{AtomicBool, AtomicUsize, Ordering};

src/crds_gossip_pull.rs

@@ -16,12 +16,12 @@ use crate::crds_gossip_error::CrdsGossipError;
 use crate::crds_value::{CrdsValue, CrdsValueLabel};
 use crate::packet::BLOB_DATA_SIZE;
 use bincode::serialized_size;
+use hashbrown::HashMap;
 use rand;
 use rand::distributions::{Distribution, WeightedIndex};
 use solana_sdk::hash::Hash;
 use solana_sdk::pubkey::Pubkey;
 use std::cmp;
-use std::collections::HashMap;
 use std::collections::VecDeque;
 
 pub const CRDS_GOSSIP_PULL_CRDS_TIMEOUT_MS: u64 = 15000;

src/crds_gossip_push.rs

@@ -16,13 +16,13 @@ use crate::crds_gossip_error::CrdsGossipError;
 use crate::crds_value::{CrdsValue, CrdsValueLabel};
 use crate::packet::BLOB_DATA_SIZE;
 use bincode::serialized_size;
+use hashbrown::HashMap;
 use indexmap::map::IndexMap;
 use rand;
 use rand::seq::SliceRandom;
 use solana_sdk::hash::Hash;
 use solana_sdk::pubkey::Pubkey;
 use std::cmp;
-use std::collections::HashMap;
 
 pub const CRDS_GOSSIP_NUM_ACTIVE: usize = 30;
 pub const CRDS_GOSSIP_PUSH_FANOUT: usize = 6;

src/leader_scheduler.rs

@@ -7,6 +7,7 @@ use crate::entry::Entry;
 use crate::ledger::create_ticks;
 use bincode::serialize;
 use byteorder::{LittleEndian, ReadBytesExt};
+use hashbrown::HashSet;
 use solana_sdk::hash::{hash, Hash};
 use solana_sdk::pubkey::Pubkey;
 use solana_sdk::signature::{Keypair, KeypairUtil};
@@ -14,7 +15,6 @@ use solana_sdk::system_transaction::SystemTransaction;
 use solana_sdk::transaction::Transaction;
 use solana_sdk::vote_program::{self, Vote, VoteProgram};
 use solana_sdk::vote_transaction::VoteTransaction;
-use std::collections::HashSet;
 use std::io::Cursor;
 
 pub const DEFAULT_BOOTSTRAP_HEIGHT: u64 = 1000;
@@ -519,13 +519,13 @@ mod tests {
         DEFAULT_LEADER_ROTATION_INTERVAL, DEFAULT_SEED_ROTATION_INTERVAL,
     };
     use crate::mint::Mint;
+    use hashbrown::HashSet;
     use solana_sdk::hash::Hash;
     use solana_sdk::pubkey::Pubkey;
     use solana_sdk::signature::{Keypair, KeypairUtil};
     use solana_sdk::transaction::Transaction;
     use solana_sdk::vote_program::Vote;
     use solana_sdk::vote_transaction::VoteTransaction;
-    use std::collections::HashSet;
     use std::hash::Hash as StdHash;
     use std::iter::FromIterator;
 

src/lib.rs

@@ -77,6 +77,7 @@ pub mod window_service;
 #[cfg(any(feature = "chacha", feature = "cuda"))]
 #[macro_use]
 extern crate hex_literal;
+extern crate hashbrown;
 
 #[macro_use]
 extern crate log;

src/thin_client.rs

@@ -11,6 +11,7 @@ use crate::result::{Error, Result};
 use crate::rpc_request::{RpcClient, RpcRequest};
 use bincode::serialize;
 use bs58;
+use hashbrown::HashMap;
 use log::Level;
 use serde_json;
 use solana_metrics;
@@ -23,7 +24,6 @@ use solana_sdk::system_transaction::SystemTransaction;
 use solana_sdk::timing;
 use solana_sdk::transaction::Transaction;
 use std;
-use std::collections::HashMap;
 use std::io;
 use std::net::{SocketAddr, UdpSocket};
 use std::sync::atomic::AtomicBool;