remove println!, add check to keep it out (#2585)

* remove debugging prints

* remove println!, add check to keep it out

ci/test-checks.sh

@@ -13,7 +13,7 @@ _ cargo fmt --all -- --check
 _ cargo clippy --all -- --version
 _ cargo clippy --all -- --deny=warnings
 _ ci/audit.sh
-_ ci/nits.sh || true # TODO: remove || true once all println!s are expunged
+_ ci/nits.sh
 _ book/build.sh
 
 echo --- ok

src/bank.rs

@@ -1371,10 +1371,6 @@ mod tests {
         let keypair1 = Keypair::new();
         let keypair2 = Keypair::new();
         let keypair3 = Keypair::new();
-        println!("KP1 {:?}", keypair1.pubkey());
-        println!("KP2 {:?}", keypair2.pubkey());
-        println!("KP3 {:?}", keypair3.pubkey());
-        println!("GenesisBlock {:?}", mint_keypair.pubkey());
 
         // fund: put 4 in each of 1 and 2
         assert_matches!(

src/chacha.rs

@@ -76,7 +76,7 @@ pub fn chacha_cbc_encrypt_ledger(
 
                 chacha_cbc_encrypt(&buffer[..size], &mut encrypted_buffer[..size], &key, ivec);
                 if let Err(res) = out_file.write(&encrypted_buffer[..size]) {
-                    println!("Error writing file! {:?}", res);
+                    warn!("Error writing file! {:?}", res);
                     return Err(res);
                 }
 

src/erasure.rs

@@ -881,7 +881,6 @@ pub mod test {
                 (thread_rng().gen_range(2, 8) * 4) + 1
             };
 
-            eprintln!("data_len of {} is {}", i, data_len);
             w.set_size(data_len);
 
             for k in 0..data_len {
@@ -970,7 +969,6 @@ pub mod test {
         let num_blobs = NUM_DATA + 2;
         let mut window = setup_window_ledger(offset, num_blobs, true, DEFAULT_SLOT_HEIGHT);
 
-        println!("** whack data block:");
         // Test erasing a data block
         let erase_offset = offset % window.len();
 
@@ -1019,7 +1017,6 @@ pub mod test {
         let num_blobs = NUM_DATA + 2;
         let mut window = setup_window_ledger(offset, num_blobs, true, DEFAULT_SLOT_HEIGHT);
 
-        println!("** whack coding block and data block");
         // Tests erasing a coding block and a data block
         let coding_start = offset - (offset % NUM_DATA) + (NUM_DATA - NUM_CODING);
         let erase_offset = coding_start % window.len();

src/thin_client.rs

@@ -598,7 +598,6 @@ mod tests {
 
         const LAST: usize = 30;
         for run in 0..=LAST {
-            println!("Checking for account registered: {}", run);
             let account_user_data = client
                 .get_account_userdata(&vote_account_id)
                 .expect("Expected valid response for account userdata")