Remove TODOs (#6843)

This commit is contained in:
Michael Vines 2019-11-08 16:43:18 -07:00 committed by GitHub
parent 9c00ad9ff2
commit efdfc5c327
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
8 changed files with 5 additions and 22 deletions

View File

@ -1237,11 +1237,11 @@ pub fn app<'ab, 'v>(name: &str, about: &'ab str, version: &'v str) -> App<'ab, '
.arg(
Arg::with_name("program_location")
.index(1)
.value_name("PATH TO PROGRAM")
.value_name("PATH TO BPF PROGRAM")
.takes_value(true)
.required(true)
.help("/path/to/program.o"),
), // TODO: Add "loader" argument; current default is bpf_loader
),
)
.stake_subcommands()
.storage_subcommands()

View File

@ -520,5 +520,4 @@ mod tests {
}
);
}
// TODO: Add process tests
}

View File

@ -897,5 +897,4 @@ mod tests {
}
);
}
// TODO: Add process tests
}

View File

@ -310,5 +310,4 @@ mod tests {
}
);
}
// TODO: Add process tests
}

View File

@ -593,5 +593,4 @@ mod tests {
}
);
}
// TODO: Add process tests
}

View File

@ -1,16 +1,5 @@
//! The `tvu` module implements the Transaction Validation Unit, a
//! multi-stage transaction validation pipeline in software.
//!
//! 1. BlobFetchStage
//! - Incoming blobs are picked up from the TVU sockets and repair socket.
//! 2. RetransmitStage
//! - Blobs are windowed until a contiguous chunk is available. This stage also repairs and
//! retransmits blobs that are in the queue.
//! 3. ReplayStage
//! - Transactions in blobs are processed and applied to the bank.
//! - TODO We need to verify the signatures in the blobs.
//! 4. StorageStage
//! - Generating the keys used to encrypt the ledger and sample it for storage mining.
//! The `tvu` module implements the Transaction Validation Unit, a multi-stage transaction
//! validation pipeline in software.
use crate::blockstream_service::BlockstreamService;
use crate::cluster_info::ClusterInfo;

View File

@ -96,7 +96,6 @@ impl Index {
}
}
/// TODO: Mark: Change this when coding
impl CodingIndex {
pub fn present_in_bounds(&self, bounds: impl RangeBounds<u64>) -> usize {
self.index.range(bounds).count()

View File

@ -27,7 +27,6 @@ pub fn create_genesis_block_with_leader(
bootstrap_leader_pubkey: &Pubkey,
bootstrap_leader_stake_lamports: u64,
) -> GenesisBlockInfo {
let bootstrap_leader_lamports = BOOTSTRAP_LEADER_LAMPORTS; // TODO: pass this in as an argument?
let mint_keypair = Keypair::new();
let voting_keypair = Keypair::new();
let staking_keypair = Keypair::new();
@ -57,7 +56,7 @@ pub fn create_genesis_block_with_leader(
// airdrops at some point to cover fees...
(
*bootstrap_leader_pubkey,
Account::new(bootstrap_leader_lamports, 0, &system_program::id()),
Account::new(BOOTSTRAP_LEADER_LAMPORTS, 0, &system_program::id()),
),
// where votes go to
(voting_keypair.pubkey(), vote_account),