diff --git a/core/benches/banking_stage.rs b/core/benches/banking_stage.rs index a665451c3..90026cbc6 100644 --- a/core/benches/banking_stage.rs +++ b/core/benches/banking_stage.rs @@ -85,7 +85,7 @@ fn bench_consume_buffered(bencher: &mut Bencher) { // This tests the performance of buffering packets. // If the packet buffers are copied, performance will be poor. bencher.iter(move || { - let _ignored = BankingStage::consume_buffered_packets( + BankingStage::consume_buffered_packets( &my_pubkey, std::u128::MAX, &poh_recorder, diff --git a/ledger/src/bigtable_upload.rs b/ledger/src/bigtable_upload.rs index f1145a4ee..c7770fe17 100644 --- a/ledger/src/bigtable_upload.rs +++ b/ledger/src/bigtable_upload.rs @@ -159,7 +159,7 @@ pub async fn upload_confirmed_blocks( let (sender, receiver) = bounded(config.block_read_ahead_depth); let (slot_sender, slot_receiver) = unbounded(); - let _ = blocks_to_upload + blocks_to_upload .into_iter() .for_each(|b| slot_sender.send(b).unwrap()); drop(slot_sender); diff --git a/perf/benches/sigverify.rs b/perf/benches/sigverify.rs index fec6e2300..1d5263869 100644 --- a/perf/benches/sigverify.rs +++ b/perf/benches/sigverify.rs @@ -31,8 +31,7 @@ fn bench_sigverify_simple(bencher: &mut Bencher) { let recycler_out = Recycler::default(); // verify packets bencher.iter(|| { - let _ans = - sigverify::ed25519_verify(&mut batches, &recycler, &recycler_out, false, num_packets); + sigverify::ed25519_verify(&mut batches, &recycler, &recycler_out, false, num_packets); }) } @@ -79,8 +78,7 @@ fn bench_sigverify_uneven(bencher: &mut Bencher) { let recycler_out = Recycler::default(); // verify packets bencher.iter(|| { - let _ans = - sigverify::ed25519_verify(&mut batches, &recycler, &recycler_out, false, num_packets); + sigverify::ed25519_verify(&mut batches, &recycler, &recycler_out, false, num_packets); }) } diff --git a/programs/bpf_loader/src/serialization.rs b/programs/bpf_loader/src/serialization.rs index bcc0ba8b1..4b2f09626 100644 --- a/programs/bpf_loader/src/serialization.rs +++ b/programs/bpf_loader/src/serialization.rs @@ -183,14 +183,14 @@ pub fn deserialize_parameters_unaligned( start += size_of::(); // is_signer start += size_of::(); // is_writable start += size_of::(); // key - let _ = borrowed_account.set_lamports(LittleEndian::read_u64( + borrowed_account.set_lamports(LittleEndian::read_u64( buffer .get(start..) .ok_or(InstructionError::InvalidArgument)?, )); start += size_of::() // lamports + size_of::(); // data length - let _ = borrowed_account.set_data( + borrowed_account.set_data( buffer .get(start..start + pre_len) .ok_or(InstructionError::InvalidArgument)?, @@ -324,13 +324,13 @@ pub fn deserialize_parameters_aligned( + size_of::() // executable + 4 // padding to 128-bit aligned + size_of::(); // key - let _ = borrowed_account.set_owner( + borrowed_account.set_owner( buffer .get(start..start + size_of::()) .ok_or(InstructionError::InvalidArgument)?, ); start += size_of::(); // owner - let _ = borrowed_account.set_lamports(LittleEndian::read_u64( + borrowed_account.set_lamports(LittleEndian::read_u64( buffer .get(start..) .ok_or(InstructionError::InvalidArgument)?, @@ -358,7 +358,7 @@ pub fn deserialize_parameters_aligned( } data_end }; - let _ = borrowed_account.set_data( + borrowed_account.set_data( buffer .get(start..data_end) .ok_or(InstructionError::InvalidArgument)?, @@ -575,7 +575,7 @@ mod tests { .unwrap() .1 .set_owner(bpf_loader_deprecated::id()); - let _ = invoke_context + invoke_context .transaction_context .get_current_instruction_context() .unwrap() diff --git a/runtime/src/stake_account.rs b/runtime/src/stake_account.rs index 9ef7e8302..0cfd8b5fd 100644 --- a/runtime/src/stake_account.rs +++ b/runtime/src/stake_account.rs @@ -125,7 +125,7 @@ impl AbiExample for StakeAccount { let mut account = Account::example(); account.data.resize(196, 0u8); account.owner = solana_stake_program::id(); - let _ = account.set_state(&stake_state).unwrap(); + account.set_state(&stake_state).unwrap(); Self::try_from(AccountSharedData::from(account)).unwrap() } } diff --git a/send-transaction-service/src/send_transaction_service.rs b/send-transaction-service/src/send_transaction_service.rs index 5596f51fc..65e1b2ce0 100644 --- a/send-transaction-service/src/send_transaction_service.rs +++ b/send-transaction-service/src/send_transaction_service.rs @@ -446,7 +446,7 @@ impl SendTransactionService { stats .sent_transactions .fetch_add(transactions.len() as u64, Ordering::Relaxed); - let _result = Self::send_transactions_in_batch( + Self::send_transactions_in_batch( &tpu_address, &mut transactions, leader_info_provider.lock().unwrap().get_leader_info(),