9076348ef4
When a leader is packing a Bank, transactions costs are added to the CostTracker and then later updated or removed, depending on if the tx is committed. However, it is possible for a Bank to be frozen while there are several tx's in flight. CostUpdateService submits a metric with cost information almost immediately after a Bank has been frozen. The result is that we have observed cost details being submitted before some cost removals take place, which causes a massive over-reporting of the block cost compared to actual. This PR adds a field to track the number of transactions that are inflight, and adds a simple mechanism to try to allow that value to settle to zero before submitting the datapoint. The number of inflight tx's is submitted with the datapoint, so even if the value does not settle to zero, we can still detect this case and know the metric is tainted. Co-authored-by: Andrew Fitzgerald <apfitzge@gmail.com> |
||
|---|---|---|
| .buildkite | ||
| .github | ||
| account-decoder | ||
| accounts-bench | ||
| accounts-cluster-bench | ||
| accounts-db | ||
| banking-bench | ||
| banks-client | ||
| banks-interface | ||
| banks-server | ||
| bench-streamer | ||
| bench-tps | ||
| bloom | ||
| bucket_map | ||
| cargo-registry | ||
| cd | ||
| ci | ||
| clap-utils | ||
| clap-v3-utils | ||
| cli | ||
| cli-config | ||
| cli-output | ||
| client | ||
| client-test | ||
| connection-cache | ||
| core | ||
| cost-model | ||
| docs | ||
| dos | ||
| download-utils | ||
| entry | ||
| faucet | ||
| frozen-abi | ||
| genesis | ||
| genesis-utils | ||
| geyser-plugin-interface | ||
| geyser-plugin-manager | ||
| gossip | ||
| install | ||
| keygen | ||
| ledger | ||
| ledger-tool | ||
| local-cluster | ||
| log-analyzer | ||
| logger | ||
| measure | ||
| memory-management | ||
| merkle-root-bench | ||
| merkle-tree | ||
| metrics | ||
| multinode-demo | ||
| net | ||
| net-shaper | ||
| net-utils | ||
| notifier | ||
| perf | ||
| poh | ||
| poh-bench | ||
| program-runtime | ||
| program-test | ||
| programs | ||
| pubsub-client | ||
| quic-client | ||
| rayon-threadlimit | ||
| rbpf-cli | ||
| remote-wallet | ||
| rpc | ||
| rpc-client | ||
| rpc-client-api | ||
| rpc-client-nonce-utils | ||
| rpc-test | ||
| runtime | ||
| runtime-transaction | ||
| scripts | ||
| sdk | ||
| send-transaction-service | ||
| stake-accounts | ||
| storage-bigtable | ||
| storage-proto | ||
| streamer | ||
| svm | ||
| system-test | ||
| test-validator | ||
| thin-client | ||
| tokens | ||
| tpu-client | ||
| transaction-dos | ||
| transaction-status | ||
| turbine | ||
| udp-client | ||
| unified-scheduler-logic | ||
| unified-scheduler-pool | ||
| upload-perf | ||
| validator | ||
| version | ||
| vote | ||
| watchtower | ||
| web3.js | ||
| wen-restart | ||
| zk-keygen | ||
| zk-token-sdk | ||
| .clippy.toml | ||
| .codecov.yml | ||
| .gitignore | ||
| .mergify.yml | ||
| CHANGELOG.md | ||
| CONTRIBUTING.md | ||
| Cargo.lock | ||
| Cargo.toml | ||
| LICENSE | ||
| README.md | ||
| RELEASE.md | ||
| SECURITY.md | ||
| cargo | ||
| cargo-build-bpf | ||
| cargo-build-sbf | ||
| cargo-test-bpf | ||
| cargo-test-sbf | ||
| fetch-perf-libs.sh | ||
| fetch-spl.sh | ||
| nextest.toml | ||
| run.sh | ||
| rust-toolchain.toml | ||
| rustfmt.toml | ||
| test-abi.sh | ||
| vercel.json | ||
README.md
Building
1. Install rustc, cargo and rustfmt.
$ curl https://sh.rustup.rs -sSf | sh
$ source $HOME/.cargo/env
$ rustup component add rustfmt
When building the master branch, please make sure you are using the latest stable rust version by running:
$ rustup update
When building a specific release branch, you should check the rust version in ci/rust-version.sh and if necessary, install that version by running:
$ rustup install VERSION
Note that if this is not the latest rust version on your machine, cargo commands may require an override in order to use the correct version.
On Linux systems you may need to install libssl-dev, pkg-config, zlib1g-dev, protobuf etc.
On Ubuntu:
$ sudo apt-get update
$ sudo apt-get install libssl-dev libudev-dev pkg-config zlib1g-dev llvm clang cmake make libprotobuf-dev protobuf-compiler
On Fedora:
$ sudo dnf install openssl-devel systemd-devel pkg-config zlib-devel llvm clang cmake make protobuf-devel protobuf-compiler perl-core
2. Download the source code.
$ git clone https://github.com/solana-labs/solana.git
$ cd solana
3. Build.
$ ./cargo build
Testing
Run the test suite:
$ ./cargo test
Starting a local testnet
Start your own testnet locally, instructions are in the online docs.
Accessing the remote development cluster
devnet- stable public cluster for development accessible via devnet.solana.com. Runs 24/7. Learn more about the public clusters
Benchmarking
First, install the nightly build of rustc. cargo bench requires the use of the
unstable features only available in the nightly build.
$ rustup install nightly
Run the benchmarks:
$ cargo +nightly bench
Release Process
The release process for this project is described here.
Code coverage
To generate code coverage statistics:
$ scripts/coverage.sh
$ open target/cov/lcov-local/index.html
Why coverage? While most see coverage as a code quality metric, we see it primarily as a developer productivity metric. When a developer makes a change to the codebase, presumably it's a solution to some problem. Our unit-test suite is how we encode the set of problems the codebase solves. Running the test suite should indicate that your change didn't infringe on anyone else's solutions. Adding a test protects your solution from future changes. Say you don't understand why a line of code exists, try deleting it and running the unit-tests. The nearest test failure should tell you what problem was solved by that code. If no test fails, go ahead and submit a Pull Request that asks, "what problem is solved by this code?" On the other hand, if a test does fail and you can think of a better way to solve the same problem, a Pull Request with your solution would most certainly be welcome! Likewise, if rewriting a test can better communicate what code it's protecting, please send us that patch!