separate check_transaction_age from check_age (#30994)

runtime/src/bank.rs

@@ -3936,24 +3936,39 @@ impl Bank {
 
         txs.zip(lock_results)
             .map(|(tx, lock_res)| match lock_res {
-                Ok(()) => {
+                Ok(()) => self.check_transaction_age(
-                    let recent_blockhash = tx.message().recent_blockhash();
+                    tx,
-                    if hash_queue.is_hash_valid_for_age(recent_blockhash, max_age) {
+                    max_age,
-                        (Ok(()), None)
+                    &next_durable_nonce,
-                    } else if let Some((address, account)) =
+                    &hash_queue,
-                        self.check_transaction_for_nonce(tx, &next_durable_nonce)
+                    error_counters,
-                    {
+                ),
-                        (Ok(()), Some(NoncePartial::new(address, account)))
-                    } else {
-                        error_counters.blockhash_not_found += 1;
-                        (Err(TransactionError::BlockhashNotFound), None)
-                    }
-                }
                 Err(e) => (Err(e.clone()), None),
             })
             .collect()
     }
 
+    fn check_transaction_age(
+        &self,
+        tx: &SanitizedTransaction,
+        max_age: usize,
+        next_durable_nonce: &DurableNonce,
+        hash_queue: &BlockhashQueue,
+        error_counters: &mut TransactionErrorMetrics,
+    ) -> TransactionCheckResult {
+        let recent_blockhash = tx.message().recent_blockhash();
+        if hash_queue.is_hash_valid_for_age(recent_blockhash, max_age) {
+            (Ok(()), None)
+        } else if let Some((address, account)) =
+            self.check_transaction_for_nonce(tx, next_durable_nonce)
+        {
+            (Ok(()), Some(NoncePartial::new(address, account)))
+        } else {
+            error_counters.blockhash_not_found += 1;
+            (Err(TransactionError::BlockhashNotFound), None)
+        }
+    }
+
     fn is_transaction_already_processed(
         &self,
         sanitized_tx: &SanitizedTransaction,