blockworks-foundation
/
solana
mirror of https://github.com/blockworks-foundation/solana.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Review comments

This commit is contained in:
Tyera Eulberg 2019-03-07 15:58:11 -07:00 committed by Tyera Eulberg
parent e888c90ecf
commit 259c820f15
3 changed files with 11 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
book/src/jsonrpc-api.md
View File

@ -254,7 +254,8 @@ After connect to the RPC PubSub websocket at `ws://<ADDRESS>/`:
---
### accountSubscribe
Subscribe to an account to receive notifications when the userdata for a given account public key changes
Subscribe to an account to receive notifications when the lamports or userdata
for a given account public key changes
##### Parameters:
* `string` - account Pubkey, as base-58 encoded string
@ -279,7 +280,7 @@ Subscribe to an account to receive notifications when the userdata for a given a
---
### accountUnsubscribe
Unsubscribe from account userdata change notifications
Unsubscribe from account change notifications
##### Parameters:
* `integer` - id of account Subscription to cancel
@ -299,7 +300,8 @@ Unsubscribe from account userdata change notifications
---
### programSubscribe
Subscribe to a program to receive notifications when the userdata for a given account owned by the program changes
Subscribe to a program to receive notifications when the lamports or userdata
for a given account owned by the program changes
##### Parameters:
* `string` - program_id Pubkey, as base-58 encoded string

6
core/src/rpc_subscriptions.rs
View File

@ -176,10 +176,8 @@ impl RpcSubscriptions {
};
for program_id in &programs {
let accounts = &bank.get_program_accounts_modified_since_parent(program_id);
if !accounts.is_empty() {
for (pubkey, account) in accounts.iter() {
self.check_program(program_id, pubkey, account);
}
for (pubkey, account) in accounts.iter() {
self.check_program(program_id, pubkey, account);
}
}

8
runtime/src/accounts.rs
View File

@ -842,21 +842,21 @@ impl Accounts {
self.accounts_db.add_fork(fork, Some(parent));
}
/// Slow because lock is held for 1 operation insted of many
/// Slow because lock is held for 1 operation instead of many
pub fn load_slow(&self, fork: Fork, pubkey: &Pubkey) -> Option<Account> {
self.accounts_db
.load(fork, pubkey, true)
.filter(|acc| acc.lamports != 0)
}
/// Slow because lock is held for 1 operation insted of many
/// Slow because lock is held for 1 operation instead of many
pub fn load_slow_no_parent(&self, fork: Fork, pubkey: &Pubkey) -> Option<Account> {
self.accounts_db
.load(fork, pubkey, false)
.filter(|acc| acc.lamports != 0)
}
/// Slow because lock is held for 1 operation insted of many
/// Slow because lock is held for 1 operation instead of many
pub fn load_by_program_slow_no_parent(
&self,
fork: Fork,
@ -869,7 +869,7 @@ impl Accounts {
.collect()
}
/// Slow because lock is held for 1 operation insted of many
/// Slow because lock is held for 1 operation instead of many
pub fn store_slow(&self, fork: Fork, pubkey: &Pubkey, account: &Account) {
self.accounts_db.store(fork, pubkey, account);
}