From 3ef961fe3700e72a4ef2985293bdb9d08398a7b5 Mon Sep 17 00:00:00 2001 From: Pankaj Garg Date: Fri, 3 May 2019 16:41:19 -0700 Subject: [PATCH] Record poh ticks even when the node is not in leader schedule (#4148) * remove obsolete test --- core/src/poh_recorder.rs | 25 +++---------------------- 1 file changed, 3 insertions(+), 22 deletions(-) diff --git a/core/src/poh_recorder.rs b/core/src/poh_recorder.rs index 72bb2debba..fa9dac5e4f 100644 --- a/core/src/poh_recorder.rs +++ b/core/src/poh_recorder.rs @@ -272,12 +272,13 @@ impl PohRecorder { } pub fn tick(&mut self) { + let tick = self.generate_tick(); + trace!("tick {}", tick.1); + if self.start_leader_at_tick.is_none() { return; } - let tick = self.generate_tick(); - trace!("tick {}", tick.1); self.tick_cache.push(tick); let _ = self.flush_cache(true); } @@ -1026,16 +1027,6 @@ mod tests { // Test that with no leader slot, we don't reach the leader tick assert_eq!(poh_recorder.reached_leader_tick().0, false); - for _ in 0..bank.ticks_per_slot() { - poh_recorder.tick(); - } - - // Tick should not be recorded - assert_eq!(poh_recorder.tick_height(), 0); - - // Test that with no leader slot, we don't reach the leader tick after sending some ticks - assert_eq!(poh_recorder.reached_leader_tick().0, false); - poh_recorder.reset( poh_recorder.tick_height(), bank.last_blockhash(), @@ -1200,16 +1191,6 @@ mod tests { false ); - for _ in 0..bank.ticks_per_slot() { - poh_recorder.tick(); - } - - // Test that with no leader slot, we don't reach the leader tick after sending some ticks - assert_eq!( - poh_recorder.would_be_leader(2 * bank.ticks_per_slot()), - false - ); - poh_recorder.reset( poh_recorder.tick_height(), bank.last_blockhash(),