blockworks-foundation
/
solana
mirror of https://github.com/blockworks-foundation/solana.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Use Release/Acquire instead of SeqCst for is_bank_drop_callback_enabled (#24134)

This commit is contained in:
Brooks Prumo 2022-04-11 19:19:17 -05:00 committed by GitHub
parent 6fbe2b936c
commit 4fd184c131
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
runtime/src/accounts_db.rs
View File

@ -4037,7 +4037,7 @@ impl AccountsDb {
pruned_banks_sender: DroppedSlotsSender, pruned_banks_sender: DroppedSlotsSender,
) -> SendDroppedBankCallback { ) -> SendDroppedBankCallback {
self.is_bank_drop_callback_enabled self.is_bank_drop_callback_enabled
.store(true, Ordering::SeqCst); .store(true, Ordering::Release);
SendDroppedBankCallback::new(pruned_banks_sender) SendDroppedBankCallback::new(pruned_banks_sender)
} }
@ -4045,7 +4045,7 @@ impl AccountsDb {
/// comment below for more explanation. /// comment below for more explanation.
/// `is_from_abs` is true if the caller is the AccountsBackgroundService /// `is_from_abs` is true if the caller is the AccountsBackgroundService
pub fn purge_slot(&self, slot: Slot, bank_id: BankId, is_from_abs: bool) { pub fn purge_slot(&self, slot: Slot, bank_id: BankId, is_from_abs: bool) {
if self.is_bank_drop_callback_enabled.load(Ordering::SeqCst) && !is_from_abs { if self.is_bank_drop_callback_enabled.load(Ordering::Acquire) && !is_from_abs {
panic!("bad drop callpath detected; Bank::drop() must run serially with other logic in ABS like clean_accounts()") panic!("bad drop callpath detected; Bank::drop() must run serially with other logic in ABS like clean_accounts()")
} }
// BANK_DROP_SAFETY: Because this function only runs once the bank is dropped, // BANK_DROP_SAFETY: Because this function only runs once the bank is dropped,