blockworks-foundation
/
solana
mirror of https://github.com/blockworks-foundation/solana.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

zk-token-sdk: constant time equality check for elgamal and aes key derivation (#27364) 

zk-token-sdk: use constant time equality check for elgamal and aes key derivation
This commit is contained in:
samkim-crypto 2022-08-24 18:56:55 +09:00 committed by GitHub
parent 0ea984ae20
commit 5e8b8abd84
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
zk-token-sdk/src/encryption/auth_encryption.rs
View File

@ -16,6 +16,7 @@ use {
signer::{Signer, SignerError}, signer::{Signer, SignerError},
}, },
std::{convert::TryInto, fmt}, std::{convert::TryInto, fmt},
subtle::ConstantTimeEq,
zeroize::Zeroize, zeroize::Zeroize,
}; };
@ -71,7 +72,7 @@ impl AeKey {
// Some `Signer` implementations return the default signature, which is not suitable for // Some `Signer` implementations return the default signature, which is not suitable for
// use as key material // use as key material
if signature == Signature::default() { if bool::from(signature.as_ref().ct_eq(Signature::default().as_ref())) {
Err(SignerError::Custom("Rejecting default signature".into())) Err(SignerError::Custom("Rejecting default signature".into()))
} else { } else {
Ok(AeKey(signature.as_ref()[..16].try_into().unwrap())) Ok(AeKey(signature.as_ref()[..16].try_into().unwrap()))

2
zk-token-sdk/src/encryption/elgamal.rs
View File

@ -166,7 +166,7 @@ impl ElGamalKeypair {
// Some `Signer` implementations return the default signature, which is not suitable for // Some `Signer` implementations return the default signature, which is not suitable for
// use as key material // use as key material
if signature == Signature::default() { if bool::from(signature.as_ref().ct_eq(Signature::default().as_ref())) {
return Err(SignerError::Custom("Rejecting default signature".into())); return Err(SignerError::Custom("Rejecting default signature".into()));
} }