validators always skip clean/shrink on startup (#30710)

* validators always skip clean/shrink on startup

* move arg to get_deprecated_arguments
This commit is contained in:
Jeff Washington (jwash) 2023-03-14 13:41:15 -05:00 committed by GitHub
parent f528335ac0
commit 62fe6ea7a0
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 5 additions and 7 deletions

View File

@ -1185,12 +1185,6 @@ pub fn app<'a>(version: &'a str, default_args: &'a DefaultArgs) -> App<'a, 'a> {
.help("Debug option to scan all append vecs and verify account index refcounts prior to clean") .help("Debug option to scan all append vecs and verify account index refcounts prior to clean")
.hidden(true) .hidden(true)
) )
.arg(
Arg::with_name("accounts_db_skip_shrink")
.long("accounts-db-skip-shrink")
.help("Enables faster starting of validators by skipping shrink. \
This option is for use during testing."),
)
.arg( .arg(
Arg::with_name("accounts_db_create_ancient_storage_packed") Arg::with_name("accounts_db_create_ancient_storage_packed")
.long("accounts-db-create-ancient-storage-packed") .long("accounts-db-create-ancient-storage-packed")
@ -1560,6 +1554,10 @@ pub fn app<'a>(version: &'a str, default_args: &'a DefaultArgs) -> App<'a, 'a> {
// avoid breaking validator startup commands // avoid breaking validator startup commands
fn get_deprecated_arguments() -> Vec<Arg<'static, 'static>> { fn get_deprecated_arguments() -> Vec<Arg<'static, 'static>> {
vec![ vec![
Arg::with_name("accounts_db_skip_shrink")
.long("accounts-db-skip-shrink")
.help("This is obsolete since it is now enabled by default. Enables faster starting of validators by skipping startup clean and shrink.")
.hidden(true),
Arg::with_name("accounts_db_caching_enabled") Arg::with_name("accounts_db_caching_enabled")
.long("accounts-db-caching-enabled") .long("accounts-db-caching-enabled")
.hidden(true), .hidden(true),

View File

@ -1234,7 +1234,7 @@ pub fn main() {
account_indexes, account_indexes,
accounts_db_test_hash_calculation: matches.is_present("accounts_db_test_hash_calculation"), accounts_db_test_hash_calculation: matches.is_present("accounts_db_test_hash_calculation"),
accounts_db_config, accounts_db_config,
accounts_db_skip_shrink: matches.is_present("accounts_db_skip_shrink"), accounts_db_skip_shrink: true,
tpu_coalesce_ms, tpu_coalesce_ms,
no_wait_for_vote_to_start_leader: matches.is_present("no_wait_for_vote_to_start_leader"), no_wait_for_vote_to_start_leader: matches.is_present("no_wait_for_vote_to_start_leader"),
accounts_shrink_ratio, accounts_shrink_ratio,