From 79ab826678f357e3fc460808d41ca7954faac5ca Mon Sep 17 00:00:00 2001 From: Michael Vines Date: Thu, 23 Aug 2018 11:00:36 -0700 Subject: [PATCH] Lint tests --- web3.js/package.json | 6 +++--- web3.js/test/.eslintrc.js | 6 ++++++ web3.js/test/account.test.js | 4 ++-- 3 files changed, 11 insertions(+), 5 deletions(-) create mode 100644 web3.js/test/.eslintrc.js diff --git a/web3.js/package.json b/web3.js/package.json index 5d3a0259d7..556e38666f 100644 --- a/web3.js/package.json +++ b/web3.js/package.json @@ -35,11 +35,10 @@ "codecov": "npm run test:cover && cat ./coverage/lcov.info | codecov", "flow": "flow", "flow-typed": "npm run clean && flow-typed install --overwrite || true", - "lint": "eslint src examples", + "lint": "eslint src test examples", "prepublish": "npm run clean && npm run test && npm run flow && npm run lint && npm run doc && npm run build" }, - "dependencies": { - }, + "dependencies": {}, "devDependencies": { "babel-core": "6.26.0", "babel-eslint": "8.2.3", @@ -60,6 +59,7 @@ "esdoc-standard-plugin": "^1.0.0", "eslint": "4.19.1", "eslint-plugin-import": "2.11.0", + "eslint-plugin-jest": "^21.21.0", "eslint-plugin-jsx-a11y": "^6.1.1", "eslint-plugin-react": "^7.11.1", "flow-bin": "0.70.0", diff --git a/web3.js/test/.eslintrc.js b/web3.js/test/.eslintrc.js new file mode 100644 index 0000000000..ffb1f3bdbd --- /dev/null +++ b/web3.js/test/.eslintrc.js @@ -0,0 +1,6 @@ +module.exports = { // eslint-disable-line import/no-commonjs + 'extends': [ + "plugin:jest/recommended", + "../.eslintrc.js", + ] +}; diff --git a/web3.js/test/account.test.js b/web3.js/test/account.test.js index 0be0eff23a..8c18317081 100644 --- a/web3.js/test/account.test.js +++ b/web3.js/test/account.test.js @@ -3,8 +3,8 @@ import {Account} from '../src/account'; test('generate new account', () => { const account = new Account(); - const len = account.publicKey.length; - expect(len === 43 || len === 44); + expect(account.publicKey.length).toBeGreaterThanOrEqual(43); + expect(account.publicKey.length).toBeLessThanOrEqual(44); expect(account.secretKey).toHaveLength(64); });