Add make_connection metrics (#25280)

* Add metrics for open_uni

* Added metrics for make_connection

* measure make_connection success or fail

client/src/connection_cache.rs

@@ -73,6 +73,10 @@ impl ConnectionCacheStats {
             client_stats.zero_rtt_rejects.load(Ordering::Relaxed),
             Ordering::Relaxed,
         );
+        self.total_client_stats.make_connection_ms.fetch_add(
+            client_stats.make_connection_ms.load(Ordering::Relaxed),
+            Ordering::Relaxed,
+        );
         self.sent_packets
             .fetch_add(num_packets as u64, Ordering::Relaxed);
         self.total_batches.fetch_add(1, Ordering::Relaxed);
@@ -126,6 +130,13 @@ impl ConnectionCacheStats {
                 self.get_connection_miss_ms.swap(0, Ordering::Relaxed),
                 i64
             ),
+            (
+                "make_connection_ms",
+                self.total_client_stats
+                    .make_connection_ms
+                    .swap(0, Ordering::Relaxed),
+                i64
+            ),
             (
                 "total_connections",
                 self.total_client_stats

client/src/quic_client.rs

@@ -15,6 +15,7 @@ use {
         ClientConfig, Endpoint, EndpointConfig, IdleTimeout, NewConnection, VarInt, WriteError,
     },
     quinn_proto::ConnectionStats,
+    solana_measure::measure::Measure,
     solana_net_utils::VALIDATOR_PORT_RANGE,
     solana_sdk::{
         quic::{
@@ -69,6 +70,7 @@ struct QuicNewConnection {
 impl QuicNewConnection {
     /// Create a QuicNewConnection given the remote address 'addr'.
     async fn make_connection(addr: SocketAddr, stats: &ClientStats) -> Result<Self, WriteError> {
+        let mut make_connection_measure = Measure::start("make_connection_measure");
         let (_, client_socket) = solana_net_utils::bind_in_range(
             IpAddr::V4(Ipv4Addr::new(0, 0, 0, 0)),
             VALIDATOR_PORT_RANGE,
@@ -98,6 +100,11 @@ impl QuicNewConnection {
         if connecting_result.is_err() {
             stats.connection_errors.fetch_add(1, Ordering::Relaxed);
         }
+        make_connection_measure.stop();
+        stats
+            .make_connection_ms
+            .fetch_add(make_connection_measure.as_ms(), Ordering::Relaxed);
+
         let connection = connecting_result?;
 
         Ok(Self {
@@ -257,7 +264,15 @@ impl QuicClient {
         data: &[u8],
         connection: &NewConnection,
     ) -> Result<(), WriteError> {
+        let mut open_uni_measure = Measure::start("open_uni_measure");
         let mut send_stream = connection.connection.open_uni().await?;
+        open_uni_measure.stop();
+
+        datapoint_info!(
+            "quic-client-connection-stats",
+            ("open_uni_ms", open_uni_measure.as_ms(), i64)
+        );
+
         send_stream.write_all(data).await?;
         send_stream.finish().await?;
         Ok(())

client/src/tpu_connection.rs

@@ -21,6 +21,7 @@ pub struct ClientStats {
     pub tx_streams_blocked_uni: MovingStat,
     pub tx_data_blocked: MovingStat,
     pub tx_acks: MovingStat,
+    pub make_connection_ms: AtomicU64,
 }
 
 pub trait TpuConnection {