blockworks-foundation
/
solana
mirror of https://github.com/blockworks-foundation/solana.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Restore elaborate attack 

The test is showing how you can sneak by verify_plan() but not
verify_signature().
This commit is contained in:
Greg Fitzgerald 2018-10-17 23:28:13 -06:00
parent 2045091c4f
commit 856c48541f
1 changed files with 11 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
src/budget_transaction.rs
View File

@ -317,14 +317,19 @@ mod tests {
let keypair = Keypair::new(); let keypair = Keypair::new();
let pubkey = keypair.pubkey(); let pubkey = keypair.pubkey();
let mut tx = Transaction::budget_new(&keypair, pubkey, 42, zero); let mut tx = Transaction::budget_new(&keypair, pubkey, 42, zero);
let mut instruction = tx.instruction(1).unwrap(); let mut system_instruction = tx.system_instruction(0).unwrap();
if let Instruction::NewBudget(ref mut budget) = instruction { if let SystemProgram::Move { ref mut tokens } = system_instruction {
if let Budget::Pay(ref mut payment) = budget { *tokens = 1_000_000; // <-- attack, part 1!
payment.tokens = 1_000_000; // <-- attack! let mut instruction = tx.instruction(1).unwrap();
if let Instruction::NewBudget(ref mut budget) = instruction {
if let Budget::Pay(ref mut payment) = budget {
payment.tokens = *tokens; // <-- attack, part 2!
}
} }
tx.instructions[1].userdata = serialize(&instruction).unwrap();
} }
tx.instructions[1].userdata = serialize(&instruction).unwrap(); tx.instructions[0].userdata = serialize(&system_instruction).unwrap();
assert!(!tx.verify_plan()); assert!(tx.verify_plan());
assert!(!tx.verify_signature()); assert!(!tx.verify_signature());
} }