remove recommendations to skip validator startup tests on failure (#30250)

This commit is contained in:
Trent Nelson 2023-02-10 18:14:47 -07:00 committed by GitHub
parent 06617d719c
commit 8770b15bb2
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 8 additions and 6 deletions

View File

@ -405,9 +405,7 @@ impl Validator {
if !config.no_os_network_stats_reporting { if !config.no_os_network_stats_reporting {
if let Err(e) = verify_net_stats_access() { if let Err(e) = verify_net_stats_access() {
return Err(format!( return Err(format!("Failed to access Network stats: {e}",));
"Failed to access Network stats: {e}. Bypass check with --no-os-network-stats-reporting.",
));
} }
} }
@ -1267,8 +1265,7 @@ fn check_poh_speed(
info!("PoH speed check: Will sleep {}ns per slot.", extra_ns); info!("PoH speed check: Will sleep {}ns per slot.", extra_ns);
} else { } else {
return Err(format!( return Err(format!(
"PoH is slower than cluster target tick rate! mine: {my_ns_per_slot} cluster: {target_ns_per_slot}. \ "PoH is slower than cluster target tick rate! mine: {my_ns_per_slot} cluster: {target_ns_per_slot}.",
If you wish to continue, try --no-poh-speed-test",
)); ));
} }
} }

View File

@ -486,6 +486,7 @@ pub fn app<'a>(version: &'a str, default_args: &'a DefaultArgs) -> App<'a, 'a> {
.arg( .arg(
Arg::with_name("no_poh_speed_test") Arg::with_name("no_poh_speed_test")
.long("no-poh-speed-test") .long("no-poh-speed-test")
.hidden(true)
.help("Skip the check for PoH speed."), .help("Skip the check for PoH speed."),
) )
.arg( .arg(
@ -497,21 +498,25 @@ pub fn app<'a>(version: &'a str, default_args: &'a DefaultArgs) -> App<'a, 'a> {
.arg( .arg(
Arg::with_name("no_os_memory_stats_reporting") Arg::with_name("no_os_memory_stats_reporting")
.long("no-os-memory-stats-reporting") .long("no-os-memory-stats-reporting")
.hidden(true)
.help("Disable reporting of OS memory statistics.") .help("Disable reporting of OS memory statistics.")
) )
.arg( .arg(
Arg::with_name("no_os_network_stats_reporting") Arg::with_name("no_os_network_stats_reporting")
.long("no-os-network-stats-reporting") .long("no-os-network-stats-reporting")
.hidden(true)
.help("Disable reporting of OS network statistics.") .help("Disable reporting of OS network statistics.")
) )
.arg( .arg(
Arg::with_name("no_os_cpu_stats_reporting") Arg::with_name("no_os_cpu_stats_reporting")
.long("no-os-cpu-stats-reporting") .long("no-os-cpu-stats-reporting")
.hidden(true)
.help("Disable reporting of OS CPU statistics.") .help("Disable reporting of OS CPU statistics.")
) )
.arg( .arg(
Arg::with_name("no_os_disk_stats_reporting") Arg::with_name("no_os_disk_stats_reporting")
.long("no-os-disk-stats-reporting") .long("no-os-disk-stats-reporting")
.hidden(true)
.help("Disable reporting of OS disk statistics.") .help("Disable reporting of OS disk statistics.")
) )
.arg( .arg(

View File

@ -1503,7 +1503,7 @@ pub fn main() {
if SystemMonitorService::check_os_network_limits() { if SystemMonitorService::check_os_network_limits() {
info!("OS network limits test passed."); info!("OS network limits test passed.");
} else { } else {
eprintln!("OS network limit test failed. solana-sys-tuner may be used to configure OS network limits. Bypass check with --no-os-network-limits-test."); eprintln!("OS network limit test failed. See: https://docs.solana.com/running-validator/validator-start#system-tuning");
exit(1); exit(1);
} }
} }