From 9044cd7179788ee82deb5bd18be888907f73c690 Mon Sep 17 00:00:00 2001
From: HaoranYi <haoran.yi@gmail.com>
Date: Mon, 25 Apr 2022 19:17:21 -0500
Subject: [PATCH] Check insert optimization for bank_forks (#24641)

* check insert optimization

* clippy suggested simplification
---
 runtime/src/bank_forks.rs | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/runtime/src/bank_forks.rs b/runtime/src/bank_forks.rs
index d6c123abac..5a20b004b8 100644
--- a/runtime/src/bank_forks.rs
+++ b/runtime/src/bank_forks.rs
@@ -131,11 +131,10 @@ impl BankForks {
             banks.insert(bank.slot(), bank.clone());
             let parents = bank.parents();
             for parent in parents {
-                if banks.contains_key(&parent.slot()) {
+                if banks.insert(parent.slot(), parent.clone()).is_some() {
                     // All ancestors have already been inserted by another fork
                     break;
                 }
-                banks.insert(parent.slot(), parent.clone());
             }
         }
         let mut descendants = HashMap::<_, HashSet<_>>::new();