Upgrades Rust to 1.72.0 & nightly-2023-08-25 (#32961)

* allow pedantic invalid cast lint

* allow lint with false-positive triggered by `test-case` crate

* nightly `fmt` correction

* adapt to rust layout changes

* remove dubious test

* Use transmute instead of pointer cast and de/ref when check_aligned is false.

* Renames clippy::integer_arithmetic to clippy::arithmetic_side_effects.

* bump rust nightly to 2023-08-25

* Upgrades Rust to 1.72.0

---------

Co-authored-by: Trent Nelson <trent@solana.com>

account-decoder/src/lib.rs

@@ -1,4 +1,4 @@
-#![allow(clippy::integer_arithmetic)]
+#![allow(clippy::arithmetic_side_effects)]
 #[macro_use]
 extern crate lazy_static;
 #[macro_use]

accounts-bench/src/main.rs

@@ -1,4 +1,4 @@
-#![allow(clippy::integer_arithmetic)]
+#![allow(clippy::arithmetic_side_effects)]
 
 #[macro_use]
 extern crate log;

accounts-cluster-bench/src/main.rs

@@ -1,4 +1,4 @@
-#![allow(clippy::integer_arithmetic)]
+#![allow(clippy::arithmetic_side_effects)]
 use {
     clap::{crate_description, crate_name, value_t, values_t_or_exit, App, Arg},
     log::*,

accounts-db/src/append_vec.rs

@@ -694,6 +694,7 @@ pub mod tests {
         fn set_data_len_unsafe(&self, new_data_len: u64) {
             // UNSAFE: cast away & (= const ref) to &mut to force to mutate append-only (=read-only) AppendVec
             unsafe {
+                #[allow(invalid_reference_casting)]
                 std::ptr::write(
                     std::mem::transmute::<*const u64, *mut u64>(&self.meta.data_len),
                     new_data_len,
@@ -711,6 +712,7 @@ pub mod tests {
         fn set_executable_as_byte(&self, new_executable_byte: u8) {
             // UNSAFE: Force to interpret mmap-backed &bool as &u8 to write some crafted value;
             unsafe {
+                #[allow(invalid_reference_casting)]
                 std::ptr::write(
                     std::mem::transmute::<*const bool, *mut u8>(&self.account_meta.executable),
                     new_executable_byte,

accounts-db/src/lib.rs

@@ -1,5 +1,5 @@
 #![cfg_attr(RUSTC_WITH_SPECIALIZATION, feature(min_specialization))]
-#![allow(clippy::integer_arithmetic)]
+#![allow(clippy::arithmetic_side_effects)]
 
 #[macro_use]
 extern crate lazy_static;

banking-bench/src/main.rs

@@ -1,4 +1,4 @@
-#![allow(clippy::integer_arithmetic)]
+#![allow(clippy::arithmetic_side_effects)]
 use {
     clap::{crate_description, crate_name, Arg, ArgEnum, Command},
     crossbeam_channel::{unbounded, Receiver},

banks-server/src/lib.rs

@@ -1,2 +1,2 @@
-#![allow(clippy::integer_arithmetic)]
+#![allow(clippy::arithmetic_side_effects)]
 pub mod banks_server;

bench-streamer/src/main.rs

@@ -1,4 +1,4 @@
-#![allow(clippy::integer_arithmetic)]
+#![allow(clippy::arithmetic_side_effects)]
 
 use {
     clap::{crate_description, crate_name, Arg, Command},

bench-tps/src/lib.rs

@@ -1,4 +1,4 @@
-#![allow(clippy::integer_arithmetic)]
+#![allow(clippy::arithmetic_side_effects)]
 pub mod bench;
 pub mod bench_tps_client;
 pub mod cli;

bench-tps/src/main.rs

@@ -1,4 +1,4 @@
-#![allow(clippy::integer_arithmetic)]
+#![allow(clippy::arithmetic_side_effects)]
 use {
     clap::value_t,
     log::*,

bench-tps/tests/bench_tps.rs

@@ -1,4 +1,4 @@
-#![allow(clippy::integer_arithmetic)]
+#![allow(clippy::arithmetic_side_effects)]
 
 use {
     serial_test::serial,

bucket_map/src/lib.rs

@@ -1,4 +1,4 @@
-#![allow(clippy::integer_arithmetic)]
+#![allow(clippy::arithmetic_side_effects)]
 mod bucket;
 pub mod bucket_api;
 mod bucket_item;

ci/docker-rust-nightly/Dockerfile

@@ -1,4 +1,4 @@
-FROM solanalabs/rust:1.69.0
+FROM solanalabs/rust:1.72.0
 ARG date
 
 RUN set -x \

ci/docker-rust/Dockerfile

@@ -1,6 +1,6 @@
 # Note: when the rust version is changed also modify
 # ci/rust-version.sh to pick up the new image tag
-FROM rust:1.69.0
+FROM rust:1.72.0
 
 RUN set -x \
  && apt update \

ci/rust-version.sh

@@ -29,7 +29,7 @@ fi
 if [[ -n $RUST_NIGHTLY_VERSION ]]; then
   nightly_version="$RUST_NIGHTLY_VERSION"
 else
-  nightly_version=2023-04-19
+  nightly_version=2023-08-25
 fi
 
 

ci/test-checks.sh

@@ -73,7 +73,7 @@ nightly_clippy_allows=(--allow=clippy::redundant_clone)
 _ scripts/cargo-for-all-lock-files.sh -- "+${rust_nightly}" clippy --workspace --all-targets --features dummy-for-ci-check -- \
   --deny=warnings \
   --deny=clippy::default_trait_access \
-  --deny=clippy::integer_arithmetic \
+  --deny=clippy::arithmetic_side_effects \
   --deny=clippy::manual_let_else \
   --deny=clippy::used_underscore_binding \
   "${nightly_clippy_allows[@]}"
@@ -87,7 +87,7 @@ _ scripts/cargo-for-all-lock-files.sh -- "+${rust_nightly}" clippy --workspace -
 _ scripts/cargo-for-all-lock-files.sh -- clippy --workspace  --tests --bins --examples --features dummy-for-ci-check -- \
   --deny=warnings \
   --deny=clippy::default_trait_access \
-  --deny=clippy::integer_arithmetic \
+  --deny=clippy::arithmetic_side_effects \
   --deny=clippy::manual_let_else \
   --deny=clippy::used_underscore_binding
 

cli-output/src/lib.rs

@@ -1,4 +1,4 @@
-#![allow(clippy::integer_arithmetic)]
+#![allow(clippy::arithmetic_side_effects)]
 mod cli_output;
 pub mod cli_version;
 pub mod display;

cli/src/lib.rs

@@ -1,4 +1,4 @@
-#![allow(clippy::integer_arithmetic)]
+#![allow(clippy::arithmetic_side_effects)]
 macro_rules! ACCOUNT_STRING {
     () => {
         r#", one of:

cli/tests/nonce.rs

@@ -1,4 +1,4 @@
-#![allow(clippy::integer_arithmetic)]
+#![allow(clippy::arithmetic_side_effects)]
 use {
     solana_cli::{
         check_balance,

cli/tests/program.rs

@@ -1,4 +1,4 @@
-#![allow(clippy::integer_arithmetic)]
+#![allow(clippy::arithmetic_side_effects)]
 
 use {
     serde_json::Value,

cli/tests/request_airdrop.rs

@@ -1,4 +1,4 @@
-#![allow(clippy::integer_arithmetic)]
+#![allow(clippy::arithmetic_side_effects)]
 use {
     solana_cli::cli::{process_command, CliCommand, CliConfig},
     solana_faucet::faucet::run_local_faucet,

cli/tests/stake.rs

@@ -1,4 +1,4 @@
-#![allow(clippy::integer_arithmetic)]
+#![allow(clippy::arithmetic_side_effects)]
 #![allow(clippy::redundant_closure)]
 use {
     assert_matches::assert_matches,

cli/tests/transfer.rs

@@ -1,4 +1,4 @@
-#![allow(clippy::integer_arithmetic)]
+#![allow(clippy::arithmetic_side_effects)]
 #![allow(clippy::redundant_closure)]
 use {
     solana_cli::{

cli/tests/vote.rs

@@ -1,4 +1,4 @@
-#![allow(clippy::integer_arithmetic)]
+#![allow(clippy::arithmetic_side_effects)]
 use {
     solana_cli::{
         check_balance,

client/src/lib.rs

@@ -1,4 +1,4 @@
-#![allow(clippy::integer_arithmetic)]
+#![allow(clippy::arithmetic_side_effects)]
 
 pub mod connection_cache;
 pub mod nonblocking;

client/src/transaction_executor.rs

@@ -1,4 +1,4 @@
-#![allow(clippy::integer_arithmetic)]
+#![allow(clippy::arithmetic_side_effects)]
 use {
     log::*,
     solana_measure::measure::Measure,

connection-cache/src/lib.rs

@@ -1,4 +1,4 @@
-#![allow(clippy::integer_arithmetic)]
+#![allow(clippy::arithmetic_side_effects)]
 
 pub mod client_connection;
 pub mod connection_cache;

core/benches/banking_stage.rs

@@ -1,4 +1,4 @@
-#![allow(clippy::integer_arithmetic)]
+#![allow(clippy::arithmetic_side_effects)]
 #![feature(test)]
 
 extern crate test;

core/benches/consumer.rs

@@ -1,4 +1,4 @@
-#![allow(clippy::integer_arithmetic)]
+#![allow(clippy::arithmetic_side_effects)]
 #![feature(test)]
 
 use {

core/benches/shredder.rs

@@ -1,4 +1,4 @@
-#![allow(clippy::integer_arithmetic)]
+#![allow(clippy::arithmetic_side_effects)]
 #![feature(test)]
 
 extern crate test;

core/benches/sigverify_stage.rs

@@ -1,5 +1,5 @@
 #![feature(test)]
-#![allow(clippy::integer_arithmetic)]
+#![allow(clippy::arithmetic_side_effects)]
 
 extern crate solana_core;
 extern crate test;

core/src/lib.rs

@@ -1,5 +1,5 @@
 #![cfg_attr(RUSTC_WITH_SPECIALIZATION, feature(min_specialization))]
-#![allow(clippy::integer_arithmetic)]
+#![allow(clippy::arithmetic_side_effects)]
 #![recursion_limit = "2048"]
 //! The `solana` library implements the Solana high-performance blockchain architecture.
 //! It includes a full Rust implementation of the architecture (see

core/tests/epoch_accounts_hash.rs

@@ -1,3 +1,6 @@
+// REMOVE once https://github.com/rust-lang/rust-clippy/issues/11153 is fixed
+#![allow(clippy::items_after_test_module)]
+
 use {
     crate::snapshot_utils::create_tmp_accounts_dir_for_tests,
     log::*,
@@ -665,7 +668,7 @@ fn test_epoch_accounts_hash_and_warping() {
 // https://github.com/rust-lang/rust/pull/88582
 // https://github.com/jhpratt/rust/blob/727a4fc7e3f836938dfeb4a2ab237cfca612222d/library/core/src/num/uint_macros.rs#L1811-L1837
 const fn next_multiple_of(lhs: u64, rhs: u64) -> u64 {
-    #![allow(clippy::integer_arithmetic)]
+    #![allow(clippy::arithmetic_side_effects)]
     match lhs % rhs {
         0 => lhs,
         r => lhs + (rhs - r),

core/tests/fork-selection.rs

@@ -71,7 +71,7 @@
 //! ```
 //! time: 4007, tip converged: 10, trunk id: 3830, trunk time: 3827, trunk converged 100, trunk height 348
 //! ```
-#![allow(clippy::integer_arithmetic)]
+#![allow(clippy::arithmetic_side_effects)]
 
 extern crate rand;
 use {

core/tests/ledger_cleanup.rs

@@ -1,4 +1,4 @@
-#![allow(clippy::integer_arithmetic)]
+#![allow(clippy::arithmetic_side_effects)]
 // Long-running ledger_cleanup tests
 
 #[cfg(test)]

core/tests/snapshots.rs

@@ -1,4 +1,4 @@
-#![allow(clippy::integer_arithmetic)]
+#![allow(clippy::arithmetic_side_effects)]
 
 use {
     crate::snapshot_utils::create_tmp_accounts_dir_for_tests,

cost-model/src/lib.rs

@@ -1,5 +1,5 @@
 #![cfg_attr(RUSTC_WITH_SPECIALIZATION, feature(min_specialization))]
-#![allow(clippy::integer_arithmetic)]
+#![allow(clippy::arithmetic_side_effects)]
 
 pub mod block_cost_limits;
 pub mod cost_model;

dos/src/lib.rs

@@ -1,2 +1,2 @@
-#![allow(clippy::integer_arithmetic)]
+#![allow(clippy::arithmetic_side_effects)]
 pub mod cli;

dos/src/main.rs

@@ -38,7 +38,7 @@
 //! solana-dos $COMMON --valid-blockhash --transaction-type account-creation
 //! ```
 //!
-#![allow(clippy::integer_arithmetic)]
+#![allow(clippy::arithmetic_side_effects)]
 use {
     crossbeam_channel::{select, tick, unbounded, Receiver, Sender},
     itertools::Itertools,

download-utils/src/lib.rs

@@ -1,4 +1,4 @@
-#![allow(clippy::integer_arithmetic)]
+#![allow(clippy::arithmetic_side_effects)]
 use {
     console::Emoji,
     indicatif::{ProgressBar, ProgressStyle},

entry/src/lib.rs

@@ -1,4 +1,4 @@
-#![allow(clippy::integer_arithmetic)]
+#![allow(clippy::arithmetic_side_effects)]
 pub mod entry;
 pub mod poh;
 

genesis/src/lib.rs

@@ -1,4 +1,4 @@
-#![allow(clippy::integer_arithmetic)]
+#![allow(clippy::arithmetic_side_effects)]
 pub mod address_generator;
 pub mod genesis_accounts;
 pub mod stakes;

genesis/src/main.rs

@@ -1,5 +1,5 @@
 //! A command-line executable for generating the chain's genesis config.
-#![allow(clippy::integer_arithmetic)]
+#![allow(clippy::arithmetic_side_effects)]
 
 use {
     base64::{prelude::BASE64_STANDARD, Engine},

gossip/src/lib.rs

@@ -1,5 +1,5 @@
 #![cfg_attr(RUSTC_WITH_SPECIALIZATION, feature(min_specialization))]
-#![allow(clippy::integer_arithmetic)]
+#![allow(clippy::arithmetic_side_effects)]
 
 pub mod cluster_info;
 pub mod cluster_info_metrics;

gossip/tests/crds_gossip.rs

@@ -1,4 +1,4 @@
-#![allow(clippy::integer_arithmetic)]
+#![allow(clippy::arithmetic_side_effects)]
 use {
     bincode::serialized_size,
     log::*,

gossip/tests/gossip.rs

@@ -1,4 +1,4 @@
-#![allow(clippy::integer_arithmetic)]
+#![allow(clippy::arithmetic_side_effects)]
 #[macro_use]
 extern crate log;
 

install/src/lib.rs

@@ -1,4 +1,4 @@
-#![allow(clippy::integer_arithmetic)]
+#![allow(clippy::arithmetic_side_effects)]
 #[macro_use]
 extern crate lazy_static;
 

keygen/src/keygen.rs

@@ -1,4 +1,4 @@
-#![allow(clippy::integer_arithmetic)]
+#![allow(clippy::arithmetic_side_effects)]
 use {
     bip39::{Mnemonic, MnemonicType, Seed},
     clap::{crate_description, crate_name, Arg, ArgMatches, Command},

ledger-tool/src/main.rs

@@ -1,4 +1,4 @@
-#![allow(clippy::integer_arithmetic)]
+#![allow(clippy::arithmetic_side_effects)]
 use {
     crate::{args::*, bigtable::*, ledger_path::*, ledger_utils::*, output::*, program::*},
     chrono::{DateTime, Utc},

ledger/benches/blockstore.rs

@@ -1,4 +1,4 @@
-#![allow(clippy::integer_arithmetic)]
+#![allow(clippy::arithmetic_side_effects)]
 #![feature(test)]
 extern crate solana_ledger;
 extern crate test;

ledger/benches/protobuf.rs

@@ -1,4 +1,4 @@
-#![allow(clippy::integer_arithmetic)]
+#![allow(clippy::arithmetic_side_effects)]
 #![feature(test)]
 extern crate test;
 

ledger/src/lib.rs

@@ -1,5 +1,5 @@
 #![cfg_attr(RUSTC_WITH_SPECIALIZATION, feature(min_specialization))]
-#![allow(clippy::integer_arithmetic)]
+#![allow(clippy::arithmetic_side_effects)]
 
 pub mod bank_forks_utils;
 pub mod bigtable_delete;

ledger/tests/shred.rs

@@ -1,4 +1,4 @@
-#![allow(clippy::integer_arithmetic)]
+#![allow(clippy::arithmetic_side_effects)]
 use {
     solana_entry::entry::Entry,
     solana_ledger::shred::{

local-cluster/src/lib.rs

@@ -1,4 +1,4 @@
-#![allow(clippy::integer_arithmetic)]
+#![allow(clippy::arithmetic_side_effects)]
 pub mod cluster;
 pub mod cluster_tests;
 pub mod integration_tests;

local-cluster/tests/local_cluster.rs

@@ -1,4 +1,4 @@
-#![allow(clippy::integer_arithmetic)]
+#![allow(clippy::arithmetic_side_effects)]
 use {
     assert_matches::assert_matches,
     crossbeam_channel::{unbounded, Receiver},

log-analyzer/src/main.rs

@@ -1,4 +1,4 @@
-#![allow(clippy::integer_arithmetic)]
+#![allow(clippy::arithmetic_side_effects)]
 extern crate byte_unit;
 
 use {

measure/src/lib.rs

@@ -1,3 +1,3 @@
-#![allow(clippy::integer_arithmetic)]
+#![allow(clippy::arithmetic_side_effects)]
 pub mod macros;
 pub mod measure;

memory-management/src/aligned_memory.rs

@@ -208,7 +208,7 @@ impl<const ALIGN: usize, T: AsRef<[u8]>> From<T> for AlignedMemory<ALIGN> {
 
 #[cfg(test)]
 mod tests {
-    #![allow(clippy::integer_arithmetic)]
+    #![allow(clippy::arithmetic_side_effects)]
     use {super::*, std::io::Write};
 
     fn do_test<const ALIGN: usize>() {

memory-management/src/lib.rs

@@ -1,4 +1,4 @@
-#![deny(clippy::integer_arithmetic)]
+#![deny(clippy::arithmetic_side_effects)]
 pub mod aligned_memory;
 
 /// Returns true if `ptr` is aligned to `align`.

merkle-tree/src/lib.rs

@@ -1,4 +1,4 @@
-#![allow(clippy::integer_arithmetic)]
+#![allow(clippy::arithmetic_side_effects)]
 
 #[cfg(target_os = "solana")]
 #[macro_use]

metrics/src/lib.rs

@@ -1,4 +1,4 @@
-#![allow(clippy::integer_arithmetic)]
+#![allow(clippy::arithmetic_side_effects)]
 pub mod counter;
 pub mod datapoint;
 pub mod metrics;

net-shaper/src/main.rs

@@ -1,4 +1,4 @@
-#![allow(clippy::integer_arithmetic)]
+#![allow(clippy::arithmetic_side_effects)]
 use {
     clap::{crate_description, crate_name, crate_version, Arg, ArgMatches, Command},
     rand::{thread_rng, Rng},

net-utils/src/lib.rs

@@ -1,5 +1,5 @@
 //! The `net_utils` module assists with networking
-#![allow(clippy::integer_arithmetic)]
+#![allow(clippy::arithmetic_side_effects)]
 use {
     crossbeam_channel::unbounded,
     log::*,

perf/benches/dedup.rs

@@ -1,4 +1,4 @@
-#![allow(clippy::integer_arithmetic)]
+#![allow(clippy::arithmetic_side_effects)]
 #![feature(test)]
 
 extern crate test;

perf/benches/shrink.rs

@@ -1,4 +1,4 @@
-#![allow(clippy::integer_arithmetic)]
+#![allow(clippy::arithmetic_side_effects)]
 #![feature(test)]
 
 extern crate test;

perf/src/deduper.rs

@@ -64,7 +64,7 @@ impl<const K: usize, T: ?Sized + Hash> Deduper<K, T> {
 
     // Returns true if the data is duplicate.
     #[must_use]
-    #[allow(clippy::integer_arithmetic)]
+    #[allow(clippy::arithmetic_side_effects)]
     pub fn dedup(&self, data: &T) -> bool {
         let mut out = true;
         let hashers = self.state.iter().map(RandomState::build_hasher);
@@ -114,7 +114,7 @@ pub fn dedup_packets_and_count_discards<const K: usize>(
 }
 
 #[cfg(test)]
-#[allow(clippy::integer_arithmetic)]
+#[allow(clippy::arithmetic_side_effects)]
 mod tests {
     use {
         super::*,

perf/src/sigverify.rs

@@ -676,7 +676,7 @@ pub fn ed25519_verify(
 }
 
 #[cfg(test)]
-#[allow(clippy::integer_arithmetic)]
+#[allow(clippy::arithmetic_side_effects)]
 mod tests {
     use {
         super::*,

poh-bench/src/main.rs

@@ -1,4 +1,4 @@
-#![allow(clippy::integer_arithmetic)]
+#![allow(clippy::arithmetic_side_effects)]
 #[cfg(any(target_arch = "x86", target_arch = "x86_64"))]
 use solana_entry::entry::{self, create_ticks, init_poh, EntrySlice, VerifyRecyclers};
 #[cfg(not(any(target_arch = "x86", target_arch = "x86_64")))]

poh/src/lib.rs

@@ -1,4 +1,4 @@
-#![allow(clippy::integer_arithmetic)]
+#![allow(clippy::arithmetic_side_effects)]
 pub mod leader_bank_notifier;
 pub mod poh_recorder;
 pub mod poh_service;

program-runtime/src/lib.rs

@@ -1,5 +1,5 @@
 #![cfg_attr(RUSTC_WITH_SPECIALIZATION, feature(min_specialization))]
-#![deny(clippy::integer_arithmetic)]
+#![deny(clippy::arithmetic_side_effects)]
 #![deny(clippy::indexing_slicing)]
 #![recursion_limit = "2048"]
 

program-test/src/lib.rs

@@ -1,5 +1,5 @@
 //! The solana-program-test provides a BanksClient-based test framework SBF programs
-#![allow(clippy::integer_arithmetic)]
+#![allow(clippy::arithmetic_side_effects)]
 
 // Export tokio for test clients
 pub use tokio;

program-test/tests/warp.rs

@@ -1,4 +1,4 @@
-#![allow(clippy::integer_arithmetic)]
+#![allow(clippy::arithmetic_side_effects)]
 use {
     bincode::deserialize,
     log::debug,

programs/bpf_loader/src/lib.rs

@@ -1,4 +1,4 @@
-#![deny(clippy::integer_arithmetic)]
+#![deny(clippy::arithmetic_side_effects)]
 #![deny(clippy::indexing_slicing)]
 
 pub mod serialization;

programs/bpf_loader/src/serialization.rs

@@ -1,4 +1,4 @@
-#![allow(clippy::integer_arithmetic)]
+#![allow(clippy::arithmetic_side_effects)]
 
 use {
     byteorder::{ByteOrder, LittleEndian},

programs/bpf_loader/src/syscalls/cpi.rs

@@ -1632,7 +1632,7 @@ fn account_realloc_region<'a>(
 }
 
 #[allow(clippy::indexing_slicing)]
-#[allow(clippy::integer_arithmetic)]
+#[allow(clippy::arithmetic_side_effects)]
 #[cfg(test)]
 mod tests {
     use {

programs/bpf_loader/src/syscalls/mod.rs

@@ -367,11 +367,13 @@ fn translate_type_inner<'a, T>(
     check_aligned: bool,
 ) -> Result<&'a mut T, Error> {
     let host_addr = translate(memory_mapping, access_type, vm_addr, size_of::<T>() as u64)?;
-
-    if check_aligned && !address_is_aligned::<T>(host_addr) {
-        return Err(SyscallError::UnalignedPointer.into());
+    if !check_aligned {
+        Ok(unsafe { std::mem::transmute::<u64, &mut T>(host_addr) })
+    } else if !address_is_aligned::<T>(host_addr) {
+        Err(SyscallError::UnalignedPointer.into())
+    } else {
+        Ok(unsafe { &mut *(host_addr as *mut T) })
     }
-    Ok(unsafe { &mut *(host_addr as *mut T) })
 }
 fn translate_type_mut<'a, T>(
     memory_mapping: &MemoryMapping,
@@ -1879,7 +1881,7 @@ declare_syscall!(
 );
 
 #[cfg(test)]
-#[allow(clippy::integer_arithmetic)]
+#[allow(clippy::arithmetic_side_effects)]
 #[allow(clippy::indexing_slicing)]
 mod tests {
     #[allow(deprecated)]

programs/config/src/lib.rs

@@ -1,4 +1,4 @@
-#![allow(clippy::integer_arithmetic)]
+#![allow(clippy::arithmetic_side_effects)]
 pub mod config_instruction;
 pub mod config_processor;
 pub mod date_instruction;

programs/sbf/benches/bpf_loader.rs

@@ -1,7 +1,7 @@
 #![feature(test)]
 #![cfg(feature = "sbf_c")]
 #![allow(clippy::uninlined_format_args)]
-#![allow(clippy::integer_arithmetic)]
+#![allow(clippy::arithmetic_side_effects)]
 
 use {
     solana_rbpf::memory_region::MemoryState,

programs/sbf/rust/128bit/src/lib.rs

@@ -1,6 +1,6 @@
 //! Example Rust-based SBF program tests loop iteration
 
-#![allow(clippy::integer_arithmetic)]
+#![allow(clippy::arithmetic_side_effects)]
 
 extern crate solana_program;
 use solana_program::{custom_heap_default, custom_panic_default, entrypoint::SUCCESS};

programs/sbf/rust/128bit_dep/src/lib.rs

@@ -1,6 +1,6 @@
 //! Solana Rust-based SBF program utility functions and types
 
-#![allow(clippy::integer_arithmetic)]
+#![allow(clippy::arithmetic_side_effects)]
 
 extern crate solana_program;
 

programs/sbf/rust/alloc/src/lib.rs

@@ -1,6 +1,6 @@
 //! Example Rust-based SBF program that test dynamic memory allocation
 
-#![allow(clippy::integer_arithmetic)]
+#![allow(clippy::arithmetic_side_effects)]
 
 #[macro_use]
 extern crate alloc;

programs/sbf/rust/custom_heap/src/lib.rs

@@ -1,6 +1,6 @@
 //! Example Rust-based SBF that tests out using a custom heap
 
-#![allow(clippy::integer_arithmetic)]
+#![allow(clippy::arithmetic_side_effects)]
 
 use {
     solana_program::{

programs/sbf/rust/deprecated_loader/src/lib.rs

@@ -1,7 +1,7 @@
 //! Example Rust-based SBF program that supports the deprecated loader
 
 #![allow(unreachable_code)]
-#![allow(clippy::integer_arithmetic)]
+#![allow(clippy::arithmetic_side_effects)]
 
 extern crate solana_program;
 use solana_program::{

programs/sbf/rust/dup_accounts/src/lib.rs

@@ -1,6 +1,6 @@
 //! Example Rust-based SBF program that tests duplicate accounts passed via accounts
 
-#![allow(clippy::integer_arithmetic)]
+#![allow(clippy::arithmetic_side_effects)]
 
 extern crate solana_program;
 use solana_program::{

programs/sbf/rust/external_spend/src/lib.rs

@@ -1,6 +1,6 @@
 //! Example Rust-based SBF program that moves a lamport from one account to another
 
-#![allow(clippy::integer_arithmetic)]
+#![allow(clippy::arithmetic_side_effects)]
 
 extern crate solana_program;
 use solana_program::{account_info::AccountInfo, entrypoint::ProgramResult, pubkey::Pubkey};

programs/sbf/rust/invoked/src/processor.rs

@@ -1,7 +1,7 @@
 //! Example Rust-based SBF program that issues a cross-program-invocation
 
 #![cfg(feature = "program")]
-#![allow(clippy::integer_arithmetic)]
+#![allow(clippy::arithmetic_side_effects)]
 
 use {
     crate::instructions::*,

programs/sbf/rust/iter/src/lib.rs

@@ -1,6 +1,6 @@
 //! Example Rust-based SBF program tests loop iteration
 
-#![allow(clippy::integer_arithmetic)]
+#![allow(clippy::arithmetic_side_effects)]
 
 extern crate solana_program;
 use solana_program::{

programs/sbf/rust/many_args/src/helper.rs

@@ -1,6 +1,6 @@
 //! Example Rust-based SBF program tests loop iteration
 
-#![allow(clippy::integer_arithmetic)]
+#![allow(clippy::arithmetic_side_effects)]
 
 extern crate solana_program;
 use solana_program::log::*;

programs/sbf/rust/many_args_dep/src/lib.rs

@@ -1,6 +1,6 @@
 //! Solana Rust-based SBF program utility functions and types
 
-#![allow(clippy::integer_arithmetic)]
+#![allow(clippy::arithmetic_side_effects)]
 
 extern crate solana_program;
 use solana_program::{log::sol_log_64, msg};

programs/sbf/rust/param_passing_dep/src/lib.rs

@@ -1,6 +1,6 @@
 //! Example Rust-based SBF program tests loop iteration
 
-#![allow(clippy::integer_arithmetic)]
+#![allow(clippy::arithmetic_side_effects)]
 
 extern crate solana_program;
 

programs/sbf/rust/sanity/src/lib.rs

@@ -1,7 +1,7 @@
 //! Example Rust-based SBF sanity program that prints out the parameters passed to it
 
 #![allow(unreachable_code)]
-#![allow(clippy::integer_arithmetic)]
+#![allow(clippy::arithmetic_side_effects)]
 
 extern crate solana_program;
 use solana_program::{

programs/sbf/rust/sibling_inner_instruction/src/lib.rs

@@ -1,7 +1,7 @@
 //! Example Rust-based SBF program that queries sibling instructions
 
 #![cfg(feature = "program")]
-#![allow(clippy::integer_arithmetic)]
+#![allow(clippy::arithmetic_side_effects)]
 
 use solana_program::{
     account_info::AccountInfo,

programs/sbf/rust/simulation/src/lib.rs

@@ -1,4 +1,4 @@
-#![allow(clippy::integer_arithmetic)]
+#![allow(clippy::arithmetic_side_effects)]
 
 use {
     solana_program::{

programs/sbf/rust/spoof1_system/src/lib.rs

@@ -1,4 +1,4 @@
-#![allow(clippy::integer_arithmetic)]
+#![allow(clippy::arithmetic_side_effects)]
 
 use solana_program::{account_info::AccountInfo, entrypoint::ProgramResult, pubkey::Pubkey};
 

programs/stake/src/lib.rs

@@ -1,5 +1,5 @@
 #![cfg_attr(RUSTC_WITH_SPECIALIZATION, feature(min_specialization))]
-#![allow(clippy::integer_arithmetic)]
+#![allow(clippy::arithmetic_side_effects)]
 #[deprecated(
     since = "1.8.0",
     note = "Please use `solana_sdk::stake::program::id` or `solana_program::stake::program::id` instead"

programs/system/src/lib.rs

@@ -1,4 +1,4 @@
-#![allow(clippy::integer_arithmetic)]
+#![allow(clippy::arithmetic_side_effects)]
 pub mod system_instruction;
 pub mod system_processor;
 

pubsub-client/src/lib.rs

@@ -1,4 +1,4 @@
-#![allow(clippy::integer_arithmetic)]
+#![allow(clippy::arithmetic_side_effects)]
 
 pub mod nonblocking;
 pub mod pubsub_client;

quic-client/src/lib.rs

@@ -1,4 +1,4 @@
-#![allow(clippy::integer_arithmetic)]
+#![allow(clippy::arithmetic_side_effects)]
 
 pub mod nonblocking;
 pub mod quic_client;

remote-wallet/src/lib.rs

@@ -1,4 +1,4 @@
-#![allow(clippy::integer_arithmetic)]
+#![allow(clippy::arithmetic_side_effects)]
 #![allow(dead_code)]
 pub mod ledger;
 pub mod ledger_error;

rpc-client-api/src/lib.rs

@@ -1,4 +1,4 @@
-#![allow(clippy::integer_arithmetic)]
+#![allow(clippy::arithmetic_side_effects)]
 
 pub mod client_error;
 pub mod config;