From 9fc30f6db48dd66c4b56b2af92da5b09481609be Mon Sep 17 00:00:00 2001 From: Pankaj Garg Date: Sat, 13 Oct 2018 13:35:54 -0700 Subject: [PATCH] Escape RUST_LOG configuration in remote-node.sh (#1489) * Escape RUST_LOG configuration in remote-node.sh - If it was set to #, it was causing other parameters to be commented out * escape other variables as well * disabled shell check * Fix shellcheck error --- net/remote/remote-node.sh | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/net/remote/remote-node.sh b/net/remote/remote-node.sh index 21d79ef5a2..cdbbeb026a 100755 --- a/net/remote/remote-node.sh +++ b/net/remote/remote-node.sh @@ -43,12 +43,13 @@ snap) net/scripts/rsync-retry.sh -vPrc "$entrypointIp:~/solana/solana.snap" . sudo snap install solana.snap --devmode --dangerous + # shellcheck disable=SC2089 commonNodeConfig="\ - leader-ip=$entrypointIp \ + leader-ip=\"$entrypointIp\" \ default-metrics-rate=1 \ - metrics-config=$SOLANA_METRICS_CONFIG \ - rust-log=$RUST_LOG \ - setup-args=$setupArgs \ + metrics-config=\"$SOLANA_METRICS_CONFIG\" \ + rust-log=\"$RUST_LOG\" \ + setup-args=\"$setupArgs\" \ " if [[ -e /dev/nvidia0 ]]; then @@ -68,7 +69,7 @@ snap) logger "$logmarker" # shellcheck disable=SC2086 # Don't want to double quote "$nodeConfig" - sudo snap set solana $nodeConfig + sudo snap set solana "$nodeConfig" snap info solana sudo snap get solana echo Slight delay to get more syslog output