remove AccountsBackgroundService::new(caching_enabled) (#29234)

core/src/validator.rs

@@ -635,7 +635,6 @@ impl Validator {
                 snapshot_request_handler,
                 pruned_banks_request_handler,
             },
-            true, // caching_enabled
             config.accounts_db_test_hash_calculation,
             last_full_snapshot_slot,
         );

core/tests/epoch_accounts_hash.rs

@@ -221,7 +221,6 @@ impl BackgroundServices {
                 snapshot_request_handler,
                 pruned_banks_request_handler,
             },
-            true,
             false,
             None,
         );

core/tests/snapshots.rs

@@ -1040,14 +1040,8 @@ fn test_snapshots_with_background_services(
         snapshot_test_config.snapshot_config.clone(),
     );
 
-    let accounts_background_service = AccountsBackgroundService::new(
-        bank_forks.clone(),
-        &exit,
-        abs_request_handler,
-        true,
-        false,
-        None,
-    );
+    let accounts_background_service =
+        AccountsBackgroundService::new(bank_forks.clone(), &exit, abs_request_handler, false, None);
 
     let mut last_full_snapshot_slot = None;
     let mut last_incremental_snapshot_slot = None;

ledger-tool/src/main.rs

@@ -1156,7 +1156,6 @@ fn load_bank_forks(
         bank_forks.clone(),
         &exit,
         abs_request_handler,
-        true,
         process_options.accounts_db_test_hash_calculation,
         None,
     );

runtime/src/accounts_background_service.rs

@@ -539,10 +539,10 @@ impl AccountsBackgroundService {
         bank_forks: Arc<RwLock<BankForks>>,
         exit: &Arc<AtomicBool>,
         request_handlers: AbsRequestHandlers,
-        accounts_db_caching_enabled: bool,
         test_hash_calculation: bool,
         mut last_full_snapshot_slot: Option<Slot>,
     ) -> Self {
+        let accounts_db_caching_enabled = true;
         info!("AccountsBackgroundService active");
         let exit = exit.clone();
         let mut consumed_budget = 0;