blockworks-foundation
/
solana
mirror of https://github.com/blockworks-foundation/solana.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

runtime: checked math for Bank::withdraw

This commit is contained in:
Trent Nelson 2021-04-23 02:38:54 -06:00 committed by mergify[bot]
parent dcf2d84b24
commit be29568318
1 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
runtime/src/bank.rs
View File

@ -4019,7 +4019,7 @@ impl Bank {
self.store_account(pubkey, new_account);
}
pub fn withdraw(&self, pubkey: &Pubkey, lamports: u64) -> Result<()> {
fn withdraw(&self, pubkey: &Pubkey, lamports: u64) -> Result<()> {
match self.get_account_with_fixed_root(pubkey) {
Some(mut account) => {
let min_balance = match get_system_account_kind(&account) {
@ -4029,9 +4029,11 @@ impl Bank {
.minimum_balance(nonce::State::size()),
_ => 0,
};
if lamports + min_balance > account.lamports() {
return Err(TransactionError::InsufficientFundsForFee);
}
lamports
.checked_add(min_balance)
.filter(|required_balance| *required_balance <= account.lamports())
.ok_or(TransactionError::InsufficientFundsForFee)?;
account.lamports -= lamports;
self.store_account(pubkey, &account);