Test that off-curve pubkeys fail signature verify
This commit is contained in:
parent
251f974b50
commit
c421d7f1b8
|
@ -3849,6 +3849,7 @@ dependencies = [
|
||||||
"bv",
|
"bv",
|
||||||
"byteorder",
|
"byteorder",
|
||||||
"chrono",
|
"chrono",
|
||||||
|
"curve25519-dalek",
|
||||||
"ed25519-dalek",
|
"ed25519-dalek",
|
||||||
"generic-array 0.14.3",
|
"generic-array 0.14.3",
|
||||||
"hex",
|
"hex",
|
||||||
|
|
|
@ -60,6 +60,7 @@ solana-sdk-macro-frozen-abi = { path = "macro-frozen-abi", version = "1.3.0" }
|
||||||
rustversion = "1.0.3"
|
rustversion = "1.0.3"
|
||||||
|
|
||||||
[dev-dependencies]
|
[dev-dependencies]
|
||||||
|
curve25519-dalek = "2.1.0"
|
||||||
tiny-bip39 = "0.7.0"
|
tiny-bip39 = "0.7.0"
|
||||||
|
|
||||||
[package.metadata.docs.rs]
|
[package.metadata.docs.rs]
|
||||||
|
|
|
@ -579,4 +579,25 @@ mod tests {
|
||||||
pubkeys(&[&alice, &bob])
|
pubkeys(&[&alice, &bob])
|
||||||
);
|
);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
#[test]
|
||||||
|
fn test_off_curve_pubkey_verify_fails() {
|
||||||
|
// Golden point off the ed25519 curve
|
||||||
|
let off_curve_bytes = bs58::decode("9z5nJyQar1FUxVJxpBXzon6kHehbomeYiDaLi9WAMhCq")
|
||||||
|
.into_vec()
|
||||||
|
.unwrap();
|
||||||
|
|
||||||
|
// Confirm golden's off-curvedness
|
||||||
|
let mut off_curve_bits = [0u8; 32];
|
||||||
|
off_curve_bits.copy_from_slice(&off_curve_bytes);
|
||||||
|
let off_curve_point = curve25519_dalek::edwards::CompressedEdwardsY(off_curve_bits);
|
||||||
|
assert_eq!(off_curve_point.decompress(), None);
|
||||||
|
|
||||||
|
let pubkey = Pubkey::new(&off_curve_bytes);
|
||||||
|
let signature = Signature::default();
|
||||||
|
// Unfortunately, ed25519-dalek doesn't surface the internal error types that we'd ideally
|
||||||
|
// `source()` out of the `SignatureError` returned by `verify_strict()`. So the best we
|
||||||
|
// can do is `is_err()` here.
|
||||||
|
assert!(signature.verify_verbose(pubkey.as_ref(), &[0u8]).is_err());
|
||||||
|
}
|
||||||
}
|
}
|
||||||
|
|
Loading…
Reference in New Issue