blockworks-foundation
/
solana
mirror of https://github.com/blockworks-foundation/solana.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

explorer: Don't show successful count if meta missing (#24864)

This commit is contained in:
Justin Starry 2022-04-30 12:11:37 +08:00 committed by GitHub
parent b8c13eb506
commit d07604f770
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 21 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
explorer/src/components/block/BlockOverviewCard.tsx
View File

@ -46,7 +46,12 @@ export function BlockOverviewCard({
const { block, blockLeader, childSlot, childLeader, parentLeader } =
confirmedBlock.data;
const committedTxs = block.transactions.filter((tx) => tx.meta?.err === null);
const showSuccessfulCount = block.transactions.every(
(tx) => tx.meta !== null
);
const successfulTxs = block.transactions.filter(
(tx) => tx.meta?.err === null
);
const epoch = clusterInfo?.epochSchedule.getEpoch(slot);
return (
@ -153,12 +158,14 @@ export function BlockOverviewCard({
<span>{block.transactions.length}</span>
</td>
</tr>
<tr>
<td className="w-100">Successful Transactions</td>
<td className="text-lg-end font-monospace">
<span>{committedTxs.length}</span>
</td>
</tr>
{showSuccessfulCount && (
<tr>
<td className="w-100">Successful Transactions</td>
<td className="text-lg-end font-monospace">
<span>{successfulTxs.length}</span>
</td>
</tr>
)}
</TableCardBody>
</div>

9
explorer/src/components/block/BlockProgramsCard.tsx
View File

@ -53,6 +53,7 @@ export function BlockProgramsCard({ block }: { block: BlockResponse }) {
return 0;
});
const showSuccessRate = block.transactions.every((tx) => tx.meta !== null);
return (
<>
<div className="card">
@ -86,7 +87,9 @@ export function BlockProgramsCard({ block }: { block: BlockResponse }) {
<th className="text-muted">% of Total</th>
<th className="text-muted">Instruction Count</th>
<th className="text-muted">% of Total</th>
<th className="text-muted">Success Rate</th>
{showSuccessRate && (
<th className="text-muted">Success Rate</th>
)}
</tr>
</thead>
<tbody>
@ -102,7 +105,9 @@ export function BlockProgramsCard({ block }: { block: BlockResponse }) {
<td>{((100 * txFreq) / totalTransactions).toFixed(2)}%</td>
<td>{ixFreq}</td>
<td>{((100 * ixFreq) / totalInstructions).toFixed(2)}%</td>
<td>{((100 * successes) / txFreq).toFixed(0)}%</td>
{showSuccessRate && (
<td>{((100 * successes) / txFreq).toFixed(0)}%</td>
)}
</tr>
);
})}