From d5ef18337ccb6742fc7991d28a736346882c0a66 Mon Sep 17 00:00:00 2001 From: Greg Fitzgerald Date: Sun, 2 Sep 2018 23:48:11 -1000 Subject: [PATCH] Remove redundant return value And don't log the same error twice. --- src/bank.rs | 6 ++---- src/replicate_stage.rs | 6 +----- 2 files changed, 3 insertions(+), 9 deletions(-) diff --git a/src/bank.rs b/src/bank.rs index fa835e1969..cd8ee2bd03 100755 --- a/src/bank.rs +++ b/src/bank.rs @@ -453,13 +453,11 @@ impl Bank { } /// Process an ordered list of entries. - pub fn process_entries(&self, entries: Vec) -> Result { - let mut entry_count = 0; + pub fn process_entries(&self, entries: Vec) -> Result<()> { for entry in entries { - entry_count += 1; self.process_entry(entry)?; } - Ok(entry_count) + Ok(()) } /// Append entry blocks to the ledger, verifying them along the way. diff --git a/src/replicate_stage.rs b/src/replicate_stage.rs index 5c91304355..b0cf34aeae 100644 --- a/src/replicate_stage.rs +++ b/src/replicate_stage.rs @@ -62,11 +62,7 @@ impl ReplicateStage { ledger_writer.write_entries(entries)?; } - if res.is_err() { - error!("process_entries {:?}", res); - } - let _ = res?; - + res?; Ok(()) } pub fn new(