blockworks-foundation
/
solana
mirror of https://github.com/blockworks-foundation/solana.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Log all uncommittable errors on validator (#3999)

This commit is contained in:
carllin 2019-04-25 13:37:30 -07:00 committed by GitHub
parent a3c302c36a
commit e4536621df
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
core/src/blocktree_processor.rs
View File

@ -9,7 +9,7 @@ use solana_runtime::locked_accounts_results::LockedAccountsResults;
use solana_sdk::genesis_block::GenesisBlock; use solana_sdk::genesis_block::GenesisBlock;
use solana_sdk::timing::duration_as_ms; use solana_sdk::timing::duration_as_ms;
use solana_sdk::timing::MAX_RECENT_BLOCKHASHES; use solana_sdk::timing::MAX_RECENT_BLOCKHASHES;
use solana_sdk::transaction::{Result, TransactionError}; use solana_sdk::transaction::Result;
use std::result; use std::result;
use std::sync::Arc; use std::sync::Arc;
use std::time::{Duration, Instant}; use std::time::{Duration, Instant};
@ -21,13 +21,6 @@ fn first_err(results: &[Result<()>]) -> Result<()> {
Ok(()) Ok(())
} }
fn is_unexpected_validator_error(r: &Result<()>) -> bool {
match r {
Err(TransactionError::DuplicateSignature) => true,
_ => false,
}
}
fn par_execute_entries(bank: &Bank, entries: &[(&Entry, LockedAccountsResults)]) -> Result<()> { fn par_execute_entries(bank: &Bank, entries: &[(&Entry, LockedAccountsResults)]) -> Result<()> {
inc_new_counter_info!("bank-par_execute_entries-count", entries.len()); inc_new_counter_info!("bank-par_execute_entries-count", entries.len());
let results: Vec<Result<()>> = entries let results: Vec<Result<()>> = entries
@ -44,7 +37,7 @@ fn par_execute_entries(bank: &Bank, entries: &[(&Entry, LockedAccountsResults)])
if first_err.is_none() { if first_err.is_none() {
first_err = Some(r.clone()); first_err = Some(r.clone());
} }
if is_unexpected_validator_error(&r) { if !Bank::can_commit(&r) {
warn!("Unexpected validator error: {:?}", e); warn!("Unexpected validator error: {:?}", e);
solana_metrics::submit( solana_metrics::submit(
solana_metrics::influxdb::Point::new("validator_process_entry_error") solana_metrics::influxdb::Point::new("validator_process_entry_error")