fix shellcheck's concerns

multinode-demo/leader.sh

@@ -1,5 +1,7 @@
 #!/bin/bash
-here=$(dirname $0)
+here=$(dirname "$0")
+
+# shellcheck source=/dev/null
 . "${here}"/myip.sh
 
 myip=$(myip) || exit $?

multinode-demo/myip.sh

@@ -30,7 +30,7 @@ Please choose the IP address you want to advertise to the network:
 "
   done
 
-  while read -p "${prompt}
+  while read -r -p "${prompt}
 please enter a number [0 for default]: " which
   do
     [[ -z ${which} ]] && break;
@@ -46,7 +46,7 @@ please enter a number [0 for default]: " which
 
 }
 
-if [[ ${0} == ${BASH_SOURCE[0]} ]]
+if [[ ${0} == "${BASH_SOURCE[0]}" ]]
 then
     myip "$@"
 fi

multinode-demo/setup.sh

@@ -1,5 +1,7 @@
 #!/bin/bash
-here=$(dirname $0)
+here=$(dirname "$0")
+
+# shellcheck source=/dev/null
 . "${here}"/myip.sh
 
 myip=$(myip) || exit $?

multinode-demo/validator.sh

@@ -1,5 +1,7 @@
 #!/bin/bash
-here=$(dirname $0)
+here=$(dirname "$0")
+
+# shellcheck source=/dev/null
 . "${here}"/myip.sh
 
 leader=$1