diff --git a/runtime/src/bucket_map_holder.rs b/runtime/src/bucket_map_holder.rs index 6598aa7437..8f7999fea3 100644 --- a/runtime/src/bucket_map_holder.rs +++ b/runtime/src/bucket_map_holder.rs @@ -27,7 +27,7 @@ pub const DEFAULT_DISK_INDEX: Option = Some(10_000); pub struct BucketMapHolder { pub disk: Option>>, - pub count_ages_flushed: AtomicUsize, + pub count_buckets_flushed: AtomicUsize, pub age: AtomicU8, pub stats: BucketMapHolderStats, @@ -68,7 +68,7 @@ impl BucketMapHolder { pub fn increment_age(&self) { // since we are about to change age, there are now 0 buckets that have been flushed at this age // this should happen before the age.fetch_add - let previous = self.count_ages_flushed.swap(0, Ordering::Acquire); + let previous = self.count_buckets_flushed.swap(0, Ordering::Acquire); // fetch_add is defined to wrap. // That's what we want. 0..255, then back to 0. self.age.fetch_add(1, Ordering::Release); @@ -124,17 +124,17 @@ impl BucketMapHolder { } pub fn bucket_flushed_at_current_age(&self) { - self.count_ages_flushed.fetch_add(1, Ordering::Release); + self.count_buckets_flushed.fetch_add(1, Ordering::Release); self.maybe_advance_age(); } /// have all buckets been flushed at the current age? pub fn all_buckets_flushed_at_current_age(&self) -> bool { - self.count_ages_flushed() >= self.bins + self.count_buckets_flushed() >= self.bins } - pub fn count_ages_flushed(&self) -> usize { - self.count_ages_flushed.load(Ordering::Acquire) + pub fn count_buckets_flushed(&self) -> usize { + self.count_buckets_flushed.load(Ordering::Acquire) } pub fn maybe_advance_age(&self) -> bool { @@ -196,7 +196,7 @@ impl BucketMapHolder { Self { disk, ages_to_stay_in_cache, - count_ages_flushed: AtomicUsize::default(), + count_buckets_flushed: AtomicUsize::default(), age: AtomicU8::default(), stats: BucketMapHolderStats::new(bins), wait_dirty_or_aged: Arc::default(), @@ -257,13 +257,13 @@ impl BucketMapHolder { fn throttling_wait_ms(&self) -> Option { let interval_ms = self.age_interval_ms(); let elapsed_ms = self.age_timer.elapsed_ms(); - let bins_flushed = self.count_ages_flushed() as u64; + let bins_flushed = self.count_buckets_flushed() as u64; self.throttling_wait_ms_internal(interval_ms, elapsed_ms, bins_flushed) } /// true if this thread can sleep fn should_thread_sleep(&self) -> bool { - let bins_flushed = self.count_ages_flushed(); + let bins_flushed = self.count_buckets_flushed(); if bins_flushed >= self.bins { // all bins flushed, so this thread can sleep true @@ -376,7 +376,8 @@ pub mod tests { } // this would normally happen once time went off and all buckets had been flushed at the previous age - test.count_ages_flushed.fetch_add(bins, Ordering::Release); + test.count_buckets_flushed + .fetch_add(bins, Ordering::Release); test.increment_age(); } } diff --git a/runtime/src/bucket_map_holder_stats.rs b/runtime/src/bucket_map_holder_stats.rs index 713318ce94..c0a2302bdf 100644 --- a/runtime/src/bucket_map_holder_stats.rs +++ b/runtime/src/bucket_map_holder_stats.rs @@ -94,7 +94,7 @@ impl BucketMapHolderStats { fn ms_per_age(&self, storage: &BucketMapHolder, elapsed_ms: u64) -> u64 { let age_now = storage.current_age(); - let ages_flushed = storage.count_ages_flushed() as u64; + let ages_flushed = storage.count_buckets_flushed() as u64; let last_age = self.last_age.swap(age_now, Ordering::Relaxed) as u64; let last_ages_flushed = self.last_ages_flushed.swap(ages_flushed, Ordering::Relaxed) as u64; let mut age_now = age_now as u64; diff --git a/runtime/src/in_mem_accounts_index.rs b/runtime/src/in_mem_accounts_index.rs index 6016f154ef..4ed80af933 100644 --- a/runtime/src/in_mem_accounts_index.rs +++ b/runtime/src/in_mem_accounts_index.rs @@ -1493,10 +1493,10 @@ mod tests { solana_logger::setup(); let test = new_for_test::(); assert!(test.get_should_age(test.storage.current_age())); - assert_eq!(test.storage.count_ages_flushed(), 0); + assert_eq!(test.storage.count_buckets_flushed(), 0); test.set_has_aged(0); assert!(!test.get_should_age(test.storage.current_age())); - assert_eq!(test.storage.count_ages_flushed(), 1); + assert_eq!(test.storage.count_buckets_flushed(), 1); // simulate rest of buckets aging for _ in 1..BINS_FOR_TESTING { assert!(!test.storage.all_buckets_flushed_at_current_age()); @@ -1508,7 +1508,7 @@ mod tests { assert_eq!(test.storage.current_age(), 1); assert!(!test.storage.all_buckets_flushed_at_current_age()); assert!(test.get_should_age(test.storage.current_age())); - assert_eq!(test.storage.count_ages_flushed(), 0); + assert_eq!(test.storage.count_buckets_flushed(), 0); } #[test]