From f8d304c6108b13e5cbdfc27180f007892afaa7d4 Mon Sep 17 00:00:00 2001 From: Andrew Fitzgerald Date: Tue, 5 Sep 2023 16:08:48 -0700 Subject: [PATCH] Drop poh_service to avoid unwanted ticking (#33150) --- core/src/banking_stage/decision_maker.rs | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/core/src/banking_stage/decision_maker.rs b/core/src/banking_stage/decision_maker.rs index edf67960d6..6d26a9d0fc 100644 --- a/core/src/banking_stage/decision_maker.rs +++ b/core/src/banking_stage/decision_maker.rs @@ -152,6 +152,9 @@ mod tests { let blockstore = Arc::new(Blockstore::open(ledger_path.as_path()).unwrap()); let (exit, poh_recorder, poh_service, _entry_receiver) = create_test_recorder(bank.clone(), blockstore, None, None); + // Drop the poh service immediately to avoid potential ticking + exit.store(true, Ordering::Relaxed); + poh_service.join().unwrap(); let my_pubkey = Pubkey::new_unique(); let decision_maker = DecisionMaker::new(my_pubkey, poh_recorder.clone()); @@ -206,9 +209,6 @@ mod tests { let decision = decision_maker.make_consume_or_forward_decision(); assert_matches!(decision, BufferedPacketsDecision::Forward); } - - exit.store(true, Ordering::Relaxed); - poh_service.join().unwrap(); } #[test]