From fe87c05423ac560f04afd42b7cf681ffe1bf3d66 Mon Sep 17 00:00:00 2001
From: Rob Walker <rob@solana.com>
Date: Mon, 15 Jul 2019 13:42:59 -0700
Subject: [PATCH] fix transaction_count (#5110)

* fix transaction_count

* add sig count to bank hash
---
 core/src/banking_stage.rs | 10 ++++++--
 runtime/src/bank.rs       | 49 +++++++++++++++++++++++++++++----------
 2 files changed, 45 insertions(+), 14 deletions(-)

diff --git a/core/src/banking_stage.rs b/core/src/banking_stage.rs
index 474d8038a3..ee90150284 100644
--- a/core/src/banking_stage.rs
+++ b/core/src/banking_stage.rs
@@ -481,7 +481,7 @@ impl BankingStage {
         // the likelihood of any single thread getting starved and processing old ids.
         // TODO: Banking stage threads should be prioritized to complete faster then this queue
         // expires.
-        let (mut loaded_accounts, results, mut retryable_txs) =
+        let (mut loaded_accounts, results, mut retryable_txs, tx_count, signature_count) =
             bank.load_and_execute_transactions(txs, lock_results, MAX_PROCESSING_AGE);
         load_execute_time.stop();
 
@@ -501,7 +501,13 @@ impl BankingStage {
 
         let commit_time = {
             let mut commit_time = Measure::start("commit_time");
-            bank.commit_transactions(txs, &mut loaded_accounts, &results);
+            bank.commit_transactions(
+                txs,
+                &mut loaded_accounts,
+                &results,
+                tx_count,
+                signature_count,
+            );
             commit_time.stop();
             commit_time
         };
diff --git a/runtime/src/bank.rs b/runtime/src/bank.rs
index a796ccca28..d7a3cc51b0 100644
--- a/runtime/src/bank.rs
+++ b/runtime/src/bank.rs
@@ -18,7 +18,8 @@ use crate::stakes::Stakes;
 use crate::status_cache::StatusCache;
 use crate::storage_utils;
 use crate::storage_utils::StorageAccounts;
-use bincode::{deserialize_from, serialize, serialize_into, serialized_size};
+use bincode::{deserialize_from, serialize_into, serialized_size};
+use byteorder::{ByteOrder, LittleEndian};
 use log::*;
 use serde::{Deserialize, Serialize};
 use solana_measure::measure::Measure;
@@ -28,7 +29,7 @@ use solana_metrics::{
 use solana_sdk::account::Account;
 use solana_sdk::fee_calculator::FeeCalculator;
 use solana_sdk::genesis_block::GenesisBlock;
-use solana_sdk::hash::{extend_and_hash, Hash};
+use solana_sdk::hash::{hashv, Hash};
 use solana_sdk::inflation::Inflation;
 use solana_sdk::native_loader;
 use solana_sdk::pubkey::Pubkey;
@@ -950,6 +951,8 @@ impl Bank {
         Vec<Result<(InstructionAccounts, InstructionLoaders, InstructionCredits)>>,
         Vec<Result<()>>,
         Vec<usize>,
+        usize,
+        usize,
     ) {
         debug!("processing transactions: {}", txs.len());
         let mut error_counters = ErrorCounters::default();
@@ -1021,13 +1024,14 @@ impl Bank {
             inc_new_counter_error!("bank-process_transactions-error_count", err_count, 0, 1000);
         }
 
-        self.increment_transaction_count(tx_count);
-        self.increment_signature_count(signature_count);
-
-        inc_new_counter_info!("bank-process_transactions-txs", tx_count, 0, 1000);
-        inc_new_counter_info!("bank-process_transactions-sigs", signature_count, 0, 1000);
         Self::update_error_counters(&error_counters);
-        (loaded_accounts, executed, retryable_txs)
+        (
+            loaded_accounts,
+            executed,
+            retryable_txs,
+            tx_count,
+            signature_count,
+        )
     }
 
     fn filter_program_errors_and_collect_fee(
@@ -1079,11 +1083,19 @@ impl Bank {
             InstructionCredits,
         )>],
         executed: &[Result<()>],
+        tx_count: usize,
+        signature_count: usize,
     ) -> Vec<Result<()>> {
         if self.is_frozen() {
             warn!("=========== FIXME: commit_transactions() working on a frozen bank! ================");
         }
 
+        self.increment_transaction_count(tx_count);
+        self.increment_signature_count(signature_count);
+
+        inc_new_counter_info!("bank-process_transactions-txs", tx_count, 0, 1000);
+        inc_new_counter_info!("bank-process_transactions-sigs", signature_count, 0, 1000);
+
         if executed.iter().any(|res| Self::can_commit(res)) {
             self.is_delta.store(true, Ordering::Relaxed);
         }
@@ -1112,10 +1124,16 @@ impl Bank {
         lock_results: &LockedAccountsResults,
         max_age: usize,
     ) -> Vec<Result<()>> {
-        let (mut loaded_accounts, executed, _) =
+        let (mut loaded_accounts, executed, _, tx_count, signature_count) =
             self.load_and_execute_transactions(txs, lock_results, max_age);
 
-        self.commit_transactions(txs, &mut loaded_accounts, &executed)
+        self.commit_transactions(
+            txs,
+            &mut loaded_accounts,
+            &executed,
+            tx_count,
+            signature_count,
+        )
     }
 
     #[must_use]
@@ -1271,7 +1289,14 @@ impl Bank {
         // If there are no accounts, return the same hash as we did before
         // checkpointing.
         if let Some(accounts_delta_hash) = self.rc.accounts.hash_internal_state(self.slot()) {
-            extend_and_hash(&self.parent_hash, &serialize(&accounts_delta_hash).unwrap())
+            let mut signature_count_buf = [0u8; 8];
+            LittleEndian::write_u64(&mut signature_count_buf[..], self.signature_count() as u64);
+
+            hashv(&[
+                &self.parent_hash.as_ref(),
+                &accounts_delta_hash.as_ref(),
+                &signature_count_buf,
+            ])
         } else {
             self.parent_hash
         }
@@ -1782,7 +1807,7 @@ mod tests {
     fn goto_end_of_slot(bank: &mut Bank) {
         let mut tick_hash = bank.last_blockhash();
         loop {
-            tick_hash = extend_and_hash(&tick_hash, &[42]);
+            tick_hash = hashv(&[&tick_hash.as_ref(), &[42]]);
             bank.register_tick(&tick_hash);
             if tick_hash == bank.last_blockhash() {
                 bank.freeze();