remove ProcessOptions::accounts_db_caching_enabled (#29217)

core/src/validator.rs

@@ -1404,7 +1404,6 @@ fn load_blockstore(
         new_hard_forks: config.new_hard_forks.clone(),
         debug_keys: config.debug_keys.clone(),
         account_indexes: config.account_indexes.clone(),
-        accounts_db_caching_enabled: true,
         accounts_db_config: config.accounts_db_config.clone(),
         shrink_ratio: config.accounts_shrink_ratio,
         accounts_db_test_hash_calculation: config.accounts_db_test_hash_calculation,

ledger-tool/src/main.rs

@@ -1156,7 +1156,7 @@ fn load_bank_forks(
         bank_forks.clone(),
         &exit,
         abs_request_handler,
-        process_options.accounts_db_caching_enabled,
+        true,
         process_options.accounts_db_test_hash_calculation,
         None,
     );
@@ -2760,7 +2760,6 @@ fn main() {
                     run_final_accounts_hash_calc: true,
                     halt_at_slot: value_t!(arg_matches, "halt_at_slot", Slot).ok(),
                     debug_keys,
-                    accounts_db_caching_enabled: true,
                     limit_load_slot_count_from_snapshot: value_t!(
                         arg_matches,
                         "limit_load_slot_count_from_snapshot",
@@ -3021,7 +3020,6 @@ fn main() {
                     &genesis_config,
                     &blockstore,
                     ProcessOptions {
-                        accounts_db_caching_enabled: true,
                         new_hard_forks,
                         halt_at_slot: Some(snapshot_slot),
                         poh_verify: false,

ledger/src/bank_forks_utils.rs

@@ -212,7 +212,7 @@ fn bank_forks_from_snapshot(
                 process_options.runtime_config.bpf_jit,
             )),
             process_options.account_indexes.clone(),
-            process_options.accounts_db_caching_enabled,
+            true, // caching_enabled
             process_options.limit_load_slot_count_from_snapshot,
             process_options.shrink_ratio,
             process_options.accounts_db_test_hash_calculation,

ledger/src/blockstore_processor.rs

@@ -704,7 +704,6 @@ pub struct ProcessOptions {
     pub new_hard_forks: Option<Vec<Slot>>,
     pub debug_keys: Option<Arc<HashSet<Pubkey>>>,
     pub account_indexes: AccountSecondaryIndexes,
-    pub accounts_db_caching_enabled: bool,
     pub limit_load_slot_count_from_snapshot: Option<usize>,
     pub allow_dead_slots: bool,
     pub accounts_db_test_hash_calculation: bool,